From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756602AbcLUS0u (ORCPT ); Wed, 21 Dec 2016 13:26:50 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:33700 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcLUS0t (ORCPT ); Wed, 21 Dec 2016 13:26:49 -0500 Date: Wed, 21 Dec 2016 13:26:47 -0500 (EST) Message-Id: <20161221.132647.1022935257419607406.davem@davemloft.net> To: Joao.Pinto@synopsys.com Cc: peppe.cavallaro@st.com, seraphin.bonnaffe@st.com, hock.leong.kweh@intel.com, niklas.cassel@axis.com, pavel@ucw.cz, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3] stmmac: enable rx queues From: David Miller In-Reply-To: <406c3af0c74809090a49d14af6a27cca2f5e9d6b.1482253639.git.jpinto@synopsys.com> References: <406c3af0c74809090a49d14af6a27cca2f5e9d6b.1482253639.git.jpinto@synopsys.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 21 Dec 2016 09:27:32 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joao Pinto Date: Tue, 20 Dec 2016 17:09:28 +0000 > When the hardware is synthesized with multiple queues, all queues are > disabled for default. This patch adds the rx queues configuration. > This patch was successfully tested in a Synopsys QoS Reference design. > > Signed-off-by: Joao Pinto > --- > changes v2 -> v3 (Seraphin Bonnaffe): > - GMAC_RX_QUEUE_CLEAR macro simplified > changes v1 -> v2 (Niklas Cassel and Seraphin Bonnaffe): > - Instead of using number of DMA channels, lets use number of queues > - Create 2 flavors of RX queue enable Macros: AV and DCB (AV by default) > - Make sure that the RX queue related bits are cleared before setting > - Check if rx_queue_enable is available before executing This change seems more appropriate for net-next, please resubmit when that tree opens up again. Thanks.