From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:36704 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758551AbcLUXDs (ORCPT ); Wed, 21 Dec 2016 18:03:48 -0500 Date: Wed, 21 Dec 2016 14:53:44 -0800 From: Stephen Boyd To: Chris Brandt Cc: Geert Uytterhoeven , Geert Uytterhoeven , Michael Turquette , Kuninori Morimoto , Simon Horman , Linux-Renesas , linux-clk Subject: Re: [PATCH v2] clk: renesas: mstp: Support 8-bit registers for r7s72100 Message-ID: <20161221225344.GI5423@codeaurora.org> References: <20161215170027.28411-1-chris.brandt@renesas.com> <20161220225552.GE5423@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 12/21, Chris Brandt wrote: > On December 21, 2016, Geert Uytterhoeven wrote: > > >> Mike/Stephen: as this is a fix for stable (v3.16+), can you please > > >> take it directly? > > > > > > Sure, is it a fix for something that has been exposed as a problem in > > > this merge window? Just trying to gauge the urgency of merging this. > > > > No, I don't think it has been exposed by changes in this merge window (the > > only RZ/A1 changes were the enablement of SDHI and MMC). > > Chris, can you please confirm? > > That's correct. In reality, none of the existing RZ/A1 drivers in the kernel > should have ever worked (ETH, SPI, I2C, MTU2, etc...) because on chip reset > all the peripheral clocks are turned off. > > However...like Geert mentioned...the boot loader was turning everything on > shortly after reset so even though the clock driver never worked, it made > it seems so. Oops. > > Of course now going forward, I use a modified boot loader to turn everything > back off (except the serial console) so I can confirm that clock gating is > really working. > Ok, it seems like a more urgent fix due to the fact that the bootloader update has caused the drivers to stop working. I'll make sure to send it as a fix this release cycle. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project