From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760557AbcLUXPR (ORCPT ); Wed, 21 Dec 2016 18:15:17 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:39640 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757414AbcLUXOs (ORCPT ); Wed, 21 Dec 2016 18:14:48 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org AFC9C60CE1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 21 Dec 2016 15:14:46 -0800 From: Stephen Boyd To: Eric Anholt Cc: Florian Fainelli , Michael Turquette , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, Thierry Reding , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org Subject: Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. Message-ID: <20161221231446.GA8288@codeaurora.org> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-3-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161214194621.16499-3-eric@anholt.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14, Eric Anholt wrote: > > /* the gates */ > > @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device *pdev) > if (IS_ERR(cprman->regs)) > return PTR_ERR(cprman->regs); > > - cprman->osc_name = of_clk_get_parent_name(dev->of_node, 0); > - if (!cprman->osc_name) > + for (i = 0; i < ARRAY_SIZE(cprman_parent_names); i++) { > + cprman->real_parent_names[i] = > + of_clk_get_parent_name(dev->of_node, i); > + } Can we use of_clk_parent_fill() here? Or do we need to support holes in the parent array? If it's the latter please add a comment so we don't mistakenly change this later. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Wed, 21 Dec 2016 15:14:46 -0800 Subject: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. In-Reply-To: <20161214194621.16499-3-eric@anholt.net> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-3-eric@anholt.net> Message-ID: <20161221231446.GA8288@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/14, Eric Anholt wrote: > > /* the gates */ > > @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device *pdev) > if (IS_ERR(cprman->regs)) > return PTR_ERR(cprman->regs); > > - cprman->osc_name = of_clk_get_parent_name(dev->of_node, 0); > - if (!cprman->osc_name) > + for (i = 0; i < ARRAY_SIZE(cprman_parent_names); i++) { > + cprman->real_parent_names[i] = > + of_clk_get_parent_name(dev->of_node, i); > + } Can we use of_clk_parent_fill() here? Or do we need to support holes in the parent array? If it's the latter please add a comment so we don't mistakenly change this later. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. Date: Wed, 21 Dec 2016 15:14:46 -0800 Message-ID: <20161221231446.GA8288@codeaurora.org> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-3-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E7BF6ED37 for ; Wed, 21 Dec 2016 23:14:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161214194621.16499-3-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Mark Rutland , Florian Fainelli , Stephen Warren , Michael Turquette , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gMTIvMTQsIEVyaWMgQW5ob2x0IHdyb3RlOgo+ICAKPiAgCS8qIHRoZSBnYXRlcyAqLwo+ICAK PiBAQCAtMTg5MCw4ICsxOTc2LDE4IEBAIHN0YXRpYyBpbnQgYmNtMjgzNV9jbGtfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWlmIChJU19FUlIoY3BybWFuLT5yZWdzKSkK PiAgCQlyZXR1cm4gUFRSX0VSUihjcHJtYW4tPnJlZ3MpOwo+ICAKPiAtCWNwcm1hbi0+b3NjX25h bWUgPSBvZl9jbGtfZ2V0X3BhcmVudF9uYW1lKGRldi0+b2Zfbm9kZSwgMCk7Cj4gLQlpZiAoIWNw cm1hbi0+b3NjX25hbWUpCj4gKwlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShjcHJtYW5fcGFy ZW50X25hbWVzKTsgaSsrKSB7Cj4gKwkJY3BybWFuLT5yZWFsX3BhcmVudF9uYW1lc1tpXSA9Cj4g KwkJCW9mX2Nsa19nZXRfcGFyZW50X25hbWUoZGV2LT5vZl9ub2RlLCBpKTsKPiArCX0KCkNhbiB3 ZSB1c2Ugb2ZfY2xrX3BhcmVudF9maWxsKCkgaGVyZT8gT3IgZG8gd2UgbmVlZCB0byBzdXBwb3J0 CmhvbGVzIGluIHRoZSBwYXJlbnQgYXJyYXk/IElmIGl0J3MgdGhlIGxhdHRlciBwbGVhc2UgYWRk IGEKY29tbWVudCBzbyB3ZSBkb24ndCBtaXN0YWtlbmx5IGNoYW5nZSB0aGlzIGxhdGVyLgoKLS0g ClF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVy b3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=