All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: wei.liu2@citrix.com, cardoe@cardoe.com,
	ian.jackson@eu.citrix.com, imhy.yang@gmail.com,
	alistair23@gmail.com, rshriram@cs.ubc.ca,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include
Date: Thu, 22 Dec 2016 10:54:15 +0000	[thread overview]
Message-ID: <20161222105415.GN28690@citrix.com> (raw)
In-Reply-To: <1482263220-3233-6-git-send-email-alistair.francis@xilinx.com>

On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alistair Francis wrote:
> To avoid build errors related to missing file 'sys/sysctl.h' by removing
> the #include statement.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>

I can find this in Linux. Maybe this is also due to the libc you're
using?

On the flip side, if this header is unused anyway I think I'm fine with
taking this patch.

> ---
>  tools/blktap2/drivers/block-remus.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/blktap2/drivers/block-remus.c b/tools/blktap2/drivers/block-remus.c
> index 079588d..7401800 100644
> --- a/tools/blktap2/drivers/block-remus.c
> +++ b/tools/blktap2/drivers/block-remus.c
> @@ -54,7 +54,6 @@
>  #include <netinet/in.h>
>  #include <arpa/inet.h>
>  #include <sys/param.h>
> -#include <sys/sysctl.h>
>  #include <unistd.h>
>  #include <sys/stat.h>
>  
> -- 
> 2.7.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-12-22 10:54 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20 19:46 [PATCH v2 0/5] General Build Fixes Alistair Francis
2016-12-20 19:46 ` [PATCH v2 1/5] Remove hardcoded strict -Werror checking Alistair Francis
2016-12-20 20:06   ` Doug Goldstein
2016-12-20 20:16     ` Andrew Cooper
2016-12-21  0:03       ` Alistair Francis
2016-12-21  3:15       ` Doug Goldstein
2016-12-21 11:56         ` Ian Jackson
2016-12-22  8:41   ` Jan Beulich
2016-12-22 19:12     ` Alistair Francis
2016-12-22 19:22       ` Ian Jackson
2016-12-22 21:12         ` Alistair Francis
2016-12-22 21:15           ` Alistair Francis
2016-12-22 21:41             ` Alistair Francis
2016-12-22 21:47               ` Andrew Cooper
2016-12-22 22:00                 ` Doug Goldstein
2016-12-22 22:11                   ` Alistair Francis
2016-12-22 22:16                     ` Alistair Francis
2016-12-27 15:40       ` Jan Beulich
2016-12-27 15:53         ` Jan Beulich
2016-12-27 15:55           ` Doug Goldstein
2016-12-27 17:07           ` Andrew Cooper
2016-12-29 17:10             ` George Dunlap
2016-12-29 17:30               ` Andrew Cooper
2017-01-03  7:39                 ` Jan Beulich
2017-01-03 14:38         ` Ian Jackson
2017-01-03 14:52           ` Jan Beulich
2016-12-20 19:46 ` [PATCH v2 2/5] config/StdGNU.mk: Allows users to pass in EXTRA_CFLAGS Alistair Francis
2016-12-20 19:51   ` Doug Goldstein
2016-12-21 12:05   ` Wei Liu
2016-12-22  8:43   ` Jan Beulich
2016-12-20 19:46 ` [PATCH v2 3/5] tools/blktap2/vhd: Remove unused struct stat stats Alistair Francis
2016-12-20 19:51   ` Doug Goldstein
2016-12-20 19:46 ` [PATCH v2 4/5] tools/blktap2: Fix missing header file Alistair Francis
2016-12-20 19:52   ` Konrad Rzeszutek Wilk
2016-12-20 19:53   ` Doug Goldstein
2016-12-20 19:47 ` [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include Alistair Francis
2016-12-22 10:54   ` Wei Liu [this message]
2016-12-22 15:44     ` Alistair Francis
2016-12-23 11:10       ` Wei Liu
2016-12-23 22:09         ` [PATCH v2 5/5] tools/blktap2/drivers: Removenon-existent " alistair23
2016-12-25 15:57           ` Wei Liu
2016-12-22 15:46   ` [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent " Doug Goldstein
2016-12-20 19:53 ` [PATCH v2 0/5] General Build Fixes Konrad Rzeszutek Wilk
2016-12-20 19:58   ` Alistair Francis
2016-12-22 11:12 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161222105415.GN28690@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=cardoe@cardoe.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=imhy.yang@gmail.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.