From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller Date: Thu, 22 Dec 2016 11:18:02 +0000 Message-ID: <20161222111802.GX14217@n2100.armlinux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:36088 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757285AbcLVLU2 (ORCPT ); Thu, 22 Dec 2016 06:20:28 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Gregory CLEMENT Cc: Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org, Thomas Petazzoni , Andrew Lunn , Yehuda Yitschak , Marcin Wojtas , Jason Cooper , Hanna Hawa , Kostya Porotchkin , Nadav Haklai , Ziji Hu , Jimmy Xu , Doug Jones , Ryan Gao , Jisheng Zhang , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote: > +Optional Properties: > +- mmc-card: > + mmc-card child node must be provided when current SDHC is for eMMC. > + Xenon SDHC often can support both SD and eMMC. This child node indicates that > + current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and > + operations can be enabled prior to eMMC init sequence. > + Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt. > + This child node should not be set if current Xenon SDHC is for SD/SDIO. This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"? Your examples below use "mmccard" as does the documentation you point towards. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Thu, 22 Dec 2016 11:18:02 +0000 Subject: [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller In-Reply-To: References: Message-ID: <20161222111802.GX14217@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote: > +Optional Properties: > +- mmc-card: > + mmc-card child node must be provided when current SDHC is for eMMC. > + Xenon SDHC often can support both SD and eMMC. This child node indicates that > + current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and > + operations can be enabled prior to eMMC init sequence. > + Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt. > + This child node should not be set if current Xenon SDHC is for SD/SDIO. This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"? Your examples below use "mmccard" as does the documentation you point towards. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.