From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K Date: Thu, 22 Dec 2016 11:21:59 +0000 Message-ID: <20161222112159.GY14217@n2100.armlinux.org.uk> References: <2564fe18eb9cc8a0a1a3311cdf7e7141f35211bd.1481651244.git-series.gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:36152 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755467AbcLVLYQ (ORCPT ); Thu, 22 Dec 2016 06:24:16 -0500 Content-Disposition: inline In-Reply-To: <2564fe18eb9cc8a0a1a3311cdf7e7141f35211bd.1481651244.git-series.gregory.clement@free-electrons.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Gregory CLEMENT Cc: Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org, Thomas Petazzoni , Andrew Lunn , Yehuda Yitschak , Marcin Wojtas , Jason Cooper , Hanna Hawa , Kostya Porotchkin , Nadav Haklai , Ziji Hu , Jimmy Xu , Doug Jones , Ryan Gao , Jisheng Zhang , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth On Tue, Dec 13, 2016 at 06:48:40PM +0100, Gregory CLEMENT wrote: > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > index 7b6136182ad0..181e8c5de3bf 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > @@ -229,6 +229,15 @@ > > }; > > + ap_sdhci0: sdhci@6e0000 { > + compatible = "marvell,armada-7000-sdhci"; > + reg = <0x6e0000 0x300>; > + interrupts = ; > + clock-names = "core"; > + clocks = <&cpm_syscon0 1 4>; > + status = "disabled"; > + }; > + > ap_syscon: system-controller@6f4000 { > compatible = "marvell,ap806-system-controller", > "syscon"; > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi > index e5e3ed678b6f..035b2b2fc9ca 100644 > --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi > @@ -164,6 +164,16 @@ > clocks = <&cpm_syscon0 1 21>; > status = "disabled"; > }; > + > + cpm_sdhci0: sdhci@780000 { > + compatible = "marvell,armada-7000-sdhci"; > + reg = <0x780000 0x300>; > + interrupts = ; > + clock-names = "core"; > + clocks = <&cpm_syscon0 1 4>; > + status = "disabled"; > + }; > + One other point - aren't the SDHCI interfaces dma-coherent on the AP806 and CP110? -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Thu, 22 Dec 2016 11:21:59 +0000 Subject: [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K In-Reply-To: <2564fe18eb9cc8a0a1a3311cdf7e7141f35211bd.1481651244.git-series.gregory.clement@free-electrons.com> References: <2564fe18eb9cc8a0a1a3311cdf7e7141f35211bd.1481651244.git-series.gregory.clement@free-electrons.com> Message-ID: <20161222112159.GY14217@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Dec 13, 2016 at 06:48:40PM +0100, Gregory CLEMENT wrote: > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > index 7b6136182ad0..181e8c5de3bf 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > @@ -229,6 +229,15 @@ > > }; > > + ap_sdhci0: sdhci at 6e0000 { > + compatible = "marvell,armada-7000-sdhci"; > + reg = <0x6e0000 0x300>; > + interrupts = ; > + clock-names = "core"; > + clocks = <&cpm_syscon0 1 4>; > + status = "disabled"; > + }; > + > ap_syscon: system-controller at 6f4000 { > compatible = "marvell,ap806-system-controller", > "syscon"; > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi > index e5e3ed678b6f..035b2b2fc9ca 100644 > --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi > @@ -164,6 +164,16 @@ > clocks = <&cpm_syscon0 1 21>; > status = "disabled"; > }; > + > + cpm_sdhci0: sdhci at 780000 { > + compatible = "marvell,armada-7000-sdhci"; > + reg = <0x780000 0x300>; > + interrupts = ; > + clock-names = "core"; > + clocks = <&cpm_syscon0 1 4>; > + status = "disabled"; > + }; > + One other point - aren't the SDHCI interfaces dma-coherent on the AP806 and CP110? -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.