From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941697AbcLVR30 (ORCPT ); Thu, 22 Dec 2016 12:29:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54448 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933162AbcLVR3Z (ORCPT ); Thu, 22 Dec 2016 12:29:25 -0500 Date: Thu, 22 Dec 2016 18:29:37 +0100 From: Greg KH To: Sven Schmidt <4sschmid@informatik.uni-hamburg.de> Cc: akpm@linux-foundation.org, bongkyu.kim@lge.com, sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Update LZ4 compressor module Message-ID: <20161222172937.GA17177@kroah.com> References: <1482259992-16680-1-git-send-email-4sschmid@informatik.uni-hamburg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482259992-16680-1-git-send-email-4sschmid@informatik.uni-hamburg.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2016 at 07:53:09PM +0100, Sven Schmidt wrote: > > This patchset is for updating the LZ4 compression module to a version based > on LZ4 v1.7.2 allowing to use the fast compression algorithm aka LZ4 fast > which provides an "acceleration" parameter as a tradeoff between > compression ratio and compression speed. But why do this? > We will use LZ4 fast in order to support compression in lustre. LZ4 fast empowers > us to do client-side as well as server-side compression/decompression while > being able to provide appropriate parameters to enable users to tune lustre's > behaviour to obtain the best performance/compression/etc. on their behalf > (adapative compression). We don't care about lustre, especially as it is not merged into the main portion of the kernel tree :) Seriously, work on fixing up the known issues in lustre before adding additional features, I've only been saying this for a few _years_ now... > Also, it will be useful for other users of LZ4 compression, > as with LZ4 fast it is possible to enable applications to use fast and/or high > compression depending of the usecase. E.g. a developer can use very > high compression (low acceleration) for sending data over a network with > limited rate of transmission or he trades the compression ratio for higher > compression speed. This whole patch series is broken, always test-build your code, there's nothing we could do with these patches even if we wanted to :( greg k-h