From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030226AbcLVTLo (ORCPT ); Thu, 22 Dec 2016 14:11:44 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:42813 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965677AbcLVTLm (ORCPT ); Thu, 22 Dec 2016 14:11:42 -0500 Date: Thu, 22 Dec 2016 20:11:04 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: "M'boumba Cedric Madianga" Cc: wsa@the-dreams.de, robh+dt@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linus.walleij@linaro.org, patrice.chotard@st.com, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC Message-ID: <20161222191103.vzmfhnrtrzw2ivwa@pengutronix.de> References: <1482413704-17531-1-git-send-email-cedric.madianga@gmail.com> <1482413704-17531-4-git-send-email-cedric.madianga@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1482413704-17531-4-git-send-email-cedric.madianga@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Dec 22, 2016 at 02:35:02PM +0100, M'boumba Cedric Madianga wrote: > @@ -337,6 +350,16 @@ > slew-rate = <2>; > }; > }; > + > + i2c1_pins_b: i2c1@0 { > + pins1 { > + pinmux = ; > + drive-open-drain; > + }; > + pins2 { > + pinmux = ; > + }; the second doesn't need the open-drain property? Why? > + }; > }; Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Thu, 22 Dec 2016 20:11:04 +0100 Subject: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC In-Reply-To: <1482413704-17531-4-git-send-email-cedric.madianga@gmail.com> References: <1482413704-17531-1-git-send-email-cedric.madianga@gmail.com> <1482413704-17531-4-git-send-email-cedric.madianga@gmail.com> Message-ID: <20161222191103.vzmfhnrtrzw2ivwa@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Thu, Dec 22, 2016 at 02:35:02PM +0100, M'boumba Cedric Madianga wrote: > @@ -337,6 +350,16 @@ > slew-rate = <2>; > }; > }; > + > + i2c1_pins_b: i2c1 at 0 { > + pins1 { > + pinmux = ; > + drive-open-drain; > + }; > + pins2 { > + pinmux = ; > + }; the second doesn't need the open-drain property? Why? > + }; > }; Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |