From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754574AbcLWHvb (ORCPT ); Fri, 23 Dec 2016 02:51:31 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:50573 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751502AbcLWHva (ORCPT ); Fri, 23 Dec 2016 02:51:30 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Fri, 23 Dec 2016 07:51:21 +0000 From: Chris Wilson To: changbin.du@intel.com Cc: daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty before using its content Message-ID: <20161223075121.GB14877@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , changbin.du@intel.com, daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20161223054636.3924-1-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161223054636.3924-1-changbin.du@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2016 at 01:46:36PM +0800, changbin.du@intel.com wrote: > From: "Du, Changbin" > > This patch fix a crash in function reset_common_ring. In this case, > the port[0].request is null when reset the render ring, so a null > dereference exception is raised. We need to check execlist_port status > first. No. The root cause is whatever got you into the illegal condition in the first place. -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty before using its content Date: Fri, 23 Dec 2016 07:51:21 +0000 Message-ID: <20161223075121.GB14877@nuc-i3427.alporthouse.com> References: <20161223054636.3924-1-changbin.du@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161223054636.3924-1-changbin.du@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: changbin.du@intel.com Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBEZWMgMjMsIDIwMTYgYXQgMDE6NDY6MzZQTSArMDgwMCwgY2hhbmdiaW4uZHVAaW50 ZWwuY29tIHdyb3RlOgo+IEZyb206ICJEdSwgQ2hhbmdiaW4iIDxjaGFuZ2Jpbi5kdUBpbnRlbC5j b20+Cj4gCj4gVGhpcyBwYXRjaCBmaXggYSBjcmFzaCBpbiBmdW5jdGlvbiByZXNldF9jb21tb25f cmluZy4gSW4gdGhpcyBjYXNlLAo+IHRoZSBwb3J0WzBdLnJlcXVlc3QgaXMgbnVsbCB3aGVuIHJl c2V0IHRoZSByZW5kZXIgcmluZywgc28gYSBudWxsCj4gZGVyZWZlcmVuY2UgZXhjZXB0aW9uIGlz IHJhaXNlZC4gV2UgbmVlZCB0byBjaGVjayBleGVjbGlzdF9wb3J0IHN0YXR1cwo+IGZpcnN0LgoK Tm8uIFRoZSByb290IGNhdXNlIGlzIHdoYXRldmVyIGdvdCB5b3UgaW50byB0aGUgaWxsZWdhbCBj b25kaXRpb24gaW4gdGhlCmZpcnN0IHBsYWNlLgotQ2hyaXMKCi0tIApDaHJpcyBXaWxzb24sIElu dGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudHJlCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=