From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 07/14] drm/i915: Start moving the cdclk stuff into a distinct state structure Date: Fri, 23 Dec 2016 14:27:52 +0200 Message-ID: <20161223122752.GR31595@intel.com> References: <20161219172840.31842-1-ville.syrjala@linux.intel.com> <20161219172840.31842-8-ville.syrjala@linux.intel.com> <1482416080.4759.61.camel@gmail.com> <20161222143348.GO31595@intel.com> <1482484162.2633.20.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5735B6E03A for ; Fri, 23 Dec 2016 12:27:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1482484162.2633.20.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMjMsIDIwMTYgYXQgMTE6MDk6MjJBTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IERlIE9saXZlaXJhIHdyb3RlOgo+IE9uIFRodSwgMjAxNi0xMi0yMiBhdCAxNjozMyArMDIwMCwg VmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gT24gVGh1LCBEZWMgMjIsIDIwMTYgYXQgMDQ6MTQ6 NDBQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFuIERlIE9saXZlaXJhIHdyb3RlOgo+ID4gPiAKPiA+ ID4gT24gTW9uLCAyMDE2LTEyLTE5IGF0IDE5OjI4ICswMjAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbSB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+IAo+ID4gPiA+IEludHJvZHVj ZSBpbnRlbF9jZGNsayBzdGF0ZSB3aGljaCBmb3Igbm93IHdpbGwgdHJhY2sgdGhlIGNkY2xrCj4g PiA+ID4gZnJlcXVlbmN5LCB0aGUgdmNvIGZyZXF1ZW5jeSBhbmQgdGhlIHJlZmVyZW5jZSBmcmVx dWVuY3kgKG5vdCBzdXJlIHdlCj4gPiA+ID4gd2FudCB0aGUgbGFzdCBvbmUsIGJ1dCBJIHB1dCBp dCB0aGVyZSBhbnl3YXkpLiBXZSdsbCBhbHNvIG1ha2UgdGhlCj4gPiA+ID4gLmdldF9jZGNsaygp IGZ1bmN0aW9uIGZpbGwgb3V0IHRoaXMgc3RhdGUgc3RydWN0dXJlIHJhdGhlciB0aGFuCj4gPiA+ ID4ganVzdCByZXR1cm5pbmcgdGhlIGN1cnJlbnQgY2RjbGsgZnJlcXVlbmN5Lgo+ID4gPiA+IAo+ ID4gPiA+IE9uZSBpbW1lZGlhdGUgYmVuZWZpdCBpcyB0aGF0IGNhbGxpbmcgLmdldF9jZGNsaygp IHdpbGwgbm8gbG9uZ2VyCj4gPiA+ID4gY2xvYmJlciBzdGF0ZSBzdG9yZWQgdW5kZXIgZGV2X3By aXYgdW5sZXNzIGV4W3BsaWNpdGx5IHRvbGQgdG8gZG8KPiA+ID4gVHlwbzogZXhbcGxpY2l0eQo+ ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBzby4gUHJldmlvdXNseSBpdCBjbG9iYmVyZWQgdGhlIHZj byBhbmQgcmVmZXJlbmNlIGNsb2NrcyBzdG9yZWQKPiA+ID4gPiB0aGVyZSBvbiBzb21lIHBsYXRm b3Jtcy4KPiA+ID4gPiAKPiA+ID4gPiBXZSdsbCBleHBhbmQgdGhlIHVzZSBvZiB0aGlzIHN0cnVj dHVyZSB0byBhY3R1YWxseSBwcmVjb21wdXRpbmcgdGhlCj4gPiA+ID4gc3RhdGUgYW5kIHdoYXRu b3QgbGF0ZXIuCj4gPiA+ID4gCj4gPiA+ID4gdjI6IENvbnN0aWZ5IGludGVsX2NkY2xrX3N0YXRl X2NvbXBhcmUoKQo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IEEgY291cGxlIG1vcmUgY29t bWVudHMgYmVsb2V3LCBidXQgZWl0aGVyIHdheSwKPiA+ID4gCj4gPiA+IFJldmlld2VkLWJ5OiBB bmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGNvbnNlbHZhbjJAZ21haWwuY29tPgo+ID4gPiAK PiA+ID4gPiAKPiA+ID4gPiAtLS0KPiA+ID4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZGVidWdmcy5jwqDCoMKgwqDCoHzCoMKgwqAyICstCj4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5owqDCoMKgwqDCoMKgwqDCoMKgfMKgwqAxNCArLQo+ID4gPiA+IMKgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uY8KgwqDCoMKgwqDCoHzCoMKgwqAyICstCj4g PiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jwqDCoMKgwqDCoMKgfCAz NTkgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA+ID4gPiDCoGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuY8KgwqDCoMKgfMKgwqAxOCArLQo+ID4gPiA+IMKgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuY8KgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqAyICst Cj4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaMKgwqDCoMKgwqDCoMKg wqB8wqDCoMKgMyArCj4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuY8Kg wqDCoMKgwqDCoMKgwqB8wqDCoMKgMiArLQo+ID4gPiA+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcGFuZWwuY8KgwqDCoMKgwqDCoHzCoMKgwqA0ICstCj4gPiA+ID4gwqBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfMKgwqDCoDUgKy0KPiA+ID4gPiDCoDEwIGZp bGVzIGNoYW5nZWQsIDI0MCBpbnNlcnRpb25zKCspLCAxNzEgZGVsZXRpb25zKC0pCj4gPiA+ID4g Cj4gCj4gWy4uLl0KPiAKPiBAQCAtNjI5LDEyICs2NjgsMTMgQEAgc3RhdGljIGludCBza2xfY2Fs Y19jZGNsayhpbnQgbWF4X3BpeGNsaywgaW50IHZjbykKPiA+ID4gPiDCoH0KPiA+ID4gPiDCoAo+ ID4gPiA+IC1zdGF0aWMgdm9pZCBza2xfZHBsbDBfdXBkYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiA+ID4gPiArc3RhdGljIHZvaWQgc2tsX2RwbGwwX3VwZGF0ZShzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ID4gKwkJCcKgwqDCoMKgwqBzdHJ1 Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xrX3N0YXRlKQo+ID4gPiA+IMKgewo+ID4gPiA+IMKg CXUzMiB2YWw7Cj4gPiA+ID4gwqAKPiA+ID4gPiAtCWRldl9wcml2LT5jZGNsa19wbGwucmVmID0g MjQwMDA7Cj4gPiA+ID4gLQlkZXZfcHJpdi0+Y2RjbGtfcGxsLnZjbyA9IDA7Cj4gPiA+ID4gKwlj ZGNsa19zdGF0ZS0+cmVmID0gMjQwMDA7Cj4gPiA+ID4gKwljZGNsa19zdGF0ZS0+dmNvID0gMDsK PiA+ID4gPiDCoAo+ID4gPiA+IMKgCXZhbCA9IEk5MTVfUkVBRChMQ1BMTDFfQ1RMKTsKPiA+ID4g PiDCoAlpZiAoKHZhbCAmIExDUExMX1BMTF9FTkFCTEUpID09IDApCj4gPiA+ID4gQEAgLTY1Niwx MSArNjk2LDExIEBAIHN0YXRpYyB2b2lkIHNrbF9kcGxsMF91cGRhdGUoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+IMKgCWNhc2UgRFBMTF9DVFJMMV9MSU5LX1JBVEUo RFBMTF9DVFJMMV9MSU5LX1JBVEVfMTM1MCwgU0tMX0RQTEwwKToKPiA+ID4gPiDCoAljYXNlIERQ TExfQ1RSTDFfTElOS19SQVRFKERQTExfQ1RSTDFfTElOS19SQVRFXzE2MjAsIFNLTF9EUExMMCk6 Cj4gPiA+ID4gwqAJY2FzZSBEUExMX0NUUkwxX0xJTktfUkFURShEUExMX0NUUkwxX0xJTktfUkFU RV8yNzAwLCBTS0xfRFBMTDApOgo+ID4gPiA+IC0JCWRldl9wcml2LT5jZGNsa19wbGwudmNvID0g ODEwMDAwMDsKPiA+ID4gPiArCQljZGNsa19zdGF0ZS0+dmNvID0gODEwMDAwMDsKPiA+ID4gPiDC oAkJYnJlYWs7Cj4gPiA+ID4gwqAJY2FzZSBEUExMX0NUUkwxX0xJTktfUkFURShEUExMX0NUUkwx X0xJTktfUkFURV8xMDgwLCBTS0xfRFBMTDApOgo+ID4gPiA+IMKgCWNhc2UgRFBMTF9DVFJMMV9M SU5LX1JBVEUoRFBMTF9DVFJMMV9MSU5LX1JBVEVfMjE2MCwgU0tMX0RQTEwwKToKPiA+ID4gPiAt CQlkZXZfcHJpdi0+Y2RjbGtfcGxsLnZjbyA9IDg2NDAwMDA7Cj4gPiA+ID4gKwkJY2RjbGtfc3Rh dGUtPnZjbyA9IDg2NDAwMDA7Cj4gPiA+ID4gwqAJCWJyZWFrOwo+ID4gPiA+IMKgCWRlZmF1bHQ6 Cj4gPiA+ID4gwqAJCU1JU1NJTkdfQ0FTRSh2YWwgJiBEUExMX0NUUkwxX0xJTktfUkFURV9NQVNL KFNLTF9EUExMMCkpOwo+ID4gPiBUaGlzIGZ1bmN0aW9uIGlzIGEgYml0IGZ1bm55IG5vdywgc2lu Y2UgaXQgc2V0cyB1cCB0aGUgY2RjbGsgc3RhdGUgYmFzZWQgb24KPiA+ID4gY3VycmVudCBwbGww IHByb2dyYW1taW5nLCBpbnN0ZWFkIG9mIGxvb2tpbmcgYXQgYW4gYXRvbWljIHN0YXRlLgo+ID4g V2Ugc2hvdWxkIHByb2JhYmx5IHJlbmFtZSBpdCB0byBzb21laHRpbmcgbW9yZSBkZXNjcmlwdGl2 ZS4gc2tsX2dldF9kcGxsMCgpCj4gPiBtYXliZS4gT3IgbWF5YmUgc2tsX2RwbGwwX2dldF9jb25m aWcgdG8gbWF0Y2ggdGhlIC5nZXRfY29uZmlnKCkKPiA+IG5vbWVuY2xhdHVyZSB1c2VkIGZvciBl Zy4gZW5jb2RlcnMuCj4gCj4gSG1tLCBJIHRoaW5rIHRoZSBwcm9ibGVtIGlzIHRoYXQgdGhpcyBo YXZlIGEgbWl4IG9mIGdldF9od19zdGF0ZSgpIGFuZAo+IGdldF9jb25maWcoKS4gV2UgYWN0dWFs bHkgaGF2ZSBza2xfZGRpX2RwbGwwX2dldF9od19zdGF0ZSgpLCBidXQgaXQgd291bGRuJ3QgYmUK PiB0cml2aWFsIHRvIG1ha2UgdGhhdCBjb2RlIHJldXNhYmxlIGZvciB0aGUgY2RjbGsgc3R1ZmYu Cj4gCj4gTWF5YmUgaXQgc2hvdWxkIGJlIHR3byBzZXBhcmF0ZSBmdW5jdGlvbnMsIG9uZSB0aGF0 IGdldHMgdGhlIGhhcmR3YXJlIHN0YXRlIGFuZAo+IGFub3RoZXIgZm9yIGNob29zaW5nIHRoZSB2 Y28uCgpUaGlzIGZ1bmN0aW9uIG9ubHkgZXhpc3RzIHRvIHJlYWQgdGhlIGh3IHN0YXRlLgoKPiBU aGVuCj4gCj4gwqAgdmNvID0gc2tsX2NkY2xrX3Zjbyhza2xfZHBsbDBfZ2V0X2h3X3N0YXRlKCkp Owo+IAo+IGRpcmVjdGx5IGluIHNrbF9nZXRfY2RjbGsoKSA/IEknbSBub3QgcmVhbGx5IHN1cmUs IG1heWJlIGp1c3QgbGVhdmUgdGhlIHdheSBpdAo+IGlzIGZvciBub3cuCj4gCj4gPiAgVGhvdWdo IGlmIHdlIGdvIHRoZXJlIHRoZW4KPiA+IC5nZXRfY2RjbGsoKSBtaWdodCBuZWVkIHRvIGJlIHJl bmFtZWQgdG8gLmNkY2xrX2dldF9jb25maWcgb3Igc29tZXRoaW5nLgo+IAo+IC5jZGNsa19nZXRf aHdfc3RhdGUoKSA/CgouZ2V0X2h3X3N0YXRlKCkgaXMgdGhlIHRoaW5nIHdoaWNoIHRlbGxzIHVz IGlmIHNvbWV0aGluZyBpcyBlbmFibGVkLAouZ2V0X2NvbmZpZygpIGlzIHRoZSB0aGluZyB0aGF0 IGFjdHVhbGx5IHJlYWRzIG91dCB0aGUgZnVsbCBzdGF0ZS4gT3IgYXQKbGVhc3QgdGhhdCdzIGhv dyBpdCB1c2VkIHRvIGJlLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==