All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
	seraphin.bonnaffe@st.com, f.fainelli@gmail.com,
	Alexandre TORGUE <alexandre.torgue@gmail.com>,
	Joachim Eastwood <manabian@gmail.com>,
	Niklas Cassel <niklas.cassel@axis.com>,
	Johan Hovold <johan@kernel.org>,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	weifeng.voon@intel.com, lars.persson@axis.com,
	Netdev list <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe
Date: Tue, 27 Dec 2016 11:48:26 +0100	[thread overview]
Message-ID: <20161227104826.GB15452@amd> (raw)
In-Reply-To: <1482849756-21817-1-git-send-email-hock.leong.kweh@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2190 bytes --]

On Tue 2016-12-27 22:42:36, Kweh, Hock Leong wrote:
> From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> 
> If kernel module stmmac driver being loaded after OS booted, there is a
> race condition between stmmac_open() and stmmac_mdio_register(), which is
> invoked inside stmmac_dvr_probe(), and the error is showed in dmesg log as
> PHY not found and stmmac_open() failed:
> [  473.919358] stmmaceth 0000:01:00.0 (unnamed net_device) (uninitialized):
>                 stmmac_dvr_probe: warning: cannot get CSR clock
> [  473.919382] stmmaceth 0000:01:00.0: no reset control found
> [  473.919412] stmmac - user ID: 0x10, Synopsys ID: 0x42
> [  473.919429] stmmaceth 0000:01:00.0: DMA HW capability register supported
> [  473.919436] stmmaceth 0000:01:00.0: RX Checksum Offload Engine supported
> [  473.919443] stmmaceth 0000:01:00.0: TX Checksum insertion supported
> [  473.919451] stmmaceth 0000:01:00.0 (unnamed net_device) (uninitialized):
>                 Enable RX Mitigation via HW Watchdog Timer
> [  473.921395] libphy: PHY stmmac-1:00 not found
> [  473.921417] stmmaceth 0000:01:00.0 eth0: Could not attach to PHY
> [  473.921427] stmmaceth 0000:01:00.0 eth0: stmmac_open: Cannot attach to
>                 PHY (error: -19)
> [  473.959710] libphy: stmmac: probed
> [  473.959724] stmmaceth 0000:01:00.0 eth0: PHY ID 01410cc2 at 0 IRQ POLL
>                 (stmmac-1:00) active
> [  473.959728] stmmaceth 0000:01:00.0 eth0: PHY ID 01410cc2 at 1 IRQ POLL
>                 (stmmac-1:01)
> [  473.959731] stmmaceth 0000:01:00.0 eth0: PHY ID 01410cc2 at 2 IRQ POLL
>                 (stmmac-1:02)
> [  473.959734] stmmaceth 0000:01:00.0 eth0: PHY ID 01410cc2 at 3 IRQ POLL
>                 (stmmac-1:03)
> 
> The resolution moved the register_netdev() function call to the end of
> stmmac_dvr_probe() after stmmac_mdio_register().
> 
> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2016-12-27 10:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27 14:42 [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Kweh, Hock Leong
2016-12-27 10:48 ` Pavel Machek [this message]
2016-12-27 16:34 ` David Miller
2016-12-28  1:40   ` Kweh, Hock Leong
2016-12-28  2:23     ` [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and stmmac_open Florian Fainelli
2016-12-28  2:32       ` David Miller
2016-12-28 11:56     ` [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Kishan Sandeep
2016-12-29  0:26       ` Kweh, Hock Leong
2016-12-28  5:49   ` Kweh, Hock Leong
2016-12-28 18:42     ` Florian Fainelli
2016-12-29  0:28       ` Kweh, Hock Leong
2016-12-29  0:40         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161227104826.GB15452@amd \
    --to=pavel@ucw.cz \
    --cc=Joao.Pinto@synopsys.com \
    --cc=alexandre.torgue@gmail.com \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hock.leong.kweh@intel.com \
    --cc=johan@kernel.org \
    --cc=lars.persson@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manabian@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.cassel@axis.com \
    --cc=peppe.cavallaro@st.com \
    --cc=seraphin.bonnaffe@st.com \
    --cc=weifeng.voon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.