From: Borislav Petkov <bp@alien8.de>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Fix Intel microcode revision detection
Date: Wed, 28 Dec 2016 12:18:30 +0100 [thread overview]
Message-ID: <20161228111830.GA21788@nazgul.tnic> (raw)
In-Reply-To: <2f771739-a617-0870-2f68-2a8ebba0bc46@ce.jp.nec.com>
On Wed, Dec 28, 2016 at 04:39:31AM +0000, Junichi Nomura wrote:
> early_init_intel() calls sync_core() before rdmsr(MSR_IA32_UCODE_REV),
> assuming sync_core() is effectively CPUID(eax=1). However the assumption
> no longer holds since commit c198b121b1a1 ("x86/asm: Rewrite sync_core()
> to use IRET-to-self").
>
> As a result, kernel fails to detect the revision of microcode, such as:
> microcode: sig=0x206a7, pf=0x2, revision=0x0
>
> Conversion from sync_core() to native_cpuid() has already been done in
> Intel microcode driver by commit 484d0e5c7943 ("x86/microcode/intel:
> Replace sync_core() with native_cpuid()"). This patch just extends the
> conversion for early_init_intel().
Good catch, thanks!
However, I want to do something else because we do end up needing those
native CPUID variants pretty often after all so let's generalize the
whole usage case and do the following (patches as reply to this message).
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2016-12-28 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 4:39 [PATCH] x86: Fix Intel microcode revision detection Junichi Nomura
2016-12-28 11:18 ` Borislav Petkov [this message]
2016-12-28 11:20 ` [PATCH 1/2] x86/CPU: Add native CPUID variants returning a single datum Borislav Petkov
2016-12-28 18:11 ` Andy Lutomirski
2016-12-29 9:30 ` Borislav Petkov
2016-12-31 2:13 ` Andy Lutomirski
2016-12-31 11:09 ` Borislav Petkov
2017-01-03 18:35 ` Andy Lutomirski
2017-01-03 19:48 ` Borislav Petkov
2016-12-28 11:21 ` [PATCH 2/2] x86/microcode: Use native CPUID to tickle out microcode revision Borislav Petkov
2016-12-28 12:53 ` [PATCH 3/2] x86/microcode/intel: Add a helper which gives the " Borislav Petkov
2016-12-28 18:12 ` Andy Lutomirski
2016-12-29 9:36 ` Borislav Petkov
2016-12-28 19:26 ` Boris Ostrovsky
2016-12-29 9:38 ` Borislav Petkov
[not found] ` <0a84dd78-809f-c1ef-6adc-551a124170ad@ce.jp.nec.com>
2017-01-05 9:39 ` [PATCH] x86: Fix Intel microcode revision detection Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228111830.GA21788@nazgul.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.