All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Ronco <c.ronco@kerlink.fr>
To: ofono@ofono.org
Subject: [PATCH 1/4] MC7430: use qmimodem sim driver
Date: Wed, 28 Dec 2016 16:03:59 +0100	[thread overview]
Message-ID: <20161228150402.15660-2-c.ronco@kerlink.fr> (raw)
In-Reply-To: <20161228150402.15660-1-c.ronco@kerlink.fr>

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

QMI modem sim-legacy driver uses a command not supported by MC7430 (QMI_DMS_GET_PIN_STATUS)

plugins/udevng.c
 QMI Sierra modems use sim driver.
drivers/qmimodem/sim.c
 In get_card_status_cb, call ofono_sim_register after ofono_sim_inserted_notify (as it is done in sim_legacy).
 Otherwise process crash (sim->driver->query_facility_lock called and not defined in this driver) with  MC7430 modem using this driver.
---
 drivers/qmimodem/sim.c | 3 +--
 plugins/udevng.c       | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/qmimodem/sim.c b/drivers/qmimodem/sim.c
index 197da509..fa7bef58 100644
--- a/drivers/qmimodem/sim.c
+++ b/drivers/qmimodem/sim.c
@@ -403,8 +403,6 @@ static void get_card_status_cb(struct qmi_result *result, void *user_data)
 	}
 
 done:
-	ofono_sim_register(sim);
-
 	switch (data->card_state) {
 	case 0x00:	/* Absent */
 	case 0x02:	/* Error */
@@ -413,6 +411,7 @@ done:
 		ofono_sim_inserted_notify(sim, TRUE);
 		break;
 	}
+	ofono_sim_register(sim);
 }
 
 static void event_registration_cb(struct qmi_result *result, void *user_data)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index 933bf4fa..a2866b64 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -252,8 +252,6 @@ static gboolean setup_sierra(struct modem_info *modem)
 
 	if (qmi != NULL && net != NULL) {
 		ofono_modem_set_driver(modem->modem, "gobi");
-		/* Fixup SIM interface for Sierra QMI devices */
-		ofono_modem_set_boolean(modem->modem, "ForceSimLegacy", TRUE);
 		goto done;
 	}
 
-- 
2.11.0


  reply	other threads:[~2016-12-28 15:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28 15:03 [PATCH 0/4] support MC7430 Sierra modem Christophe Ronco
2016-12-28 15:03 ` Christophe Ronco [this message]
2017-01-03 16:43   ` [PATCH 1/4] MC7430: use qmimodem sim driver Denis Kenzior
2016-12-28 15:04 ` [PATCH 2/4] MC7430: add read_imsi feature to " Christophe Ronco
2016-12-31  0:34   ` Denis Kenzior
2017-01-06  8:16     ` Christophe Ronco
2017-01-06 16:50       ` Denis Kenzior
2017-01-09  8:34         ` [PATCH 0/2] Fix Read Imsi feature for MC7430 modem Christophe Ronco
2017-01-09  8:34           ` [PATCH 1/2] sim: backup driver read_imsi by IMSI via EF read Christophe Ronco
2017-01-09  8:34           ` [PATCH 2/2] qmimodem: Add read_imsi to qmimodem sim driver Christophe Ronco
2017-01-09 18:32           ` [PATCH 0/2] Fix Read Imsi feature for MC7430 modem Denis Kenzior
2016-12-28 15:04 ` [PATCH 3/4] MC7430: fix get signal strength Christophe Ronco
2016-12-31  0:36   ` Denis Kenzior
2016-12-28 15:04 ` [PATCH 4/4] MC7430: fix QMI notification messages handling Christophe Ronco
2016-12-31  0:39   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161228150402.15660-2-c.ronco@kerlink.fr \
    --to=c.ronco@kerlink.fr \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.