From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcL1UdP (ORCPT ); Wed, 28 Dec 2016 15:33:15 -0500 Received: from mail-he1eur01hn0234.outbound.protection.outlook.com ([104.47.0.234]:50324 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751928AbcL1UdL (ORCPT ); Wed, 28 Dec 2016 15:33:11 -0500 X-Greylist: delayed 7344 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Dec 2016 15:33:10 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rkagan@virtuozzo.com; Date: Wed, 28 Dec 2016 19:57:00 +0300 From: Roman Kagan To: KY Srinivasan CC: Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , Haiyang Zhang , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "Denis V . Lunev" Subject: Re: [PATCH 00/15] hyperv: more stuff to uapi + cleanup Message-ID: <20161228165700.GA14702@rkaganb.sw.ru> Mail-Followup-To: Roman Kagan , KY Srinivasan , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , Haiyang Zhang , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "Denis V . Lunev" References: <20161220155602.6298-1-rkagan@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: DB6P191CA0010.EURP191.PROD.OUTLOOK.COM (10.175.236.148) To DB6PR0802MB2470.eurprd08.prod.outlook.com (10.172.251.18) X-MS-Office365-Filtering-Correlation-Id: 83077a9e-60a8-49c0-ae96-08d42f428f37 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0802MB2470; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2470;3:D3E7S2xu10JWFXQrxmkQDhNe7tU4M9ZYQfyRWRs8+F+iQvW+DfIPdJTxj0hXjANOoXqO7BZr1OplnHn1glBGZDZ2omBDWJiBVenNCxUAQtimFsX/xbh0H9qmWlK1p6GPhxE3xbKD7fHhXC9wk+1p53MjZJeyl37AU0FBqvQazx8GsPEXs5Zae64L3Hjmv0+vIccMcE7HKfCfcd9HXWhBjsFuCqpGJ+oAvMcLoIvU8iUiPTuKeSFAzkPo4KTmCQcIbLpQnTcUiXCB8njNnQVx9Q== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2470;25:SLP6ljcmzJSyzz4b0sLA4SJW/MFI7uZT+H1Fm+W1SOZ9fJfB9YuUK1uoSa/j1f/RPdBb2w5X3EKoE3PV1C7t1oAmKQ9lQamTFy9pt7JiAcSJ+pEEAXD8l2760UrB1qPY8ArnlNc+4+9xEk6WpT/mrED/vsoy5HwTKogAtKPgQEc/BWLz0nOkIOb8QNOVaNjmQP4+vdmB5VtT2viDzNqQeNge21hFWuGF0gHWLmfHl1lTravDbcHEmTbWuIWiABqzYsTRugNTRKcO3Nfd71P6qIqyX7P0mzONZhlLkS4ZT6PMxAUrnmRUNOLBbk/7cYYSQWIrJmtFV5XlHlal1ny7KIF9D0og5gun81MZt8O5k7e2z1MXMKZ+m8Mp18MSk2rAbc5L72zg1bZ6pCisU9DpXpT9/juV8rYZ2BZSIdEU+wGOokKq8fn05guplMkfnIdsbNBPA+kJDIk0r5Q2Ccr4o0Goriwsg4lm5cYn8vb203mbmyh5fnxhaoZwZMwGq/z6k/k0qyQIb77m/ciQiHfSYMxiL7rNnZubDVzcHrlPYCZleYam0Gxz3PzFWMAQEC7WJTV7mhwuD5Yaii/cyFebJlevKxbfbtbaEOFu5GIJbG1lshgWGc9bFRHYZqNOQ063ghV+VfJnixhODmKiakpeB2k6qIPTG2rSC1rxdPWFrHwYqAjXC002NuBGCV9dArwpCPAOnypAftH5FEHuEjuiuv1paplvjFkf9IfwBzfJD0FqKRKB9nTgEfvirkHZcS6g X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2470;31:LmDv4f39iE8N85WLeP3eRLWIZdgDKFu+T2yrsyKgOSmb1pJrHZE2shPbG/B7kH0JJmzLQ73BjXCplDBQnBo543Rmxn7JLmJ6u8UQkbL8EWM24WpPaV60O8pAb775uSBbObZuM+c+UKRHaQi9S7rctXWvzqBKKuvXOwpI7K/DZqbqTXYJA/GQplALz5fand2Vop/+Sg0+XoTuhEEoblQ++IuHXzQIAO0UqRapJCczrYVfpNpX0dj0myklv567R0Ln;20:THqQ7MC8nzbmuSSuc0wyQfKbkXWzeO0LHwEtcKXpvSQ6dZFXF0WizenHCg4mxqvR5yEbfz/gehg5MAFmtjVJm6KQhZv5PAtkXpZU/faLqNDQSr5Bf9ZauUHomef/f34RqgN7mAGwzsMUuMSIu5M/nKEqOYOMud898VmvxR5TFZeh6xQhZNyQ3zxWdKvzC2r1cqDirltkevO30sQAIsPktuzxw1o2B+KUFiMI6ElbehRPHmXDBjMiWDn45c+CDFv3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123558021)(20161123564025)(20161123562025)(6072148);SRVR:DB6PR0802MB2470;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2470; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2470;4:ygPFj0wXoe3CE7NAffBeTR4X8zLGt0Eb6SvLEkARVIRPKwbps13lVGLUGg9XDWSkOMJTHSHy6vb66sEgaLwJG1rfPw6Nac4uX1/4luplx6q249CbeAF+jVH4VCY3ki696ROLmIBNaEV9knCfFfmXlzhVF4wSvGD6VmwEuzU5Yo0geijqx/nxY3MP6QOrHgaGLVqDTKrVHVDL8NLVBfz2KbqhNKFele8EKfqQY1zbtaA9W0Q14BUTNeqa38/N+CTVFXqLAvZw5NfX91xH4ShPO9G+FpsLbj/lrUfzu74+mOquulGqBQL+ndzA6C7sczcBHehEUL9mqNtsEXD6lqV2GpiKdeT2OTc8i2ARSqodcTwGMKzrW5taGvW0WHn2sAXuVZ41SxTQoIMGDSt71q5UCN9Fjo8YI5tat2L4UypSfF5wTKPVAlTKTAQ4LAS/xGTDj8bChjblhFtpQG/9cApVqcWu8oQ3ZiKCklQh3GtdUJZooIB2RFtVqIwsTLubu75oPncFme+co0Fpceyl15/0NvKiMVbWkQ4GREpUFenUyipvKF2zvf6k/ezsu4zueLi/r/MUZR8/yP16QLOh+GKnoA5d/UIP2IS3uW9y+9l1gHsyLl8rlgyE48MgUSM+cz57xJkWGejOALc3yTXxknq3DQ== X-Forefront-PRVS: 0170DAF08C X-Forefront-Antispam-Report: SFV:SPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39830400002)(39410400002)(39450400003)(199003)(377454003)(189002)(13464003)(24454002)(83506001)(6666003)(106356001)(23726003)(6116002)(105586002)(2950100002)(3846002)(2421001)(4001350100001)(229853002)(97736004)(6916009)(36756003)(54356999)(50986999)(1076002)(2906002)(4326007)(76176999)(7736002)(305945005)(4001430100002)(92566002)(2561002)(38730400001)(8666007)(1511001)(33656002)(46406003)(101416001)(9686002)(68736007)(7416002)(81156014)(8676002)(66066001)(81166006)(69596002)(50466002)(86362001)(107886002)(110136003)(25786008)(42186005)(97756001)(5660300001)(189998001)(6506006)(53416004)(47776003)(30126002)(18370500001);DIR:OUT;SFP:1501;SCL:5;SRVR:DB6PR0802MB2470;H:rkaganb.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0802MB2470;23:ES5BgbXxS0k3vm5ayG435s7ujhQFBxPWzjvq1LF?= =?us-ascii?Q?wK8pOa6jyFnTGznoCFviKcTeB7bWW8cIPFxNtQbL8Dgy770q3sLR94YKCP+A?= =?us-ascii?Q?6BBMV3IfTSAzgR5J485jgMTHoxERI9UAzgLxfG9b/Rl0ApgypODXIqowydiE?= =?us-ascii?Q?xfj+wIcQIplTpdh2xp5e3RhkOzyrjbjHBcaDFI88TPqO+/iObBPa3qhNPx+z?= =?us-ascii?Q?MZXyfDsvTc3ogmvbBzPcL3YGIepvUYanb07OUp8L5rSgzu3Jm/Z9/R+7Bfsg?= =?us-ascii?Q?Dua8dQnNK0BZo8adMtnyzcARux4rAyEA/amxE19PpwY2qf6c0ZhVYLlbpRZT?= =?us-ascii?Q?KaeOvDkKEscvfjNQ6u4kMwmEzsUUFfcmqNlICDSIcNA4j6dXaO1LnVsjCnVZ?= =?us-ascii?Q?6s7elQS9SW7OLI/0SAqHNbV+kcAf6fxNQkS9veTuO9OFvws21PtuZbGNhHLc?= =?us-ascii?Q?+dKoJ+iBS6holf6UxmnWQ7VWMmZUoZMLySCOoWZRIEQX7F5cWZFHFx4XkFN4?= =?us-ascii?Q?AG3G81FvewzxKIsvLMX1JugFGRWy2LBBI9E08G8fCyZHgCMiV21CWscqefc2?= =?us-ascii?Q?/jJFbxOYmyCbeOHaXQEGW9tmFPj9sIfQ6uoXlQ7A/QVSN4FwqRJKBSVbblLi?= =?us-ascii?Q?1URzH0ZomSoinm/dSH9pEzZjDjjFqR3++rfYiM9wr78i68DQ/eQ3k00JRx95?= =?us-ascii?Q?GgFEiadOR/fAVPPXJRnkTd4+K7bwUcuU1lDOJ/UlzWkKD12R6tI9EQPIc38y?= =?us-ascii?Q?BBhHb5w2m6VsW7VNNmoD6Vb7hNMgKSDQiPOnKmmfLCYbb2iRF5SvJLUqvnJF?= =?us-ascii?Q?8XeTwvh6uoHdRI3F4itICLsiZmmEgxB4Njx9WlLiZJuuUUn9BoxFguW8Aa/h?= =?us-ascii?Q?i0cJpnPae9z0TPHI578F9crRTCz4tHSFvIdloUI5b5i00+0/gbmiIFvTmEnF?= =?us-ascii?Q?8jeddEDfABxy+Wo4667mbwHAeitqLeNhtaacSbIEnyHcdLqBZPuj+f3hTQH2?= =?us-ascii?Q?xAY/gDv4zHNj0kpn954VW8SCQEqrNTxMtzY1+x6ps6S7XfgT+J5f1qDNXcfU?= =?us-ascii?Q?1RSe1Ba0gI4shBLHWhDW4k16YZREENTMnRgtHBQ3OMSCLaf74/VF78ZNzPts?= =?us-ascii?Q?DTLQXSpS7c//rfv9KcIK45dj6c2MqIk9x7CWUZQDP9XpWg4pE9gX+/rmJ7EY?= =?us-ascii?Q?tgGmZfhc/p2pCHwW7QpYedjUyNDllY0C7rqlr6ihEvhNAWknL7Dk1aOoXXU/?= =?us-ascii?Q?7AjMn6mmKElfnBFXt0cMFhGgFlsjgbANHqy7s5Jk2uUXw5JizMEJ/Qn6WmAN?= =?us-ascii?Q?V6Op/1LRTk3o2Ldr3VVnEdegy6IsMO9E0nSSOjYMm3YoiS5lk+kKjsqV7Lzl?= =?us-ascii?Q?ljGdZ+0v9YhA7aRL1TbE51+o5wUlngY2ENjJfDj7sSCxMmaD/QmB8BMuMw3u?= =?us-ascii?Q?YQhxcziAQW17QobQZrG7NbxbyUGgZjUPoGbrzUgITNCfroHW2mlriHr5rOZ6?= =?us-ascii?Q?YJ/+Ymo+GXRE+EtKjJgue90NTgs3txewsDstzHZpLgN4VMIWjFWKFLVHU6MK?= =?us-ascii?Q?0Dgs6aegdD0ERgMQiNg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2470;6:o3XLNLOe2m1QKT45/3qm45Ljb3O5yxidczKkvprDfJcJd4RLCMCa5oyg8OrmoLWskcy/WVi+eI8ImR7JS61nOy9/nvA1IS2u2IauGtsZ7cGb1blkVZccUju2uCzsYAHzFw72zwF3x4uuajqgWGdRiX8JgfJFfQIHMz/85hZtdS/rNzGA7GDwLinRHUOdrX38kIH/uIeiAmMOiB8HX83sI/qQhCSpQwsKZez3j4PhrOmI7rOOWjFAFCcNVzSNAreyxmYDREEBxLwTAp2XgTFNBwL2fG4FyEXFdLkjiGFP/FpsmPW9HtQqg5g7qx6XuBC2XbR/xDSYsG2OxWYA2vwP+oOX6CZbaJIMUXzwpWXHAGdss/IcrxNpUmYkRSS5GbKUBDwAQvBAwb0UwR1NIonf9G9tP9l+fgSnafjWLbPwj9w=;5:HdT8Q9xZLRonvObvtQLMEBSXVraluf+5GyKhFcK5OHRjRyV5S7rSG6fnKqS4bl5vSyOzTB+Mxb5l8th/9ffyZD8xodsHXR7hmmTQKghmsgcMkZ4AUzfn0FCy+hp1ISDfQHjL+Cpz0X2YxSwJiI3FEA==;24:ifAZ7XCbtSKeZbuo7xC1oK3TWdowYT1wxOklGyCwcVv/kwS7kkUmV6P2btu1FvCqk4snmi3EWn5v+uLmx1CZTA== SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2470;7:XdJ0hc09IQvxnIr7Pbu9Sl0sYj0S94p2FApDGaxhEx/cjEwvW4kSiiD00sZwNVD2/wUyqYXzAFtg509u/xZ/6/bSxhyxYn5LkLw2g6vauIYsU2DnQAWbBkWKuc4MmjUxZvpKVgb3vSuPxKegap6vP8gljBvpjORpB3E7HX30QcFF6KKkAyWI22dwIwcBZYtONvNuoNSlGwuctX/mIzSm3nrb7TO9jbMbgt2Ps80SX3PELXnmm8ZBllJzq9WeGriv5XDGI8zrLFMO4HaFjCdXHJUPPyPqauLbXVf1Z5atU1St52S0v7WZXRLXa+eJmrziGNmF3ZarolKIS8SYjt4s230q8Oyjr9tBKeCIrSJ3nIVPoHw/6ECY/D+Wz+RH9X0npv9H8uTwapZHGVGZPFVTkV+JtFhwWxW3Dk5vWWTuwJBngJiYy7NQmIDagcD/ajSpbNu2M8fleSIOmTl8y/51kA==;20:DroR5nxXbXaI5cil1rk4xsjsneuZlJkR/jL9k3XHy+zuowC3cOtBzPSKSIi5hpEEvbbR2fW99S8uWikVu4cKsDgbOwLj8FPycp1WWOsI+EuR9NYvqkleQ8fuMbKbFn91xToh/Pc3vBTTHr36fa9ageVBpobMArry1kSe6oC6+O0= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2016 16:57:07.4153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2470 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Sorry for such a slow reply; flu and office relocation knocked me out for a while ] On Wed, Dec 21, 2016 at 06:00:17PM +0000, KY Srinivasan wrote: > > -----Original Message----- > > From: Roman Kagan [mailto:rkagan@virtuozzo.com] > > Sent: Tuesday, December 20, 2016 7:56 AM > > Subject: [PATCH 00/15] hyperv: more stuff to uapi + cleanup > > > > Expose more Hyper-V-related definitions in the uapi header for > > consumption by userspace. > > > > While doing so, get rid of a number of duplications between the KVM and > > the guest driver code. Also a few other cleanups are made which are not > > strictly necessary for the main purpose of the series but appear > > reasonable to do at the same time. > > > > The most controversial is the last patch which modifies the stuff > > already published in the uapi header, in the hope that no userspace > > applications have started relying on it; I'm ok dropping it if this is > > unacceptable. > > First, let me thank you. Broadly, this patch-set can be broken into > 1. Moving existing definitions around - (to make it possible to share these > between Hyper-V guest drivers and KVM) > 2. Cleanup of the existing code in the VMBUS driver (under drivers/hv). Right. Another significant part of the series is, where two sets of definitions exist for the same entity, consolidate on the one that looks more Linux-style, usually the one in the (currently) uapi header. > To the extent possible, I want to take all non-KVM code through Greg's tree. > We can then modify the KVM code to use these common definitions. Well, this patchset touches almost no KVM code, so we're fine here I think. > Currently, I too am working on restructuring VMBUS driver code to > fully isolate all x86 dependencies. I can work with you on > integration as I too am moving things around. Great! Do you want me to rebase on some your public tree? (Once I split the patches as you requested, of course)? Thanks, Roman. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Kagan Subject: Re: [PATCH 00/15] hyperv: more stuff to uapi + cleanup Date: Wed, 28 Dec 2016 19:57:00 +0300 Message-ID: <20161228165700.GA14702@rkaganb.sw.ru> References: <20161220155602.6298-1-rkagan@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , Radim =?utf-8?B?S3LEjW3DocWZ?= , "Denis V . Lunev" , Haiyang Zhang , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , Thomas Gleixner To: KY Srinivasan Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: kvm.vger.kernel.org [ Sorry for such a slow reply; flu and office relocation knocked me out for a while ] On Wed, Dec 21, 2016 at 06:00:17PM +0000, KY Srinivasan wrote: > > -----Original Message----- > > From: Roman Kagan [mailto:rkagan@virtuozzo.com] > > Sent: Tuesday, December 20, 2016 7:56 AM > > Subject: [PATCH 00/15] hyperv: more stuff to uapi + cleanup > > > > Expose more Hyper-V-related definitions in the uapi header for > > consumption by userspace. > > > > While doing so, get rid of a number of duplications between the KVM and > > the guest driver code. Also a few other cleanups are made which are not > > strictly necessary for the main purpose of the series but appear > > reasonable to do at the same time. > > > > The most controversial is the last patch which modifies the stuff > > already published in the uapi header, in the hope that no userspace > > applications have started relying on it; I'm ok dropping it if this is > > unacceptable. > > First, let me thank you. Broadly, this patch-set can be broken into > 1. Moving existing definitions around - (to make it possible to share these > between Hyper-V guest drivers and KVM) > 2. Cleanup of the existing code in the VMBUS driver (under drivers/hv). Right. Another significant part of the series is, where two sets of definitions exist for the same entity, consolidate on the one that looks more Linux-style, usually the one in the (currently) uapi header. > To the extent possible, I want to take all non-KVM code through Greg's tree. > We can then modify the KVM code to use these common definitions. Well, this patchset touches almost no KVM code, so we're fine here I think. > Currently, I too am working on restructuring VMBUS driver code to > fully isolate all x86 dependencies. I can work with you on > integration as I too am moving things around. Great! Do you want me to rebase on some your public tree? (Once I split the patches as you requested, of course)? Thanks, Roman.