From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933288AbdACAas (ORCPT ); Mon, 2 Jan 2017 19:30:48 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:48810 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933023AbdACAaK (ORCPT ); Mon, 2 Jan 2017 19:30:10 -0500 Date: Mon, 02 Jan 2017 19:30:03 -0500 (EST) Message-Id: <20170102.193003.577100357837775083.davem@davemloft.net> To: wr0112358@gmail.com Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end From: David Miller In-Reply-To: <20170102233410.4070-1-wr0112358@gmail.com> References: <20170102233410.4070-1-wr0112358@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Jan 2017 15:30:55 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Reiter Wolfgang Date: Tue, 3 Jan 2017 00:34:10 +0100 > Final nlmsg_len field update must reflect inserted net_dm_drop_point > data. > > This patch depends on previous patch: > "drop_monitor: add missing call to genlmsg_end" > > Signed-off-by: Reiter Wolfgang Several coding style errors: > @@ -112,6 +111,12 @@ static struct sk_buff *reset_per_cpu_data(struct per_cpu_dm_data *data) > swap(data->skb, skb); > spin_unlock_irqrestore(&data->lock, flags); > > + if(skb) { There must be a space between "if" and "(skb)" > + struct nlmsghdr *nlh = (struct nlmsghdr *)skb->data; > + struct genlmsghdr *gnlh = (struct genlmsghdr *)nlmsg_data(nlh); > + genlmsg_end(skb, genlmsg_data(gnlh)); > + } There should be an empty line between the local variable declarations and actual code.