From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759495AbdACW3U (ORCPT ); Tue, 3 Jan 2017 17:29:20 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:43692 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbdACW3M (ORCPT ); Tue, 3 Jan 2017 17:29:12 -0500 Date: Tue, 3 Jan 2017 22:29:06 +0000 From: Al Viro To: Fabian Frederick Cc: Andrew Morton , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable Message-ID: <20170103222906.GC1555@ZenIV.linux.org.uk> References: <1483479039-5255-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483479039-5255-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 10:30:39PM +0100, Fabian Frederick wrote: > Add standard functions making AFFS work with NFS. > > Functions based on ext4 implementation. > Tested on loop device. How the hell is that supposed to work with cold dcache? You don't have ->get_parent() there at all... There *IS* a reference to parent directory in those suckers - not the same kind as in normal unix filesystems (".." is not a directory entry there - it's all fake), but it's doable. be32_to_cpu(AFFS_TAIL(sb, bh)->parent) would be the inumber you need, where bh is the inode block of directory. So it can be done, but not in this form. NAK for the time being...