From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f194.google.com ([209.85.210.194]:36754 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965382AbdADO63 (ORCPT ); Wed, 4 Jan 2017 09:58:29 -0500 Received: by mail-wj0-f194.google.com with SMTP id j10so75975610wjb.3 for ; Wed, 04 Jan 2017 06:58:28 -0800 (PST) Date: Wed, 4 Jan 2017 15:58:25 +0100 From: Daniel Vetter To: Laurent Pinchart Cc: Daniel Vetter , Laurent Pinchart , dri-devel , "open list:DRM DRIVERS FOR RENESAS" Subject: Re: [PATCH v3 06/13] drm: bridge: Add LVDS encoder driver Message-ID: <20170104145824.bnjdsv77bay75ie2@phenom.ffwll.local> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <5172242.1xI6ry2aS1@avalon> <2223998.87cnrdv6Vi@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2223998.87cnrdv6Vi@avalon> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Jan 04, 2017 at 04:33:57PM +0200, Laurent Pinchart wrote: > On Wednesday 04 Jan 2017 14:51:48 Daniel Vetter wrote: > > Hm, something like drm_bridge_panel_bridge_init(dev, panel) should be > > enough, or not? My idea is to use this for the case where the only > > thing in dt is the panel, with no real bridge chip. And I think we > > don't need anything beyond that one _init function, plus maybe some > > additional paramaters ... > > There should be no bridge then. If you want the DRM core to manage panels > automatically, then we should create specific helpers for that, not abuse the > bridge infrastructure. Bridges should be instantiated from a hardware device > and bound to drivers as usual. I guess that's the part where I disagree: Just because there's physically no bridge doesn't mean we shouldn't just treat it as one in the software abstraction. If it looks and acts like a bridge (even an empty one), then imo it can be a bridge. If you insist on panels being panels, then I guess we need some other kind of glue to bind them into arbitrary bridge chains. But given that the callbacks match very closely, I don't see the point. In an idea world a panel would probably derive from a drm_bridge, but we're not in that universe unfortunately ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 06/13] drm: bridge: Add LVDS encoder driver Date: Wed, 4 Jan 2017 15:58:25 +0100 Message-ID: <20170104145824.bnjdsv77bay75ie2@phenom.ffwll.local> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <5172242.1xI6ry2aS1@avalon> <2223998.87cnrdv6Vi@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wj0-x244.google.com (mail-wj0-x244.google.com [IPv6:2a00:1450:400c:c01::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFD4E6E275 for ; Wed, 4 Jan 2017 14:58:29 +0000 (UTC) Received: by mail-wj0-x244.google.com with SMTP id qs7so38215916wjc.1 for ; Wed, 04 Jan 2017 06:58:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <2223998.87cnrdv6Vi@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: "open list:DRM DRIVERS FOR RENESAS" , Laurent Pinchart , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMDQsIDIwMTcgYXQgMDQ6MzM6NTdQTSArMDIwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBPbiBXZWRuZXNkYXkgMDQgSmFuIDIwMTcgMTQ6NTE6NDggRGFuaWVsIFZldHRl ciB3cm90ZToKPiA+IEhtLCBzb21ldGhpbmcgbGlrZSBkcm1fYnJpZGdlX3BhbmVsX2JyaWRnZV9p bml0KGRldiwgcGFuZWwpIHNob3VsZCBiZQo+ID4gZW5vdWdoLCBvciBub3Q/IE15IGlkZWEgaXMg dG8gdXNlIHRoaXMgZm9yIHRoZSBjYXNlIHdoZXJlIHRoZSBvbmx5Cj4gPiB0aGluZyBpbiBkdCBp cyB0aGUgcGFuZWwsIHdpdGggbm8gcmVhbCBicmlkZ2UgY2hpcC4gQW5kIEkgdGhpbmsgd2UKPiA+ IGRvbid0IG5lZWQgYW55dGhpbmcgYmV5b25kIHRoYXQgb25lIF9pbml0IGZ1bmN0aW9uLCBwbHVz IG1heWJlIHNvbWUKPiA+IGFkZGl0aW9uYWwgcGFyYW1hdGVycyAuLi4KPiAKPiBUaGVyZSBzaG91 bGQgYmUgbm8gYnJpZGdlIHRoZW4uIElmIHlvdSB3YW50IHRoZSBEUk0gY29yZSB0byBtYW5hZ2Ug cGFuZWxzIAo+IGF1dG9tYXRpY2FsbHksIHRoZW4gd2Ugc2hvdWxkIGNyZWF0ZSBzcGVjaWZpYyBo ZWxwZXJzIGZvciB0aGF0LCBub3QgYWJ1c2UgdGhlIAo+IGJyaWRnZSBpbmZyYXN0cnVjdHVyZS4g QnJpZGdlcyBzaG91bGQgYmUgaW5zdGFudGlhdGVkIGZyb20gYSBoYXJkd2FyZSBkZXZpY2UgCj4g YW5kIGJvdW5kIHRvIGRyaXZlcnMgYXMgdXN1YWwuCgpJIGd1ZXNzIHRoYXQncyB0aGUgcGFydCB3 aGVyZSBJIGRpc2FncmVlOiBKdXN0IGJlY2F1c2UgdGhlcmUncyBwaHlzaWNhbGx5Cm5vIGJyaWRn ZSBkb2Vzbid0IG1lYW4gd2Ugc2hvdWxkbid0IGp1c3QgdHJlYXQgaXQgYXMgb25lIGluIHRoZSBz b2Z0d2FyZQphYnN0cmFjdGlvbi4gSWYgaXQgbG9va3MgYW5kIGFjdHMgbGlrZSBhIGJyaWRnZSAo ZXZlbiBhbiBlbXB0eSBvbmUpLCB0aGVuCmltbyBpdCBjYW4gYmUgYSBicmlkZ2UuCgpJZiB5b3Ug aW5zaXN0IG9uIHBhbmVscyBiZWluZyBwYW5lbHMsIHRoZW4gSSBndWVzcyB3ZSBuZWVkIHNvbWUg b3RoZXIga2luZApvZiBnbHVlIHRvIGJpbmQgdGhlbSBpbnRvIGFyYml0cmFyeSBicmlkZ2UgY2hh aW5zLiBCdXQgZ2l2ZW4gdGhhdCB0aGUKY2FsbGJhY2tzIG1hdGNoIHZlcnkgY2xvc2VseSwgSSBk b24ndCBzZWUgdGhlIHBvaW50LgoKSW4gYW4gaWRlYSB3b3JsZCBhIHBhbmVsIHdvdWxkIHByb2Jh Ymx5IGRlcml2ZSBmcm9tIGEgZHJtX2JyaWRnZSwgYnV0CndlJ3JlIG5vdCBpbiB0aGF0IHVuaXZl cnNlIHVuZm9ydHVuYXRlbHkgOy0pCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=