From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] dma-fence: Clear fence->status during dma_fence_init()
Date: Wed, 4 Jan 2017 16:10:28 +0100 [thread overview]
Message-ID: <20170104151028.prfhcr63x4roloen@phenom.ffwll.local> (raw)
In-Reply-To: <20170104141222.6992-1-chris@chris-wilson.co.uk>
On Wed, Jan 04, 2017 at 02:12:20PM +0000, Chris Wilson wrote:
> As the fence->status is an optional field that may be set before
> dma_fence_signal() is called to convey that the fence completed with an
> error, we have to ensure that it is always set to zero on initialisation
> so that the typical use (i.e. unset) always flags a successful completion.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Yeah, this looks all pretty. On the series:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'll defer to Gustavo for another pass over it and merging it to drm-misc.
-Daniel
> ---
> drivers/dma-buf/dma-fence.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 3444f293ad4a..9130f790ebf3 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -534,6 +534,7 @@ dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops,
> fence->context = context;
> fence->seqno = seqno;
> fence->flags = 0UL;
> + fence->status = 0;
>
> trace_dma_fence_init(fence);
> }
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-04 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 14:12 [PATCH 1/3] dma-fence: Clear fence->status during dma_fence_init() Chris Wilson
2017-01-04 14:12 ` [PATCH 2/3] dma-fence: Wrap querying the fence->status Chris Wilson
2017-01-04 14:12 ` [PATCH 3/3] dma-fence: Introduce drm_fence_set_error() helper Chris Wilson
2017-01-09 14:43 ` Sumit Semwal
2017-01-09 14:56 ` Chris Wilson
2017-01-04 15:10 ` Daniel Vetter [this message]
2017-01-04 15:53 ` [PATCH 1/3] dma-fence: Clear fence->status during dma_fence_init() Sumit Semwal
2017-01-06 14:32 ` Chris Wilson
2017-01-04 15:16 ` ✗ Fi.CI.BAT: warning for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104151028.prfhcr63x4roloen@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.