From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS Date: Thu, 5 Jan 2017 09:40:57 -0800 Message-ID: <20170105174056.GA1765@mail.bwidawsk.net> References: <20170104184232.23048-1-ville.syrjala@linux.intel.com> <20170104184232.23048-9-ville.syrjala@linux.intel.com> <8f9b7f16-5e98-4272-a19c-4b979be1f3b2@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <8f9b7f16-5e98-4272-a19c-4b979be1f3b2@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Kristian =?utf-8?B?SMO4Z3NiZXJn?= Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Vandana Kannan List-Id: dri-devel@lists.freedesktop.org T24gMTctMDEtMDUgMTY6MjQ6NTYsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj5PbiAwNC8wMS8y MDE3IDE4OjQyLCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPj5Gcm9tOiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Pgo+PlNLTCsg ZGlzcGxheSBlbmdpbmUgY2FuIHNjYW4gb3V0IGNlcnRhaW4ga2luZHMgb2YgY29tcHJlc3NlZCBz dXJmYWNlcwo+PnByb2R1Y2VkIGJ5IHRoZSByZW5kZXIgZW5naW5lLiBUaGlzIGludm9sdmVkIHRl bGxpbmcgdGhlIGRpc3BsYXkgZW5naW5lCj4+dGhlIGxvY2F0aW9uIG9mIHRoZSBjb2xvciBjb250 cm9sIHN1cmZhZSAoQ0NTKSB3aGljaCBkZXNjcmliZXMgd2hpY2gKPj5wYXJ0cyBvZiB0aGUgbWFp biBzdXJmYWNlIGFyZSBjb21wcmVzc2VkIGFuZCB3aGljaCBhcmUgbm90LiBUaGUgbG9jYXRpb24K Pj5vZiBDQ1MgaXMgcHJvdmlkZWQgYnkgdXNlcnNwYWNlIGFzIGp1c3QgYW5vdGhlciBwbGFuZSB3 aXRoIGl0cyBvd24gb2Zmc2V0Lgo+Pgo+PkJ5IHByb3ZpZGluZyBvdXIgb3duIGZvcm1hdCBpbmZv cm1hdGlvbiBmb3IgdGhlIENDUyBmb3JtYXRzLCB3ZSBzaG91bGQKPj5iZSBhYmxlIHRvIG1ha2Ug ZnJhbWVidWZmZXJfY2hlY2soKSBkbyB0aGUgcmlnaHQgdGhpbmcgZm9yIHRoZSBDQ1MKPj5zdXJm YWNlIGFzIHdlbGwuCj4+Cj4+Tm90ZSB0aGF0IHdlJ2xsIHJldHVybiB0aGUgc2FtZSBmb3JtYXQg aW5mbyBmb3IgYm90aCBZIGFuZCBZZiB0aWxlZAo+PmZvcm1hdCBhcyB0aGF0J3Mgd2hhdCBoYXBw ZW5zIHdpdGggdGhlIG5vbi1DQ1MgWSB2cy4gWWYgYXMgd2VsbC4gSWYKPj5kZXNpcmVkLCB3ZSBj b3VsZCBwb3RlbnRpYWxseSByZXR1cm4gYSB1bmlxdWUgcG9pbnRlciBmb3IgZWFjaAo+PnBpeGVs X2Zvcm1hdCt0aWxpbmcrY2NzIGNvbWJpbmF0aW9uLCBpbiB3aGljaCBjYXNlIHdlIGltbWVkaWF0 ZWx5IGJlCj4+YWJsZSB0byB0ZWxsIGlmIGFueSBvZiB0aGF0IHN0dWZmIGNoYW5nZWQgYnkganVz dCBjb21wYXJpbmcgdGhlCj4+cG9pbnRlcnMuIEJ1dCB0aGF0IGRvZXMgc291bmQgYSBiaXQgd2Fz dGVmdWwgc3BhY2Ugd2lzZS4KPj4KPj52MjogRHJvcCB0aGUgJ2RldicgYXJndW1lbnQgZnJvbSB0 aGUgaG9vawo+PnYzOiBJbmNsdWRlIHRoZSBkZXNjcmlwdGlvbiBvZiB0aGUgQ0NTIHN1cmZhY2Ug bGF5b3V0Cj4+Cj4+Q2M6IFZhbmRhbmEgS2FubmFuIDx2YW5kYW5hLmthbm5hbkBpbnRlbC5jb20+ Cj4+Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPj5DYzogQmVuIFdpZGF3c2t5 IDxiZW5AYndpZGF3c2submV0Pgo+PkNjOiBKYXNvbiBFa3N0cmFuZCA8amFzb25Aamxla3N0cmFu ZC5uZXQ+Cj4+UmV2aWV3ZWQtYnk6IEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5ldD4KPj5T aWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+Pi0tLQo+PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAzNiAr KysrKysrKysrKysrKysrKysrKysrKysrKwo+PiBpbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2Mu aCAgICAgICAgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4gMiBm aWxlcyBjaGFuZ2VkLCA4NSBpbnNlcnRpb25zKCspCj4+Cj4+ZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+PmluZGV4IGM0NjYyYjJlOTYxMy4uMzhkZTlkZjBlYzYwIDEwMDY0NAo+Pi0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PisrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PkBAIC0yNDc4LDYgKzI0NzgsNDEgQEAgc3Rh dGljIHVuc2lnbmVkIGludCBpbnRlbF9mYl9tb2RpZmllcl90b190aWxpbmcodWludDY0X3QgZmJf bW9kaWZpZXIpCj4+IAl9Cj4+IH0KPj4KPj4rc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0 X2luZm8gY2NzX2Zvcm1hdHNbXSA9IHsKPj4rCXsgLmZvcm1hdCA9IERSTV9GT1JNQVRfWFJHQjg4 ODgsIC5kZXB0aCA9IDI0LCAubnVtX3BsYW5lcyA9IDIsIC5jcHAgPSB7IDQsIDEsIH0sIC5oc3Vi ID0gMTYsIC52c3ViID0gOCwgfSwKPj4rCXsgLmZvcm1hdCA9IERSTV9GT1JNQVRfWEJHUjg4ODgs IC5kZXB0aCA9IDI0LCAubnVtX3BsYW5lcyA9IDIsIC5jcHAgPSB7IDQsIDEsIH0sIC5oc3ViID0g MTYsIC52c3ViID0gOCwgfSwKPj4rCXsgLmZvcm1hdCA9IERSTV9GT1JNQVRfQVJHQjg4ODgsIC5k ZXB0aCA9IDMyLCAubnVtX3BsYW5lcyA9IDIsIC5jcHAgPSB7IDQsIDEsIH0sIC5oc3ViID0gMTYs IC52c3ViID0gOCwgfSwKPj4rCXsgLmZvcm1hdCA9IERSTV9GT1JNQVRfQUJHUjg4ODgsIC5kZXB0 aCA9IDMyLCAubnVtX3BsYW5lcyA9IDIsIC5jcHAgPSB7IDQsIDEsIH0sIC5oc3ViID0gMTYsIC52 c3ViID0gOCwgfSwKPj4rfTsKPj4rCj4+K3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9p bmZvICoKPj4rbG9va3VwX2Zvcm1hdF9pbmZvKGNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8g Zm9ybWF0c1tdLAo+PisJCSAgIGludCBudW1fZm9ybWF0cywgdTMyIGZvcm1hdCkKPj4rewo+PisJ aW50IGk7Cj4+Kwo+PisJZm9yIChpID0gMDsgaSA8IG51bV9mb3JtYXRzOyBpKyspIHsKPj4rCQlp ZiAoZm9ybWF0c1tpXS5mb3JtYXQgPT0gZm9ybWF0KQo+PisJCQlyZXR1cm4gJmZvcm1hdHNbaV07 Cj4+Kwl9Cj4+Kwo+PisJcmV0dXJuIE5VTEw7Cj4+K30KPj4rCj4+K3N0YXRpYyBjb25zdCBzdHJ1 Y3QgZHJtX2Zvcm1hdF9pbmZvICoKPj4raW50ZWxfZ2V0X2Zvcm1hdF9pbmZvKGNvbnN0IHN0cnVj dCBkcm1fbW9kZV9mYl9jbWQyICpjbWQpCj4+K3sKPj4rCXN3aXRjaCAoY21kLT5tb2RpZmllclsw XSkgewo+PisJY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1M6Cj4+KwljYXNlIEk5MTVf Rk9STUFUX01PRF9ZZl9USUxFRF9DQ1M6Cj4+KwkJcmV0dXJuIGxvb2t1cF9mb3JtYXRfaW5mbyhj Y3NfZm9ybWF0cywKPj4rCQkJCQkgIEFSUkFZX1NJWkUoY2NzX2Zvcm1hdHMpLAo+PisJCQkJCSAg Y21kLT5waXhlbF9mb3JtYXQpOwo+PisJZGVmYXVsdDoKPj4rCQlyZXR1cm4gTlVMTDsKPj4rCX0K Pj4rfQo+PisKPj4gc3RhdGljIGludAo+PiBpbnRlbF9maWxsX2ZiX2luZm8oc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAJCSAgIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZi KQo+PkBAIC0xNjA4Myw2ICsxNjExOCw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2F0b21pY19zdGF0 ZV9mcmVlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4KPj4gc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgaW50ZWxfbW9kZV9mdW5jcyA9IHsKPj4gCS5m Yl9jcmVhdGUgPSBpbnRlbF91c2VyX2ZyYW1lYnVmZmVyX2NyZWF0ZSwKPj4rCS5nZXRfZm9ybWF0 X2luZm8gPSBpbnRlbF9nZXRfZm9ybWF0X2luZm8sCj4+IAkub3V0cHV0X3BvbGxfY2hhbmdlZCA9 IGludGVsX2ZiZGV2X291dHB1dF9wb2xsX2NoYW5nZWQsCj4+IAkuYXRvbWljX2NoZWNrID0gaW50 ZWxfYXRvbWljX2NoZWNrLAo+PiAJLmF0b21pY19jb21taXQgPSBpbnRlbF9hdG9taWNfY29tbWl0 LAo+PmRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaCBiL2luY2x1ZGUv dWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4+aW5kZXggOWUxYmI3ZmFiY2RlLi40NTgxZTNkNDFlNWMg MTAwNjQ0Cj4+LS0tIGEvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmgKPj4rKysgYi9pbmNs dWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+PkBAIC0yMzAsNiArMjMwLDU1IEBAIGV4dGVybiAi QyIgewo+PiAjZGVmaW5lIEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRCBmb3VyY2NfbW9kX2NvZGUo SU5URUwsIDMpCj4+Cj4+IC8qCj4+KyAqIEludGVsIGNvbG9yIGNvbnRyb2wgc3VyZmFjZSAoQ0NT KSBmb3IgcmVuZGVyIGNvbXByZXNzaW9uCj4+KyAqCj4+KyAqIFRoZSBmcmFtZWJ1ZmZlciBmb3Jt YXQgbXVzdCBiZSBvbmUgb2YgdGhlIDg6ODo4OjggUkdCIGZvcm1hdHMsCj4+KyAqIHRoZSBtYWlu IHN1cmZhY2Ugd2lsbCBiZSBwbGFuZSBpbmRleCAwIGFuZCB3aWxsIGJlIFkvWWYtdGlsZWQsCj4+ KyAqIHRoZSBDQ1Mgd2lsbCBiZSBwbGFuZSBpbmRleCAxLgo+PisgKgo+PisgKiBFYWNoIGJ5dGUg b2YgQ0NTIGNvbnRhaW5zIDQgcGFpcnMgb2YgYml0cywgd2l0aCBlYWNoIHBhaXIgb2YgYml0cwo+ PisgKiBtYXRjaGluZyBhbiBhcmVhIG9mIDh4NCBwaXhlbHMgb2YgdGhlIG1haW4gc3VyZmFjZS4g V2hpY2ggd291bGQgc2VlbQo+PisgKiB0byBtYXRjaCAyIGNhY2hlbGluZXMgY29udGFpbmluZyA0 eDQgcGl4ZWxzIGVhY2guIFRoZSBwYWlycyBiaXRzIHdpdGhpbgo+PisgKiB0aGUgYnl0ZSBmb3Jt IGEgMngyIGdyaWQsIHdoaWNoIHRodXMgbWF0Y2hlcyBhIDE2eDggcGl4ZWwgYXJlYSBvZiB0aGUK Pj4rICogbWFpbiBzdXJmYWNlLiBUaGlzIGlzIHRoZSAyeDIgcGF0dGVybiB0aGUgYml0cyBmb3Jt ICgwPWxzYiwgNz1tc2IpOgo+PisgKiAtLS0tLS0tLS0tLQo+PisgKiB8IDAxIHwgMjMgfAo+Pisg KiAgLS0tLS0tLS0tLQo+PisgKiB8IDQ1IHwgNjcgfAo+PisgKiAtLS0tLS0tLS0tLQo+PisgKgo+ PisgKiBBY3R1YWxseSBvbmx5IHRoZSBsb3dlciBiaXQgb2YgdGhlIHBhaXIgc2VlbXMgdG8gaGF2 ZSBhbnkgZWZmZWN0Lgo+PisgKiBObyBpZGVhIHdoeS4gMCBpbiB0aGUgbG93ZXIgYml0IHdvdWxk IHNlZW0gdG8gbWVhbiBub3QgY29tcHJlc3NlZCwKPj4rICogYW5kIDEgaXMgY29tcHJlc3NlZC4g IFRoZSBpbnRlcnByZWF0aW9uIG9mIHRoZSBtYWluIHN1cmZhY2UgZGF0YQo+PisgKiB3aGVuIHRo ZSBibG9jayBpcyBtYXJrZWQgY29tcHJlc3NlZCBpcyB1bmtub3duIGFzIG9mIG5vdy4KPj4rICoK Pj4rICogQ0NTIHRpbGUgaXMgbGFpZCBvdXQgaW4gOCBieXRlIGhvcml6b250YWwgc3RyaXBzIGVh Y2ggc3RyaXAgdGh1cyBjb3JyZXNwb25kcwo+PisgKiB0byBhIDEyOHg4IHBpeGVsIGFyZSBvZiB0 aGUgbWFpbiBzdXJmYWNlLiBTbyBlYWNoIDh4OCBieXRlcyBvZiB0aGUgQ0NTCj4+KyAqICgxIGNh Y2hlbGluZSkgd2lsbCBtYXRjaCBhbiBhcmVhIG9mIDR4MiB0aWxlcyBvbiB0aGUgbWFpbiBzdXJm YWNlLgo+PisgKgo+PisgKiBIZXJlIGlzIHRoZSBsYXlvdXQgb2YgYSBmdWxsIENDUyB0aWxlLCB3 aXRoIHRoZSA4IGJ5dGUgc3RyaXBzIG51bWJlcmVkIDAtNTExOgo+PisgKiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KPj4rICogfCAgMCB8ICA2NCB8IC4uLiB8IDQ0OCB8Cj4+KyAqIHwgIDEgfCAg NjUgfCAgICAgfCA0NDkgfAo+PisgKiB8ICAyIHwgIDY2IHwgICAgIHwgNDUwIHwKPj4rICogfCAg LiB8ICAgLiB8ICAgICB8ICAgLiB8Cj4+KyAqIHwgIC4gfCAgIC4gfCAgICAgfCAgIC4gfAo+Pisg KiB8ICAuIHwgICAuIHwgICAgIHwgICAuIHwKPj4rICogfCA2MyB8IDEyNyB8ICAgICB8IDUxMSB8 Cj4+KyAqIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PisgKgo+PisgKiBUaGlzIHdpbGwgbWF0 Y2ggYW4gYXJlYSBvZiAxMDI0eDUxMiBwaXhlbHMgb24gdGhlIG1haW4gc3VyZmFjZS4KPj4rICoK Pj4rICogVGhlIENDUyBwbGFuZSBwaXRjaCBtdXN0IGJlIGEgbXVsdGlwbGUgb2YgdGhlIENDUyB0 aWxlIHdpZHRoICg2NCBieXRlcyksCj4+KyAqIGFuZCBmb3IgdGhlIHB1cnBvc2VzIG9mIHRoZSBD Q1MgcGxhbmUgb2Zmc2V0IHdlIGFzc3VtZSBjcHA9PTEuIEFzIGVhY2gKPj4rICogYnl0ZSBtYXRj aGVzIGEgMTZ4OCBhcmVhIG9mIHRoZSBtYWluIHN1cmZhY2UsIHRoZSBkaW1lbnNpb25zIG9mIHRo ZSBDQ1MKPj4rICogcGxhbmUgd2lsbCB0aHVzIGFwcGVhciB0byBiZSB3aWR0aC8xNiB4IGhlaWdo dC84LiBCb3RoIHBsYW5lcyBtdXN0IGJlCj4+KyAqIGNvbnRhaW5lZCB3aXRoaW4gdGhlIHNhbWUg Z2VtIG9iamVjdC4KPj4rICovCj4+KyNkZWZpbmUgSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NT CWZvdXJjY19tb2RfY29kZShJTlRFTCwgNCkKPj4rI2RlZmluZSBJOTE1X0ZPUk1BVF9NT0RfWWZf VElMRURfQ0NTCWZvdXJjY19tb2RfY29kZShJTlRFTCwgNSkKPgo+QXJlIHdlIHN1cmUgdGhpcyBp cyBiZXR0ZXIgdGhhbiByZXNlcnZpbmcgc29tZSBiaXRzIGZvciB0aWxpbmcgbW9kZSAKPmFuZCBo YXZpbmcgQ0NTIGFzIHNlcGFyYXRlIGJpdCBmbGFnPyBJTUhPIGNvZGUgaXMgYWxyZWFkeSBhIGJp dCAKPnVuc2lnaHRseSB3aXRoIHRoaXMgc2NoZW1lIGFuZCBpdCB3b3VsZCB0YWtlIGp1c3Qgb25l IG1vcmUgb3J0aG9nb25hbCAKPmJ1dCBzaW11bHRhbmVvdXNseSB1c2FibGUgc2V0IG9mIG1vZGlm aWVycyB0byBkcm93biB1cyBpbiAKPnBlcm11dGF0aW9ucy4gV2UgZ290IHBsZW50eSBvZiBiaXRz IGF2YWlsYWJsZS4KPgo+UmVnYXJkcywKPgo+VHZydGtvCgpBZGRpbmcgS3Jpc3RpYW4uLi4KCk9i dmlvdXNseSBpdCdzIGEgbWF0dGVyIG9mIG9waW5pb24gYnV0IEkgY2VydGFpbmx5IGRvbid0IHRo aW5rIGl0J3MgdW5zaWdodGx5Cm5vdy4gSSBhZ3JlZSB0aGF0IGlmIHdlIGhhdmUgMSBtb3JlIG9y dGhvZ29uYWwgbW9kaWZpZXIgbWFrZXMgaXQgYmFkLCBhbmQgMgpwcmV0dHkgbXVjaCBtYWtlIGl0 IHRlcnJpYmxlIHdoaWNoIHdhcyBhY3R1YWxseSB3aGF0IEkgbGlrZWQgYWJvdXQgaGF2aW5nIHRo ZQpwZXIgcGxhbmUgbW9kaWZpZXJzLiBBbnl3YXksIGl0IHNlZW1zIGV2ZXJ5b25lIGhhcyBtb3N0 bHkgYWdyZWVkIG9uIHRoaXMKYWxyZWFkeSBhbmQgSSdkIHByb3Bvc2Ugd2UgbW92ZSBmb3J3YXJk IGFuZCBzYXkgdGhhdCBpZiB0aGlzIHNjaGVtZSBkb2Vzbid0CndvcmssIHdlIGJhaWwgZm9yIGFk ZGZiMy4KCkknbSBub3QgZW50aXJlbHkgY29udmluY2VkIHdlIG5lZWQgYSBZZiBldmVuIG5vdy4u Li4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==