From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759551AbdAFQ31 (ORCPT ); Fri, 6 Jan 2017 11:29:27 -0500 Received: from smtp.citrix.com ([66.165.176.89]:16668 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753052AbdAFQ3W (ORCPT ); Fri, 6 Jan 2017 11:29:22 -0500 X-IronPort-AV: E=Sophos;i="5.33,325,1477958400"; d="scan'208";a="398349370" Date: Fri, 6 Jan 2017 16:29:20 +0000 From: Wei Liu To: Juergen Gross CC: , , , , , , , Subject: Re: [PATCH 2/3] xen: modify xenstore watch event interface Message-ID: <20170106162920.GA1100@citrix.com> References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170106150544.10836-3-jgross@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 04:05:43PM +0100, Juergen Gross wrote: > Today a Xenstore watch event is delivered via a callback function > declared as: > > void (*callback)(struct xenbus_watch *, > const char **vec, unsigned int len); > > As all watch events only ever come with two parameters (path and token) > changing the prototype to: > > void (*callback)(struct xenbus_watch *, > const char *path, const char *token); > > is the natural thing to do. > > Apply this change and adapt all users. > > Cc: konrad.wilk@oracle.com > Cc: roger.pau@citrix.com > Cc: wei.liu2@citrix.com > Cc: paul.durrant@citrix.com > Cc: netdev@vger.kernel.org > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu