From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936712AbdAFQh1 (ORCPT ); Fri, 6 Jan 2017 11:37:27 -0500 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:63907 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdAFQhT (ORCPT ); Fri, 6 Jan 2017 11:37:19 -0500 X-IronPort-AV: E=Sophos;i="5.33,325,1477958400"; d="scan'208";a="38035776" Date: Fri, 6 Jan 2017 16:37:13 +0000 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Juergen Gross CC: , , , , , , Subject: Re: [PATCH 2/3] xen: modify xenstore watch event interface Message-ID: <20170106163713.tisdy6cj7muwu3h3@dhcp-3-221.uk.xensource.com> References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170106150544.10836-3-jgross@suse.com> User-Agent: NeoMutt/20161126 (1.7.1) X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 04:05:43PM +0100, Juergen Gross wrote: > Today a Xenstore watch event is delivered via a callback function > declared as: > > void (*callback)(struct xenbus_watch *, > const char **vec, unsigned int len); > > As all watch events only ever come with two parameters (path and token) > changing the prototype to: > > void (*callback)(struct xenbus_watch *, > const char *path, const char *token); > > is the natural thing to do. > > Apply this change and adapt all users. > > Cc: konrad.wilk@oracle.com > Cc: roger.pau@citrix.com > Cc: wei.liu2@citrix.com > Cc: paul.durrant@citrix.com > Cc: netdev@vger.kernel.org > > Signed-off-by: Juergen Gross blkback changes: Reviewed-by: Roger Pau Monné Thanks, Roger.