From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757470AbdAII6k (ORCPT ); Mon, 9 Jan 2017 03:58:40 -0500 Received: from mail-db5eur01hn0218.outbound.protection.outlook.com ([104.47.2.218]:10304 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757403AbdAII6g (ORCPT ); Mon, 9 Jan 2017 03:58:36 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rkagan@virtuozzo.com; Date: Mon, 9 Jan 2017 11:58:26 +0300 From: Roman Kagan To: CC: Paolo Bonzini , KY Srinivasan , Stephen Hemminger , Christoph Hellwig , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , "kvm@vger.kernel.org" , "Denis V . Lunev" , Haiyang Zhang , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "devel@linuxdriverproject.org" , Thomas Gleixner Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi Message-ID: <20170109085826.GC2128@rkaganb.sw.ru> Mail-Followup-To: Roman Kagan , hpa@zytor.com, Paolo Bonzini , KY Srinivasan , Stephen Hemminger , Christoph Hellwig , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , "kvm@vger.kernel.org" , "Denis V . Lunev" , Haiyang Zhang , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "devel@linuxdriverproject.org" , Thomas Gleixner References: <20161221154348.GA31401@infradead.org> <20161221095049.6fdc3145@xeon-e3> <20161221175836.GA8846@infradead.org> <20161221100247.69a4049b@xeon-e3> <20161228170943.GB14702@rkaganb.sw.ru> <64526782-26fb-0012-f467-b6e5a1ab6357@redhat.com> <20170109083222.GB2128@rkaganb.sw.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: DB6P191CA0015.EURP191.PROD.OUTLOOK.COM (10.175.236.153) To DB6PR0802MB2469.eurprd08.prod.outlook.com (10.172.251.17) X-MS-Office365-Filtering-Correlation-Id: 617fb031-1d90-41fc-d6b5-08d4386dafa5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0802MB2469; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2469;3:WtfVmnZtua/eejYyeu91RUB8qjyi+5B65LwHi1VWG8FsMS6+UbGYvyZ3i943GpgxmCMdb0tFYY8tRoYmY2uScmueNDD9rAv1Ivfxwxs/Ue+2TTv0iJbSFvrIVPNvTuO7fwgHtRAkDvTGySswym4Sc3cqjOesBwgbC9XfpA5/G0WCraEYUvlvRsDmdp5SBY+DIjto2dRUKQ+DwbAcWTJ+KZQUqnC4eDmrGrCyfIc7HEE0o8QCmFfnhOdfBwCJcJBJF0tHgSW/620RKybUiaRTVA== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2469;25:5vkDlmPCg2WnwnP6Y+8ZrxZi7IRoQffnvwxQr2DSLYTA7M+rRA4vBOcRqO3ZDjFcql2gvlIrWrF3A6b695t0Lc+dO/E4Y/F1QAu1kiu6c3QDGbrebhSIgBXCt2hrxm09T4+b8vWgYKZUqOoBUYPTfr4cYeWf2LW0iJUHpze289oAseffy2Ti/v4KlKUjvjpHz7VhLVpjjaDtx2JF7E2yUpi/U7a3KDB/srTj3jy3BhzIKeflDclRAyXfxvqRuClqcd+/NNPBUjgHse7cIzQ3O/EQY98eU6SD139TvGocY52W6KdtJTCZdR0HXjP6P9WqJ7oNm6EHisMcLaPxkznyG3kQWJ9/AKvwMCzYS1punGbMiCt526oWfxpS0Yenq+kD87rJNu0y4nBScm6v5MOJKeA9daCuqlJCrEBuuTf5vNGR4P9djiox/lcxqEYzcevmWbfnGrK/gxt9dyMoImbZQADICrU/c7kBuxpatqrp/Pktm/EyoFYtuAxZiJnpzCGRgsIacXHQLJXsQZb3ZoCHpXiXs8WL3kdGnWhW4M6Vh3wsKPNEd59lXCAnVmEna6GKdnxVhqjiuONkJkH6qdF3PKMnduuTg6+HpRYnJpFjw/VuuwjFzOk1CitvPAbmbCEU4nRvjTHeNMvAY4zFtVQQoJz6pqzqGU8IVAstf5bxJyXxFPD8gnUZc6FLj46s+9bMqhlw2bvybR/iaMtEcHFaXtVu4sw6w0++0LT5rr/RBcBs+/eg2lXlqoFvXGOJFHzU X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2469;31:62NFe6ObDU5aCwSlGGZ5HorGA0ChnyLsXGhVCO7X5JL2eH2h7TVuVVcxl7ElwgF5sN72jo4dJqob1IMe1YSqb3aQTM9BL43QZ8LZ5wS4P+h+CoGsKF1bTDQ15RCtf/Brk9j2iYCkSnwqclMJJJ+3o0OLc9XCj6sSAK9CyEr0E+O4IkbKp1Go8daNP+96WeQF2JZRnITE8E+JQ4UGGfTcq+izEBHAeLCxAUjCpNvPDp4vUcIZUy+Lg4+Tp/xuUyfnfwmZ/rzXO3i4BiV+1G4rkA==;20:8qGf+Ms1Nn+VF9/D1+JeNL+8Z7O9VMOJHDrLW9c6GhB0fkJl3Qoq6im40QjkpP3Mm8mL+3bJ2vVwtFUt53Eb575rf9GxVGd7U2h85cvzjRmbkAkF7oOrT7U3Rz6zMigy2WoA7HGWQOelq0DyI510kO9ed9jMkswoy7uWigDM3VTMd+gbqTGjPAjX51Nb1qep1ZajyF3vSzwx+K4GzZSNitwcsKPjRctEgzdcAB2rrjLYM/6C0kKlAkeLVu03xsMr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558021)(6072148);SRVR:DB6PR0802MB2469;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2469; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2469;4:V4XNpGAYZvAwE7M+usVj1TYPa+1GGV5FBglQUxFTCdxr3IbOSKSId9PIA7TxgQtNhnyLjAST3gYu96jt1k2yGeHVI/rxRZ9YwDPkBTH3BNlpwTaxvqC5XnFt2zGbZVAEq5JP/TcUbbcOY9+Oi4KvDsGyiEzRICmLloCU+4LYen40pCZj+xQnHcjV09oMRMTN6PTbDM7GPuM9SOaVc+Iavq6lqSJNVxSBNcSJbJlq/X77Ta/QQRVaElnjUGfZBIBBOZccsAMYSxYBUOf/1yqjCA8m3O/PMuCGfgR+zb+mkQfG7u7anHLT3PvYIbYyBdUfAqqkmJjPytw/hW5h73kh3aYx+PMrETJqwREOR+Spew/KsGngRBdL9R/8agPZ9wqw9vmUFrN7Cgu+SiHz2QzxYz3pmdqf+dcdzgiNJnI/0jlbwwiR+3zy6POfFP2KP5fQaf6AB57KY+KsaLQ+nu/r3eDVDmXGO3dJgHuFwdl7LEn0C/4bzEB78LhtQzj6XDOvD0yKNI+qBHSB/yxCPmFB/hvqo32did//gO5KHYRt7ByaReCHVqT6vQAhBfEcMqJ7h3+/aYStzdYNGvg7770RSAeAnb9vzzb7quTunSyJUKQ= X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:SPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(24454002)(377454003)(50466002)(47776003)(8676002)(25786008)(46406003)(6916009)(36756003)(3846002)(2906002)(6116002)(66066001)(5660300001)(23726003)(105586002)(1076002)(69596002)(2351001)(6506006)(54356999)(38730400001)(53416004)(7416002)(33656002)(42186005)(4326007)(189998001)(68736007)(8666007)(83506001)(229853002)(76176999)(106356001)(55016002)(4001350100001)(93886004)(81166006)(81156014)(305945005)(7736002)(97736004)(86362001)(110136003)(92566002)(97756001)(2950100002)(50986999)(6666003)(101416001)(54906002)(9686003)(30126002)(18370500001);DIR:OUT;SFP:1501;SCL:5;SRVR:DB6PR0802MB2469;H:rkaganb.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0802MB2469;23:OGNwpeGJzhI1sS+mEDBTMZCjx2+rNNjNt+3YvyN?= =?us-ascii?Q?qqddcWssJPXdU7+W786nq0p198GmQJtROLuJBfY82NXPSyXqEVJ6ilOfppF3?= =?us-ascii?Q?KFRPrWbM867XftFONTDS0FoiYlUS4FOM2Qc05kr9FY7FEwBcNkZjY51ZnKlG?= =?us-ascii?Q?rkwswjue9sBb8dYwK3PaRxXHgZXd7W549W0FYV6+CX317QSKSpc/STz1/qH7?= =?us-ascii?Q?mxwTwvB6NwgEZLg8sbuOmOdogSyzq4SrosSCUeXkjPi9BizjrDYcHMAU6Ovy?= =?us-ascii?Q?PUSbnUzKY5qqTntpinf4Fm+J/5KMvF+Ou5PHWi1Wc8+lnr2lqVQHkDkyShVF?= =?us-ascii?Q?QYSiz3MCmYlogCjWKWoUI7gL/LKBV8lnq5HuDb1u3DmSn1wnUVu7Ygk7JkwW?= =?us-ascii?Q?Uj5uJKsfKcANRLswG8u4SSDUjlyh7Yhk5v2xMdRHn00qxFbFy6/MIPNFe3Ju?= =?us-ascii?Q?MvkhZcQJLZ2a7ZlgobueCfJ8feqyI85if42cSsbvKUwFOcM+TwAjpYntzUax?= =?us-ascii?Q?zJTii8h3Grh/X0U3tw1oULMhcQc+GZFbSvzzxqWPOc6licJD4umFQPPFq2Wr?= =?us-ascii?Q?GiSgFdn7WVddgpntOYlfPwesPm6aP1l4IqqRd/f02X+lEQz21RcRj3QiDNvu?= =?us-ascii?Q?Vzpc08uPG/B6JhiEBCsUpu945Oy1upV3QH+yIJLOAlnlv3+f4eSOqtV5nT5W?= =?us-ascii?Q?lbuh5TP5SwFdKxt9l3qhs/v4ByKzgis+EsLeTdH9x7ajZ58x6aGwGPphE3DB?= =?us-ascii?Q?QffunxJwsNzsi4t8qGkhyBEDWqWSoofkYDPNGAbRO2YI876Zu2AVRzzh1vNv?= =?us-ascii?Q?V2PaN9c1lN+r42opuzXzJRVij3J1HmX0QXI+HEIlelFaG/3jF8V+Eo3CD8RK?= =?us-ascii?Q?TQsY4oWwma5xoEhvF5QMQxr4I2bg2AyhwgO6y2RYSUCM3YBDTkKYY2NkHmtz?= =?us-ascii?Q?b0ZJ4zZ1D3vdi48nzCBIM4BGhQNkSYUxIasDSqMgqImazFiC2z6Ib+JLygCA?= =?us-ascii?Q?QwkMNiy/FrmxFD/G4FYUANHNJzGOv8nr8ouOoOrc74NLCKl0a+Ol4+X5Y7xS?= =?us-ascii?Q?zH59gd+Z7kWt+6dnTh2HT473uXuNZdLNc18hXQHguP3IPABFy3PsNC6cYvFX?= =?us-ascii?Q?03Sdij/yy86D2qQjMOrx5lackZoEDnFtudgGvSLDWbl5WKZXE3Ujh46keaLy?= =?us-ascii?Q?xKWuZTUaYDmwnHWCajUh4UWf+TDuvA1Qrs2tcUE5SBJmhI4VoEGl3TYT1pBN?= =?us-ascii?Q?7vANmKJGvUQwCP2R/N9XqQFLw9ElzL2qVaqvGQ0IshyR0w70exYG1ukGllyv?= =?us-ascii?Q?SDgn+FWYtjsYL7mOfKm13grqpeFafSGqnZ5HnpFZcP/GfX9n42bthXbnTGaV?= =?us-ascii?Q?WhC4Een+U4r/732EZUnd/lJF3jIPKRna1UaAMXoxUwdInfz0oD/PaqwJo1Ew?= =?us-ascii?Q?bA3SZHrZq5b4LGZqlYTv1UborwYCiceIVIil1acQOisOkex/hNsTo?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2469;6:pCxCqAuhyjZbDy+bLJrh9BhNY9OoWYkbY/r43rdHBJWRc7AgGpDxXB7dS3HX/0ot2AR8vn2TgxTGJfyCNEZPhq2GBiaUN7EJXIt8c7X8eA7nAwx0pYQrnAsSBTuDPV4StPqauobCC0QDQbeloriVner8kfD9blkPBkPlHzOB79WM0Jktg7axI0VbwgiEiVa9iptkdL6Eqk0MikqjdcLC7nxzEo54XdKJTgi4CBCCIBst92Ageje0v2Qnoym5B48dcIheUP0jeZJz0yRM/k31sQIdC48rlBCdkoYe8ePiQ+RXRkPmJQtfRrr7OHKGEwXbTwFGVndchcKIQ6aGVOQfj/m1JyRdWygtxRRztDSXMEHObVEy0hYJcIAv6jX5HyW12d4V+3xl6mTsN+bLJBnAGQeF3SIlETzz4UhAitSa+ig=;5:3+hWyt5gpaT9+aZpMGM1FNM4m8LdV/uTDvzu8QP9lIVk8A+Gnlz9Q2dP0APyzqW5CfDEToP4Jaex4iLMM3hbHRtoJQz+X7pSxnkfw1s6LlG2aKjTMtwhXqXzUniiTeMINSmlihDggwO58FRkqGBWumoBmOLJbitRFlYezHozVgM=;24:glDcdPvrxj6YQU99OrvOH7c/fEk6OksAoYUQfVtsL+vLTr/4mVRcpkUBsO6wBoQUqTXDftPVN4ikFaE4Ci/V8Q== SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2469;7:5nX8C/nd81LEecTAo2GO01D+XIDqh9wYEGyqDhkoB4A8OzYlMtSmb66gV2EwMfotEpo39lafcCzRbhEddy9ORRxFJayRDMYGo/ZEMkjXV07nf2K8raYrMfyVBvbPuVw2+ubaA1PLKkzZ2Zkj+zmx0Uq5tZp1dthIRlWKzWRX3a1RLt4juXD0fjSvyJwEJqkWDzghQHgCAH8glxdFDwCRuh9nn87hmK98AOfGfuJ1oHYG5XHcaBPZt79UDYn+u2Ir94HPt4TorfkcJl04rhmHWM/uK24qShxV3isPp79Za6NaNIYKj13uhBejy7HhqG2PW0/IfD5/sPE3a4+POClcBrqKe57TvHoeI6HQ4egbhtTU9zrlPADRSNIfwZ8BARoKzntC0519Lqfj6z+VoF5+3cbNYx7qq3QMAgtu1ahLeowf8e4IESY1lv8N2I1x10akzTYsRCOVEh/627HagvcIHg==;20:0wQv5DOq1if5MQbpgisHeUbPEBQes211NGcm1etjQx7DgdJGSx1aoLG8DrZmlawYeuumuGUNWiroHp96rr6AWTkOLoPzVpRai8OA2f7UbmZIf/z6eQZMhPk9+yCleGoh/uP5T8qRaRtg04SdwhAxfWr+n6oVU0TMBDt/BymYdhA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 08:58:30.4675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2469 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 12:40:48AM -0800, hpa@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: > >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > >> On 28/12/2016 18:09, Roman Kagan wrote: > >> > Am I correct assuming that QEMU is currently the only user of > >> > arch/x86/include/uapi/asm/hyperv.h? > >> > > >> > Then I think we're fine withdrawing it from uapi as a whole and > >letting > >> > QEMU pull it in through its header-harvesting scripts (as does now > >> > anyway). This would lift all licensing and longterm API stability > >> > expectations. > >> > >> Actually, QEMU's header-harvesting scripts use uapi/ headers > >> exclusively, since they are built on "make headers_install". > >> > >> The extra cleanups that QEMU does on top are to allow compilation of > >the > >> headers on non-Linux machines. They don't really do much more than > >> changing Linux (linux/types.h) integer types to the C99 (stdint.h) > >> equivalents. > > > >Ouch, I stand corrected. > > > >So what should we do with it then? I'm sorta lost... > > > >We certainly can give it up and live with a private copy of the > >definitions in the QEMU tree but that doesn't sound optimal in any > >sense. > > > >Thanks, > >Roman. > > Why do that through header mangling rather than typedef? Sorry for not being clear, I actually asked what to do with the Hyper-V and VMBus protocol definitions. The typedef vs mangling is a different matter; I guess mangling was chosen to avoid conflicts with system-provided definitions on non-Linux systems, but I think Paolo can tell more. Roman. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Kagan Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi Date: Mon, 9 Jan 2017 11:58:26 +0300 Message-ID: <20170109085826.GC2128@rkaganb.sw.ru> References: <20161221154348.GA31401@infradead.org> <20161221095049.6fdc3145@xeon-e3> <20161221175836.GA8846@infradead.org> <20161221100247.69a4049b@xeon-e3> <20161228170943.GB14702@rkaganb.sw.ru> <64526782-26fb-0012-f467-b6e5a1ab6357@redhat.com> <20170109083222.GB2128@rkaganb.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , "kvm@vger.kernel.org" , Radim =?utf-8?B?S3LEjW3DocWZ?= , Haiyang Zhang , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , Ingo Molnar , "Denis V . Lunev" , Paolo Bonzini , Thomas Gleixner To: Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: kvm.vger.kernel.org On Mon, Jan 09, 2017 at 12:40:48AM -0800, hpa@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: > >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > >> On 28/12/2016 18:09, Roman Kagan wrote: > >> > Am I correct assuming that QEMU is currently the only user of > >> > arch/x86/include/uapi/asm/hyperv.h? > >> > > >> > Then I think we're fine withdrawing it from uapi as a whole and > >letting > >> > QEMU pull it in through its header-harvesting scripts (as does now > >> > anyway). This would lift all licensing and longterm API stability > >> > expectations. > >> > >> Actually, QEMU's header-harvesting scripts use uapi/ headers > >> exclusively, since they are built on "make headers_install". > >> > >> The extra cleanups that QEMU does on top are to allow compilation of > >the > >> headers on non-Linux machines. They don't really do much more than > >> changing Linux (linux/types.h) integer types to the C99 (stdint.h) > >> equivalents. > > > >Ouch, I stand corrected. > > > >So what should we do with it then? I'm sorta lost... > > > >We certainly can give it up and live with a private copy of the > >definitions in the QEMU tree but that doesn't sound optimal in any > >sense. > > > >Thanks, > >Roman. > > Why do that through header mangling rather than typedef? Sorry for not being clear, I actually asked what to do with the Hyper-V and VMBus protocol definitions. The typedef vs mangling is a different matter; I guess mangling was chosen to avoid conflicts with system-provided definitions on non-Linux systems, but I think Paolo can tell more. Roman.