From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762014AbdAINgA (ORCPT ); Mon, 9 Jan 2017 08:36:00 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:37454 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761926AbdAINeV (ORCPT ); Mon, 9 Jan 2017 08:34:21 -0500 Date: Mon, 9 Jan 2017 05:33:49 -0800 From: Christoph Hellwig To: Richard Weinberger Cc: "Theodore Ts'o" , Eric Biggers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org, hch@infradead.org, arnd@arndb.de, dedekind1@gmail.com, linux-mtd@lists.infradead.org, adrian.hunter@intel.com, linux-ext4@vger.kernel.org, ebiggers@google.com, rdunlap@infradead.org, david@sigma-star.at Subject: Re: [PATCH v2] fscrypt: Factor out bio specific functions Message-ID: <20170109133349.GA19577@infradead.org> References: <20161219103929.GA16197@infradead.org> <20161219112532.18863-1-richard@nod.at> <20170101214725.g67msbedmpx27waz@thunk.org> <20170103142836.no7rp3hphj3czjto@thunk.org> <20170104201043.GA21696@gmail.com> <20170107192406.56p7ppbdfkjii4vy@thunk.org> <21de1dd8-b491-8c59-e874-6834978f1e2e@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21de1dd8-b491-8c59-e874-6834978f1e2e@nod.at> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 07, 2017 at 11:40:15PM +0100, Richard Weinberger wrote: > Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled. > UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs. > This will enable ENCRYPTION even when no block support is available. It's the good old select vs depends mess once again. > I can make UBIFS depend on BLOCK as intermediate fix. > But the real fix is this patch. And despite the diffstat it's simple and trivial as it just moves code. There is no good reason not to take it for 4.10. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2] fscrypt: Factor out bio specific functions Date: Mon, 9 Jan 2017 05:33:49 -0800 Message-ID: <20170109133349.GA19577@infradead.org> References: <20161219103929.GA16197@infradead.org> <20161219112532.18863-1-richard@nod.at> <20170101214725.g67msbedmpx27waz@thunk.org> <20170103142836.no7rp3hphj3czjto@thunk.org> <20170104201043.GA21696@gmail.com> <20170107192406.56p7ppbdfkjii4vy@thunk.org> <21de1dd8-b491-8c59-e874-6834978f1e2e@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: david@sigma-star.at, rdunlap@infradead.org, Theodore Ts'o , arnd@arndb.de, dedekind1@gmail.com, Eric Biggers , linux-kernel@vger.kernel.org, ebiggers@google.com, adrian.hunter@intel.com, hch@infradead.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org To: Richard Weinberger Return-path: Content-Disposition: inline In-Reply-To: <21de1dd8-b491-8c59-e874-6834978f1e2e@nod.at> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-ext4.vger.kernel.org On Sat, Jan 07, 2017 at 11:40:15PM +0100, Richard Weinberger wrote: > Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled. > UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs. > This will enable ENCRYPTION even when no block support is available. It's the good old select vs depends mess once again. > I can make UBIFS depend on BLOCK as intermediate fix. > But the real fix is this patch. And despite the diffstat it's simple and trivial as it just moves code. There is no good reason not to take it for 4.10. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/