From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] dma-fence: Introduce drm_fence_set_error() helper Date: Mon, 9 Jan 2017 14:56:50 +0000 Message-ID: <20170109145650.GY19067@nuc-i3427.alporthouse.com> References: <20170104141222.6992-1-chris@chris-wilson.co.uk> <20170104141222.6992-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sumit Semwal Cc: Intel Graphics Development , DRI mailing list List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMDksIDIwMTcgYXQgMDg6MTM6MTFQTSArMDUzMCwgU3VtaXQgU2Vtd2FsIHdy b3RlOgo+IEhpIENocmlzLAo+IAo+IE9uIDQgSmFudWFyeSAyMDE3IGF0IDE5OjQyLCBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JvdGU6Cj4gPiBUaGUgZG1hX2ZlbmNl LmVycm9yIGZpZWxkIChmb3JtZXJseSBrbm93biBhcyBkbWFfZmVuY2Uuc3RhdHVzKSBpcyBhbgo+ ID4gb3B0aW9uYWwgZmllbGQgdGhhdCBtYXkgYmUgc2V0IGJ5IGRyaXZlcnMgYmVmb3JlIGNhbGxp bmcKPiA+IGRtYV9mZW5jZV9zaWduYWwoKS4gVGhlIGZpZWxkIGNhbiBiZSB1c2VkIHRvIGluZGlj YXRlIHRoYXQgdGhlIGZlbmNlIHdhcwo+ID4gY29tcGxldGVkIGluIGVyciByYXRoZXIgdGhhbiB3 aXRoIHN1Y2Nlc3MsIGFuZCBpcyB2aXNpYmxlIHRvIG90aGVyCj4gPiBjb25zdW1lcnMgb2YgdGhl IGZlbmNlIGFuZCB0byB1c2Vyc3BhY2UgdmlhIHN5bmNfZmlsZS4KPiA+Cj4gPiBUaGlzIHBhdGNo IHJlbmFtZXMgdGhlIGZpZWxkIGZyb20gc3RhdHVzIHRvIGVycm9yIHNvIHRoYXQgaXRzIG1lYW5p bmcgaXMKPiA+IGhvcGVmdWxseSBtb3JlIGNsZWFyIChhbmQgZGlzdGluY3QgZnJvbSBkbWFfZmVu Y2VfZ2V0X3N0YXR1cygpIHdoaWNoIGlzCj4gPiBhIGNvbXBvc2l0ZSBiZXR3ZWVuIHRoZSBlcnJv ciBzdGF0ZSBhbmQgc2lnbmFsIHN0YXRlKSBhbmQgYWRkcyBhIGhlbHBlcgo+ID4gdGhhdCB2YWxp ZGF0ZXMgdGhlIHByZWNvbmRpdGlvbnMgb2Ygd2hlbiBpdCBpcyBzdWl0YWJsZSB0byBhZGp1c3Qg dGhlCj4gPiBlcnJvciBmaWVsZC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZG1hLWJ1Zi9k bWEtZmVuY2UuYyB8ICAyICstCj4gPiAgaW5jbHVkZS9saW51eC9kbWEtZmVuY2UuaCAgIHwgMzAg KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNiBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2RtYS1idWYvZG1hLWZlbmNlLmMgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMKPiA+IGlu ZGV4IDdkOTM2ZDE5ZTY1OS4uZWU4MmYzNmNiMjVlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9k bWEtYnVmL2RtYS1mZW5jZS5jCj4gPiArKysgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMK PiA+IEBAIC01NTksNyArNTU5LDcgQEAgZG1hX2ZlbmNlX2luaXQoc3RydWN0IGRtYV9mZW5jZSAq ZmVuY2UsIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzICpvcHMsCj4gPiAgICAgICAgIGZlbmNl LT5jb250ZXh0ID0gY29udGV4dDsKPiA+ICAgICAgICAgZmVuY2UtPnNlcW5vID0gc2Vxbm87Cj4g PiAgICAgICAgIGZlbmNlLT5mbGFncyA9IDBVTDsKPiA+IC0gICAgICAgZmVuY2UtPnN0YXR1cyA9 IDA7Cj4gPiArICAgICAgIGZlbmNlLT5lcnJvciA9IDA7Cj4gPgo+ID4gICAgICAgICB0cmFjZV9k bWFfZmVuY2VfaW5pdChmZW5jZSk7Cj4gPiAgfQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGlu dXgvZG1hLWZlbmNlLmggYi9pbmNsdWRlL2xpbnV4L2RtYS1mZW5jZS5oCj4gPiBpbmRleCAxOWY3 YWY5MDUxODIuLjYwNDhmYTQwNGU1NyAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvbGludXgvZG1h LWZlbmNlLmgKPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvZG1hLWZlbmNlLmgKPiA+IEBAIC00Nyw3 ICs0Nyw3IEBAIHN0cnVjdCBkbWFfZmVuY2VfY2I7Cj4gPiAgICogY2FuIGJlIGNvbXBhcmVkIHRv IGRlY2lkZSB3aGljaCBmZW5jZSB3b3VsZCBiZSBzaWduYWxlZCBsYXRlci4KPiA+ICAgKiBAZmxh Z3M6IEEgbWFzayBvZiBETUFfRkVOQ0VfRkxBR18qIGRlZmluZWQgYmVsb3cKPiA+ICAgKiBAdGlt ZXN0YW1wOiBUaW1lc3RhbXAgd2hlbiB0aGUgZmVuY2Ugd2FzIHNpZ25hbGVkLgo+ID4gLSAqIEBz dGF0dXM6IE9wdGlvbmFsLCBvbmx5IHZhbGlkIGlmIDwgMCwgbXVzdCBiZSBzZXQgYmVmb3JlIGNh bGxpbmcKPiA+ICsgKiBAZXJyb3I6IE9wdGlvbmFsLCBvbmx5IHZhbGlkIGlmIDwgMCwgbXVzdCBi ZSBzZXQgYmVmb3JlIGNhbGxpbmcKPiA+ICAgKiBkbWFfZmVuY2Vfc2lnbmFsLCBpbmRpY2F0ZXMg dGhhdCB0aGUgZmVuY2UgaGFzIGNvbXBsZXRlZCB3aXRoIGFuIGVycm9yLgo+ID4gICAqCj4gPiAg ICogdGhlIGZsYWdzIG1lbWJlciBtdXN0IGJlIG1hbmlwdWxhdGVkIGFuZCByZWFkIHVzaW5nIHRo ZSBhcHByb3ByaWF0ZQo+ID4gQEAgLTc5LDcgKzc5LDcgQEAgc3RydWN0IGRtYV9mZW5jZSB7Cj4g PiAgICAgICAgIHVuc2lnbmVkIHNlcW5vOwo+ID4gICAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdz Owo+ID4gICAgICAgICBrdGltZV90IHRpbWVzdGFtcDsKPiA+IC0gICAgICAgaW50IHN0YXR1czsK PiA+ICsgICAgICAgaW50IGVycm9yOwo+ID4gIH07Cj4gPgo+ID4gIGVudW0gZG1hX2ZlbmNlX2Zs YWdfYml0cyB7Cj4gPiBAQCAtMTMzLDcgKzEzMyw3IEBAIHN0cnVjdCBkbWFfZmVuY2VfY2Igewo+ ID4gICAqIG9yIHNvbWUgZmFpbHVyZSBvY2N1cnJlZCB0aGF0IG1hZGUgaXQgaW1wb3NzaWJsZSB0 byBlbmFibGUKPiA+ICAgKiBzaWduYWxpbmcuIFRydWUgaW5kaWNhdGVzIHN1Y2Nlc3NmdWwgZW5h YmxpbmcuCj4gPiAgICoKPiA+IC0gKiBmZW5jZS0+c3RhdHVzIG1heSBiZSBzZXQgaW4gZW5hYmxl X3NpZ25hbGluZywgYnV0IG9ubHkgd2hlbiBmYWxzZSBpcwo+ID4gKyAqIGZlbmNlLT5lcnJvciBt YXkgYmUgc2V0IGluIGVuYWJsZV9zaWduYWxpbmcsIGJ1dCBvbmx5IHdoZW4gZmFsc2UgaXMKPiA+ ICAgKiByZXR1cm5lZC4KPiA+ICAgKgo+ID4gICAqIENhbGxpbmcgZG1hX2ZlbmNlX3NpZ25hbCBi ZWZvcmUgZW5hYmxlX3NpZ25hbGluZyBpcyBjYWxsZWQgYWxsb3dzCj4gPiBAQCAtMTQ1LDcgKzE0 NSw3IEBAIHN0cnVjdCBkbWFfZmVuY2VfY2Igewo+ID4gICAqIHRoZSBzZWNvbmQgdGltZSB3aWxs IGJlIGEgbm9vcCBzaW5jZSBpdCB3YXMgYWxyZWFkeSBzaWduYWxlZC4KPiA+ICAgKgo+ID4gICAq IE5vdGVzIG9uIHNpZ25hbGVkOgo+ID4gLSAqIE1heSBzZXQgZmVuY2UtPnN0YXR1cyBpZiByZXR1 cm5pbmcgdHJ1ZS4KPiA+ICsgKiBNYXkgc2V0IGZlbmNlLT5lcnJvciBpZiByZXR1cm5pbmcgdHJ1 ZS4KPiA+ICAgKgo+ID4gICAqIE5vdGVzIG9uIHdhaXQ6Cj4gPiAgICogTXVzdCBub3QgYmUgTlVM TCwgc2V0IHRvIGRtYV9mZW5jZV9kZWZhdWx0X3dhaXQgZm9yIGRlZmF1bHQgaW1wbGVtZW50YXRp b24uCj4gPiBAQCAtMzk1LDEzICszOTUsMzMgQEAgc3RhdGljIGlubGluZSBzdHJ1Y3QgZG1hX2Zl bmNlICpkbWFfZmVuY2VfbGF0ZXIoc3RydWN0IGRtYV9mZW5jZSAqZjEsCj4gPiAgc3RhdGljIGlu bGluZSBpbnQgZG1hX2ZlbmNlX2dldF9zdGF0dXNfbG9ja2VkKHN0cnVjdCBkbWFfZmVuY2UgKmZl bmNlKQo+ID4gIHsKPiA+ICAgICAgICAgaWYgKGRtYV9mZW5jZV9pc19zaWduYWxlZF9sb2NrZWQo ZmVuY2UpKQo+ID4gLSAgICAgICAgICAgICAgIHJldHVybiBmZW5jZS0+c3RhdHVzIDwgMCA/IGZl bmNlLT5zdGF0dXMgOiAxOwo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBmZW5jZS0+ZXJyb3Ig PzogMTsKPiA+ICAgICAgICAgZWxzZQo+ID4gICAgICAgICAgICAgICAgIHJldHVybiAwOwo+ID4g IH0KPiA+Cj4gPiAgaW50IGRtYV9mZW5jZV9nZXRfc3RhdHVzKHN0cnVjdCBkbWFfZmVuY2UgKmZl bmNlKTsKPiA+Cj4gPiArLyoqCj4gPiArICogZG1hX2ZlbmNlX3NldF9lcnJvciAtIGZsYWcgYW4g ZXJyb3IgY29uZGl0aW9uIG9uIHRoZSBmZW5jZQo+ID4gKyAqIEBmZW5jZTogW2luXSAgICAgICAg dGhlIGRtYV9mZW5jZQo+ID4gKyAqIEBlcnJvcjogW2luXSAgICAgICAgdGhlIGVycm9yIHRvIHN0 b3JlCj4gPiArICoKPiA+ICsgKiBEcml2ZXJzIGNhbiBzdXBwbHkgYW4gb3B0aW9uYWwgZXJyb3Ig c3RhdHVzIGNvbmRpdGlvbiBiZWZvcmUgdGhleSBzaWduYWwKPiA+ICsgKiB0aGUgZmVuY2UsIHRv IGluZGljYXRlIHRoYXQgdGhlIGZlbmNlIHdhcyBjb21wbGV0ZWQgZHVlIHRvIGFuIGVycm9yCj4g PiArICogcmF0aGVyIHRoYW4gc3VjY2Vzcy4gVGhpcyBtdXN0IGJlIHNldCBiZWZvcmUgc2lnbmFs aW5nIChzbyB0aGF0IHRoZSB2YWx1ZQo+ID4gKyAqIGlzIHZpc2libGUgYmVmb3JlIGFueSB3YWl0 ZXJzIG9uIHRoZSBzaWduYWwgY2FsbGJhY2sgYXJlIHdva2VuKS4gVGhpcwo+ID4gKyAqIGhlbHBl ciBleGlzdHMgdG8gaGVscCBjYXRjaGluZyBlcnJvbmVvdXMgc2V0dGluZyBvZiAjZG1hX2ZlbmNl LmVycm9yLgo+ID4gKyAqLwo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBkbWFfZmVuY2Vfc2V0X2Vy cm9yKHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaW50IGVycm9yKQo+ID4gK3sKPiA+ICsgICAgICAgQlVHX09OKHRlc3Rf Yml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwgJmZlbmNlLT5mbGFncykpOwo+ID4gKyAg ICAgICBCVUdfT04oZXJyb3IgPj0gMCB8fCBlcnJvciA8IC1NQVhfRVJSTk8pOwo+ID4gKwo+ID4g KyAgICAgICBmZW5jZS0+ZXJyb3IgPSBlcnJvcjsKPiA+ICt9Cj4gU29ycnkgSSBtaXNzZWQgdGhp cyBlYXJsaWVyLCBidXQgYXJlIHlvdSBzdXJlIHlvdSB3YW50IHRvIHVzZSBhIEJVR19PTgo+IGhl cmUsIGFuZCBub3QgYSBXQVJOX09OPwoKR2l2ZW4gdGhhdCBpdCBpcyBhIHZvaWQgcmV0dXJuLCB0 aGVyZSdzIG5vd2hlcmUgZm9yIHRoZSB3YXJuaW5nIHRvIGdvLgpUaGUgc2Vjb25kIGlzIGEgZGVm aW5pdGUgcHJvZ3JhbW1pbmcgZXJyb3IgYW5kIHNob3VsZCBob3BlZnVsbHkgYmUKZWxpbWluYXRl ZCBhdCBjb21waWxldGltZSwgYnV0IHdyaXRpbmcgaXQgYXMgYSBCVUlMRF9CVUcgb3IKX19idWls dGluX2NvbnN0YW50X3AgbWF5IG5vdCB3b3JrIC0gQlVJTERfQlVHX09OKGVycm9yLi4uKSBoYXBw ZW5zIHRvCndvcmsgZm9yIG15IGNvZGUuIElmIHlvdSB3YW50IHRvIHVzZQoKLSAgICAgICBCVUdf T04odGVzdF9iaXQoRE1BX0ZFTkNFX0ZMQUdfU0lHTkFMRURfQklULCAmZmVuY2UtPmZsYWdzKSk7 Ci0gICAgICAgQlVHX09OKGVycm9yID49IDAgfHwgZXJyb3IgPCAtTUFYX0VSUk5PKTsKKyAgICAg ICBCVUlMRF9CVUdfT04oZXJyb3IgPj0gMCB8fCBlcnJvciA8IC1NQVhfRVJSTk8pOworICAgICAg IFdBUk5fT04odGVzdF9iaXQoRE1BX0ZFTkNFX0ZMQUdfU0lHTkFMRURfQklULCAmZmVuY2UtPmZs YWdzKSk7CiAKYW5kIGhhdmUgYSBzb2Z0bG9ja3VwIGluc3RlYWQsIGJlIG15IGd1ZXN0LgotQ2hy aXMKCi0tIApDaHJpcyBXaWxzb24sIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudHJl Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=