From: Jiri Pirko <jiri@resnulli.us>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>
Subject: Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2
Date: Mon, 9 Jan 2017 17:07:44 +0100 [thread overview]
Message-ID: <20170109160744.GE1862@nanopsycho> (raw)
In-Reply-To: <20170109160019.GF25588@lunn.ch>
Mon, Jan 09, 2017 at 05:00:19PM CET, andrew@lunn.ch wrote:
>> > No. That should be unique within one switch. In mlxsw we name it "p1",
>> > "p2", ...
>> >
>> > The final netdev names are:
>> > enp3s0np1, enp3s0np2, ...
>>
>
>mlxsw are pci devices, so it follows this convention, i think:
>
> * [P<domain>]p<bus>s<slot>[f<function>][n<phys_port_name>|d<dev_port>]
> * PCI geographical location
>
>Our devices are not on PCI. So they won't follow this. I've no idea
>what they actually follow, since some are MDIO devices, some are SPI
>devices, some are memory mapped.
Got it. We just have to make sure udev names them appropriately.
>
>I'm not against making the label option, but i do want to better
>understand what we get as a result, just to make sure it is sensible.
>
>Vivien, could you try a recent udev and see what happens?
>
> Thanks
> Andrew
next prev parent reply other threads:[~2017-01-09 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 23:15 [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Vivien Didelot
2017-01-08 23:30 ` Andrew Lunn
2017-01-09 2:56 ` Vivien Didelot
2017-01-09 7:32 ` Jiri Pirko
2017-01-09 15:04 ` Vivien Didelot
2017-01-09 15:11 ` Jiri Pirko
2017-01-09 15:45 ` Vivien Didelot
2017-01-09 16:00 ` Andrew Lunn
2017-01-09 16:07 ` Jiri Pirko [this message]
2017-01-09 16:06 ` Jiri Pirko
2017-01-09 17:42 ` Florian Fainelli
2017-01-09 17:58 ` Jiri Pirko
2017-01-09 18:06 ` Florian Fainelli
2017-01-10 9:55 ` Jiri Pirko
2017-01-10 17:58 ` Florian Fainelli
2017-01-11 7:26 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109160744.GE1862@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.