From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035026AbdAIR7y (ORCPT ); Mon, 9 Jan 2017 12:59:54 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34494 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033515AbdAIR7W (ORCPT ); Mon, 9 Jan 2017 12:59:22 -0500 Date: Mon, 9 Jan 2017 18:58:42 +0100 From: Jiri Pirko To: Florian Fainelli Cc: Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andrey Smirnov Subject: Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Message-ID: <20170109175842.GH1862@nanopsycho> References: <20170108231552.26995-1-vivien.didelot@savoirfairelinux.com> <20170109073236.GA1862@nanopsycho> <877f6446lp.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <20170109151131.GC1862@nanopsycho> <87y3yk2q5e.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <20170109160632.GD1862@nanopsycho> <89492624-84f2-ca73-75dd-7fa10819ad09@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89492624-84f2-ca73-75dd-7fa10819ad09@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Jan 09, 2017 at 06:42:07PM CET, f.fainelli@gmail.com wrote: >On 01/09/2017 08:06 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.didelot@savoirfairelinux.com wrote: >>> Hi Jiri, >>> >>> Jiri Pirko writes: >>> >>>>> Extra question: shouldn't phys_port_{id,name} be switchdev attributes in >>>> >>>> Again, phys_port_id has nothing to do with switches. Should be removed >>>> from dsa because its use there is incorrect. >>> >>> Florian, since 3a543ef just got in, can it be reverted? >> >> Yes, please revert it. It is only in net-next. > >Maybe the use case can be understood before reverting the change. How do >we actually the physical port number of an Ethernet switch per-port >network device? The name is not enough, because there are plenty of >cases where we need to manipulate a physical port number (be it just for >informational purposes). Like what? Why the name is not enough? This is something propagated to userspace and never used internally in kernel. Btw, ndo_get_phys_port_id does not give you number, but arbitrary binary. > >Should we just amend the existing description of ndo_get_phys_port_id()? >Should we introduce another ndo for that? >-- >Florian