From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 1/2] nvmem: core: Correct a bunch of function documentations Date: Mon, 9 Jan 2017 11:52:46 -0800 Message-ID: <20170109195246.GP17126@codeaurora.org> References: <1483693823-8858-1-git-send-email-vivek.gautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:33236 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933292AbdAITws (ORCPT ); Mon, 9 Jan 2017 14:52:48 -0500 Content-Disposition: inline In-Reply-To: <1483693823-8858-1-git-send-email-vivek.gautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Vivek Gautam Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, linux-arm-msm@vger.kernel.org On 01/06, Vivek Gautam wrote: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 398ea7f54826..294cdef96277 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -634,8 +634,8 @@ struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id) > /** > * nvmem_device_get() - Get nvmem device from a given id > * > - * @dev : Device that uses the nvmem device > - * @id: nvmem name from nvmem-names property. > + * @dev : Device that uses the nvmem device. ^ Drop this space? > + * @dev_name: name of the requested nvmem device. > * > * Return: ERR_PTR() on error or a valid pointer to a struct nvmem_device > * on success. > @@ -674,6 +674,7 @@ static void devm_nvmem_device_release(struct device *dev, void *res) > /** > * devm_nvmem_device_put() - put alredy got nvmem device > * > + * @dev : Device that uses the nvmem device. ^ Drop this space? > * @nvmem: pointer to nvmem device allocated by devm_nvmem_cell_get(), > * that needs to be released. > */ > @@ -702,8 +703,8 @@ void nvmem_device_put(struct nvmem_device *nvmem) > /** > * devm_nvmem_device_get() - Get nvmem cell of device form a given id > * > - * @dev node: Device tree node that uses the nvmem cell > - * @id: nvmem name in nvmems property. > + * @dev : Device that requests the nvmem device. ^ Drop this space? > + * @id: name id for the requested nvmem device. > * > * Return: ERR_PTR() on error or a valid pointer to a struct nvmem_cell > * on success. The nvmem_cell will be freed by the automatically once the -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project