All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	vivien.didelot@savoirfairelinux.com, andrew@lunn.ch,
	jiri@resnulli.us
Subject: Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA
Date: Mon, 9 Jan 2017 22:48:49 +0200	[thread overview]
Message-ID: <20170109204849.GA28310@splinter> (raw)
In-Reply-To: <20170109194503.10713-1-f.fainelli@gmail.com>

Hi Florian,

On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote:
> Hi all,
> 
> This patch series is to resolve a sleeping function called in atomic context
> debug splat that we observe with DSA.
> 
> Let me know what you think, I was also wondering if we should just always
> make switchdev_port_vlan_fill() set SWITCHDEV_F_DEFER, but was afraid this
> could cause invalid contexts to be used for rocker, mlxsw, i40e etc.

Isn't this a bit of overkill? All the drivers you mention fill the VLAN
dump from their cache and don't require sleeping. Even b53 that you
mention in the last patch does that, but reads the PVID from the device,
which entails taking a mutex.

Can't you just cache the PVID as well? I think this will solve your
problem. Didn't look too much into the b53 code, so maybe I'm missing
something. Seems that mv88e6xxx has a similar problem.

Thanks!

  parent reply	other threads:[~2017-01-09 20:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 19:44 [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA Florian Fainelli
2017-01-09 19:45 ` [PATCH net-next 1/4] net: switchdev: Prepare for deferred functions modifying objects Florian Fainelli
2017-01-09 19:45 ` [PATCH net-next 2/4] net: switchdev: Add object dump deferred operation Florian Fainelli
2017-01-09 19:45 ` [PATCH net-next 3/4] net: switchdev: Add switchdev_port_bridge_getlink_deferred Florian Fainelli
2017-01-09 20:11   ` Marcelo Ricardo Leitner
2017-01-09 20:13     ` Florian Fainelli
2017-01-09 20:28       ` Marcelo Ricardo Leitner
2017-01-09 20:29         ` Florian Fainelli
2017-01-10  0:25   ` kbuild test robot
2017-01-09 19:45 ` [PATCH net-next 4/4] net: dsa: Utilize switchdev_port_bridge_getlink_deferred() Florian Fainelli
2017-01-09 20:48 ` Ido Schimmel [this message]
2017-01-09 20:56   ` [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA Florian Fainelli
2017-01-09 21:14     ` Ido Schimmel
2017-01-09 21:23       ` Andrew Lunn
2017-01-09 21:29         ` Ido Schimmel
2017-01-10 12:08       ` Jiri Pirko
2017-01-10 13:25         ` Ido Schimmel
2017-01-10 14:18           ` Jiri Pirko
2017-01-10 16:08             ` Ido Schimmel
2017-01-10 16:13               ` Jiri Pirko
2017-01-11  1:42               ` Florian Fainelli
2017-01-11 14:59                 ` Andrew Lunn
2017-01-09 21:19     ` Vivien Didelot
2017-01-11  1:26     ` David Miller
2017-01-09 21:05   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109204849.GA28310@splinter \
    --to=idosch@idosch.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.