From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 6/7] ixgbe: remove useless return Date: Mon, 9 Jan 2017 15:30:21 -0800 Message-ID: <20170109233022.31154-7-stephen@networkplumber.org> References: <20170109233022.31154-1-stephen@networkplumber.org> Cc: Stephen Hemminger To: dev@dpdk.org Return-path: Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id 5D2073777 for ; Tue, 10 Jan 2017 00:30:36 +0100 (CET) Received: by mail-pf0-f170.google.com with SMTP id 189so22867617pfu.3 for ; Mon, 09 Jan 2017 15:30:36 -0800 (PST) In-Reply-To: <20170109233022.31154-1-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If all goto's lead to a return, then better to get rid of goto. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_82599_bypass.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_82599_bypass.c b/drivers/net/ixgbe/ixgbe_82599_bypass.c index de9fa5a7..af55cc0a 100644 --- a/drivers/net/ixgbe/ixgbe_82599_bypass.c +++ b/drivers/net/ixgbe/ixgbe_82599_bypass.c @@ -73,7 +73,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) &eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to read Rx Rate Select RS0"); - goto out; + return; } eeprom_data = (eeprom_data & ~IXGBE_SFF_SOFT_RS_SELECT_MASK) & rs; @@ -83,7 +83,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to write Rx Rate Select RS0"); - goto out; + return; } /* Set RS1 */ @@ -92,7 +92,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) &eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to read Rx Rate Select RS1"); - goto out; + return; } eeprom_data = (eeprom_data & ~IXGBE_SFF_SOFT_RS_SELECT_MASK) & rs; @@ -102,10 +102,8 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed) eeprom_data); if (status) { PMD_DRV_LOG(ERR, "Failed to write Rx Rate Select RS1"); - goto out; + return; } -out: - return; } /** -- 2.11.0