From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934030AbdAJJpO (ORCPT ); Tue, 10 Jan 2017 04:45:14 -0500 Received: from smtpout.microchip.com ([198.175.253.82]:39862 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933946AbdAJJpN (ORCPT ); Tue, 10 Jan 2017 04:45:13 -0500 Date: Tue, 10 Jan 2017 10:46:16 +0100 From: Christian Gromm To: Eric Salem CC: , , , Subject: Re: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted __le16 Message-ID: <20170110104616.69f75a70@muaddib> In-Reply-To: <7b68565e-61da-cfa4-4015-623657d2ae47@gmail.com> References: <7b68565e-61da-cfa4-4015-623657d2ae47@gmail.com> Organization: MCHP MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Jan 2017 21:25:56 -0600 Eric Salem wrote: > Fixed the following sparse warning: > > drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning: > cast to restricted __le16 > > by correcting the variable's type (also updated sizeof). > > Signed-off-by: Eric Salem Acked-by: Christian Gromm > --- > drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c > index d6db0bd..01e3a31 100644 > --- a/drivers/staging/most/hdm-usb/hdm_usb.c > +++ b/drivers/staging/most/hdm-usb/hdm_usb.c > @@ -145,7 +145,7 @@ static void wq_netinfo(struct work_struct *wq_obj); > static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf) > { > int retval; > - u16 *dma_buf = kzalloc(sizeof(u16), GFP_KERNEL); > + __le16 *dma_buf = kzalloc(sizeof(*dma_buf), GFP_KERNEL); > u8 req_type = USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE; > > if (!dma_buf) > @@ -154,7 +154,7 @@ static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf) > retval = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), > DRCI_READ_REQ, req_type, > 0x0000, > - reg, dma_buf, sizeof(u16), 5 * HZ); > + reg, dma_buf, sizeof(*dma_buf), 5 * HZ); > *buf = le16_to_cpu(*dma_buf); > kfree(dma_buf); >