From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQuC2-0006gI-9Z for qemu-devel@nongnu.org; Tue, 10 Jan 2017 06:02:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQuBy-0004Xr-BZ for qemu-devel@nongnu.org; Tue, 10 Jan 2017 06:02:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cQuBy-0004XQ-32 for qemu-devel@nongnu.org; Tue, 10 Jan 2017 06:02:14 -0500 Date: Tue, 10 Jan 2017 11:02:07 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20170110110207.GD2423@work-vm> References: <1483981368-9965-1-git-send-email-ashijeetacharya@gmail.com> <1483981368-9965-2-git-send-email-ashijeetacharya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483981368-9965-2-git-send-email-ashijeetacharya@gmail.com> Subject: Re: [Qemu-devel] [PATCH v4 1/4] migration: Add a new option to enable only-migratable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: jsnow@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, quintela@redhat.com, mst@redhat.com, marcandre.lureau@redhat.com, groug@kaod.org, aneesh.kumar@linux.vnet.ibm.com, peter.maydell@linaro.org, qemu-devel@nongnu.org * Ashijeet Acharya (ashijeetacharya@gmail.com) wrote: > Add a new option "--only-migratable" in qemu which will allow to add > only those devices which will not fail qemu after migration. Devices > set with the flag 'unmigratable' cannot be added when this option will > be used. > > Signed-off-by: Ashijeet Acharya > --- > include/migration/migration.h | 3 +++ > qemu-options.hx | 9 +++++++++ > vl.c | 4 ++++ > 3 files changed, 16 insertions(+) > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index c309d23..40b3697 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -38,6 +38,9 @@ > #define QEMU_VM_COMMAND 0x08 > #define QEMU_VM_SECTION_FOOTER 0x7e > > +/* for vl.c */ > +extern int only_migratable; > + > struct MigrationParams { > bool blk; > bool shared; > diff --git a/qemu-options.hx b/qemu-options.hx > index c534a2f..1e16ae8 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -3574,6 +3574,15 @@ be used to change settings (such as migration parameters) prior to issuing > the migrate_incoming to allow the migration to begin. > ETEXI > > +DEF("only-migratable", 0, QEMU_OPTION_only_migratable, \ > + "-only-migratable allow only migratable devices\n", QEMU_ARCH_ALL) > +STEXI > +@item -only-migratable > +@findex -only-migratable > +Only allow migratable devices. Devices will not be allowed to enter an > +unmigratable state. > +ETEXI > + > DEF("nodefaults", 0, QEMU_OPTION_nodefaults, \ > "-nodefaults don't create default devices\n", QEMU_ARCH_ALL) > STEXI > diff --git a/vl.c b/vl.c > index d77dd86..82bffb9 100644 > --- a/vl.c > +++ b/vl.c > @@ -180,6 +180,7 @@ bool boot_strict; > uint8_t *boot_splash_filedata; > size_t boot_splash_filedata_size; > uint8_t qemu_extra_params_fw[2]; > +int only_migratable = 0; /* turn it off unless user states otherwise */ QEMU coding style is to omit the =0 for globals. Other than that, Reviewed-by: Dr. David Alan Gilbert Dave > int icount_align_option; > > @@ -3914,6 +3915,9 @@ int main(int argc, char **argv, char **envp) > } > incoming = optarg; > break; > + case QEMU_OPTION_only_migratable: > + only_migratable = 1; > + break; > case QEMU_OPTION_nodefaults: > has_defaults = 0; > break; > -- > 2.6.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK