From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933725AbdAJOvN (ORCPT ); Tue, 10 Jan 2017 09:51:13 -0500 Received: from verein.lst.de ([213.95.11.211]:55633 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756639AbdAJOvI (ORCPT ); Tue, 10 Jan 2017 09:51:08 -0500 Date: Tue, 10 Jan 2017 15:51:06 +0100 From: Christoph Hellwig To: Nikita Yushchenko Cc: Will Deacon , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Simon Horman , Bjorn Helgaas , artemi.ivanov@cogentembedded.com, robin.murphy@arm.com, fkan@apm.com, Christoph Hellwig Subject: Re: [PATCH v2] arm64: do not set dma masks that device connection can't handle Message-ID: <20170110145106.GC27156@lst.de> References: <1483947002-16410-1-git-send-email-nikita.yoush@cogentembedded.com> <20170110115132.GD21598@arm.com> <07253eaa-5729-0f15-42b6-e8403f1f0412@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07253eaa-5729-0f15-42b6-e8403f1f0412@cogentembedded.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2017 at 03:47:25PM +0300, Nikita Yushchenko wrote: > With this direction, semantics of dma mask becomes even more > questionable. I'd say dma_mask is candidate for removal (or to move to > swiotlb's or iommu's local area) We need the dma mask so that the device can advertise what addresses the device supports. Many old devices only support 32-bit DMA addressing, and some less common ones just 24-bit or other weird ones. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Tue, 10 Jan 2017 15:51:06 +0100 Subject: [PATCH v2] arm64: do not set dma masks that device connection can't handle In-Reply-To: <07253eaa-5729-0f15-42b6-e8403f1f0412@cogentembedded.com> References: <1483947002-16410-1-git-send-email-nikita.yoush@cogentembedded.com> <20170110115132.GD21598@arm.com> <07253eaa-5729-0f15-42b6-e8403f1f0412@cogentembedded.com> Message-ID: <20170110145106.GC27156@lst.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 10, 2017 at 03:47:25PM +0300, Nikita Yushchenko wrote: > With this direction, semantics of dma mask becomes even more > questionable. I'd say dma_mask is candidate for removal (or to move to > swiotlb's or iommu's local area) We need the dma mask so that the device can advertise what addresses the device supports. Many old devices only support 32-bit DMA addressing, and some less common ones just 24-bit or other weird ones.