From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750859AbdAJUa0 (ORCPT ); Tue, 10 Jan 2017 15:30:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:58895 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdAJU2p (ORCPT ); Tue, 10 Jan 2017 15:28:45 -0500 Date: Tue, 10 Jan 2017 21:28:40 +0100 From: "Luis R. Rodriguez" To: Jessica Yu Cc: "Luis R. Rodriguez" , shuah@kernel.org, rusty@rustcorp.com.au, ebiederm@xmission.com, dmitry.torokhov@gmail.com, acme@redhat.com, corbet@lwn.net, martin.wilck@suse.com, mmarek@suse.com, pmladek@suse.com, hare@suse.com, rwright@hpe.com, jeffm@suse.com, DSterba@suse.com, fdmanana@suse.com, neilb@suse.com, linux@roeck-us.net, rgoldwyn@suse.com, subashab@codeaurora.org, xypron.glpk@gmx.de, keescook@chromium.org, atomlin@redhat.com, mbenes@suse.cz, paulmck@linux.vnet.ibm.com, dan.j.williams@intel.com, jpoimboe@redhat.com, davem@davemloft.net, mingo@redhat.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: kmod: provide wrappers for kmod_concurrent inc/dec Message-ID: <20170110202840.GJ13946@wotan.suse.de> References: <20161208184801.1689-1-mcgrof@kernel.org> <20161208194824.2532-1-mcgrof@kernel.org> <20161222050720.dlpdzf2vicyvv3od@jeyu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161222050720.dlpdzf2vicyvv3od@jeyu> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2016 at 09:07:21PM -0800, Jessica Yu wrote: > +++ Luis R. Rodriguez [08/12/16 11:48 -0800]: > > diff --git a/kernel/kmod.c b/kernel/kmod.c > > index cb6f7ca7b8a5..049d7eabda38 100644 > > --- a/kernel/kmod.c > > +++ b/kernel/kmod.c > > @@ -108,6 +111,20 @@ static int call_modprobe(char *module_name, int wait) > > return -ENOMEM; > > } > > > > +static int kmod_umh_threads_get(void) > > +{ > > + atomic_inc(&kmod_concurrent); > > + if (atomic_read(&kmod_concurrent) < max_modprobes) > > Should this not be <=? I think this only allows up to max_modprobes-1 concurrent threads. True, fixed! Luis