From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758363AbdAJXqw (ORCPT ); Tue, 10 Jan 2017 18:46:52 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:44671 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdAJXqv (ORCPT ); Tue, 10 Jan 2017 18:46:51 -0500 Date: Wed, 11 Jan 2017 00:46:39 +0100 From: Alexandre Belloni To: Martin Kaiser Cc: Lucas Stach , Shawn Guo , Sascha Hauer , Juergen Borleis , Fabio Estevam , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: Re: [PATCH 1/3 v4] rtc: imxdi: use the security violation interrupt Message-ID: <20170110234638.nm2xveibo4bpyiup@piout.net> References: <1479560614-19293-1-git-send-email-martin@kaiser.cx> <1483469390-7500-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483469390-7500-1-git-send-email-martin@kaiser.cx> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2017 at 19:49:50 +0100, Martin Kaiser wrote : > The DryIce chipset has a dedicated security violation interrupt that is > triggered for security violations (if configured to do so). According > to the publicly available imx258 reference manual, irq 56 is used for > this interrupt. > > If an irq number is provided for the security violation interrupt, > install the same handler that we're already using for the "normal" > interrupt. > > imxdi->irq is used only in the probe function, make it a local variable. > > Signed-off-by: Martin Kaiser > --- > v4: > - separate patches for imx25.dtsi and documentation of the new dt binding > > v3: > - add the device tree changes to this patch series > - install the same interrupt handler for normal and sec irq, rename > the handler function accordingly > - make imxdi->irq and imxdi->sec_irq local variables in the probe > function > > v2: > - make sec_irq optional to avoid breaking the Device Tree ABI > - removed the Device Tree bindings, I'll prepare a separate patch for them > > > drivers/rtc/rtc-imxdi.c | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) > Applied after fixing the multiline comment, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (mail.free-electrons.com. [62.4.15.54]) by gmr-mx.google.com with ESMTP id f193si274964wmg.2.2017.01.10.15.46.49 for ; Tue, 10 Jan 2017 15:46:49 -0800 (PST) Date: Wed, 11 Jan 2017 00:46:39 +0100 From: Alexandre Belloni To: Martin Kaiser Cc: Lucas Stach , Shawn Guo , Sascha Hauer , Juergen Borleis , Fabio Estevam , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [rtc-linux] Re: [PATCH 1/3 v4] rtc: imxdi: use the security violation interrupt Message-ID: <20170110234638.nm2xveibo4bpyiup@piout.net> References: <1479560614-19293-1-git-send-email-martin@kaiser.cx> <1483469390-7500-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1483469390-7500-1-git-send-email-martin@kaiser.cx> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 03/01/2017 at 19:49:50 +0100, Martin Kaiser wrote : > The DryIce chipset has a dedicated security violation interrupt that is > triggered for security violations (if configured to do so). According > to the publicly available imx258 reference manual, irq 56 is used for > this interrupt. > > If an irq number is provided for the security violation interrupt, > install the same handler that we're already using for the "normal" > interrupt. > > imxdi->irq is used only in the probe function, make it a local variable. > > Signed-off-by: Martin Kaiser > --- > v4: > - separate patches for imx25.dtsi and documentation of the new dt binding > > v3: > - add the device tree changes to this patch series > - install the same interrupt handler for normal and sec irq, rename > the handler function accordingly > - make imxdi->irq and imxdi->sec_irq local variables in the probe > function > > v2: > - make sec_irq optional to avoid breaking the Device Tree ABI > - removed the Device Tree bindings, I'll prepare a separate patch for them > > > drivers/rtc/rtc-imxdi.c | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) > Applied after fixing the multiline comment, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.