From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH 2/5] drm/i915/gvt: move intel iommu
 detection to intel_gvt_init()
Date: Wed, 11 Jan 2017 10:40:12 +0800
Message-ID: <20170111024012.em2kbfezonvbgunm@zhen-hp.sh.intel.com>
References: <20170110065252.1730-1-zhenyuw@linux.intel.com>
 <20170110065252.1730-3-zhenyuw@linux.intel.com>
 <587595F6.9080405@intel.com>
Reply-To: Zhenyu Wang <zhenyuw@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0263093175=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 50DE06E35B
 for <intel-gfx@lists.freedesktop.org>; Wed, 11 Jan 2017 02:44:49 +0000 (UTC)
In-Reply-To: <587595F6.9080405@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jike Song <jike.song@intel.com>
Cc: intel-gfx@lists.freedesktop.org, igvt-g-dev@lists.01.org
List-Id: intel-gfx@lists.freedesktop.org


--===============0263093175==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="s53fp6dqgdewianj"
Content-Disposition: inline


--s53fp6dqgdewianj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2017.01.11 10:18:30 +0800, Jike Song wrote:
> On 01/10/2017 02:52 PM, Zhenyu Wang wrote:
> > Prepare to remove detect_host() hook. Move intel iommu detection early
> > in intel_gvt_init().
> >=20
> > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/gvt.c   | 7 +++++++
> >  drivers/gpu/drm/i915/gvt/kvmgt.c | 6 ------
> >  2 files changed, 7 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/=
gvt.c
> > index 35264a991776..7a7886644acf 100644
> > --- a/drivers/gpu/drm/i915/gvt/gvt.c
> > +++ b/drivers/gpu/drm/i915/gvt/gvt.c
> > @@ -73,6 +73,13 @@ int intel_gvt_init_host(void)
> >  	if (intel_gvt_host.initialized)
> >  		return 0;
> > =20
> > +#ifdef CONFIG_INTEL_IOMMU
> > +	if (intel_iommu_gfx_mapped) {
> > +		gvt_err("Hardware IOMMU compatibility not yet supported, try to boot=
 with intel_iommu=3Digfx_off\n");
> > +		return -ENODEV;
> > +	}
> > +#endif
> > +
>=20
> Hi Zhenyu,
>=20
> Per my understanding, the "intel_iommu=3D" parameter acts only on native =
(think about XenGT),
> so it's better to keep it somewhere in kvmgt.c, maybe kvmgt_init()?
>=20

hmm, I think it's just a limit for current gvt device model but not related=
 to hypervisor,
and it would bail out to disable gvt only. Anyway we'll fix it soon so not =
worry much for that.

--=20
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

--s53fp6dqgdewianj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAlh1mwwACgkQsQQaM014GCdBAgCfVPqicb6vPnEnaC2xF9rWyjxU
NcoAnjo1ich8z6t4KoX4PY1hEZXVty5B
=P/pL
-----END PGP SIGNATURE-----

--s53fp6dqgdewianj--

--===============0263093175==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==

--===============0263093175==--