All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
	Brian Foster <bfoster@redhat.com>, Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH v8 3/6] xfs: add missing include dependencies to xfs_dir2.h
Date: Wed, 11 Jan 2017 09:38:18 +0100	[thread overview]
Message-ID: <20170111083818.GA6744@lst.de> (raw)
In-Reply-To: <1484123050-11064-4-git-send-email-amir73il@gmail.com>

On Wed, Jan 11, 2017 at 10:24:07AM +0200, Amir Goldstein wrote:
> xfs_dir2.h dereferences some data types in inline functions
> and fails to include those type definitions, e.g.:
> xfs_dir2_data_aoff_t, struct xfs_da_geometry.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

I'd normally fold this into the patch that actually exposes the
dependency.  But except for that it looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2017-01-11  8:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  8:24 [PATCH v8 0/6] xfs: fixes for malformed on-disk i_mode Amir Goldstein
2017-01-11  8:24 ` [PATCH v8 1/6] xfs: make the ASSERT() condition likely Amir Goldstein
2017-01-13  7:25   ` Christoph Hellwig
2017-01-18 20:57     ` Darrick J. Wong
2017-01-11  8:24 ` [PATCH v8 2/6] xfs: sanity check directory inode di_size Amir Goldstein
2017-01-14  6:28   ` Darrick J. Wong
2017-01-11  8:24 ` [PATCH v8 3/6] xfs: add missing include dependencies to xfs_dir2.h Amir Goldstein
2017-01-11  8:38   ` Christoph Hellwig [this message]
2017-01-11  8:24 ` [PATCH v8 4/6] xfs: replace xfs_mode_to_ftype table with switch statement Amir Goldstein
2017-01-11  8:38   ` Christoph Hellwig
2017-01-11  8:24 ` [PATCH v8 5/6] xfs: sanity check inode mode when creating new dentry Amir Goldstein
2017-01-11  8:42   ` Christoph Hellwig
2017-01-11  8:24 ` [PATCH v8 6/6] xfs: sanity check inode di_mode Amir Goldstein
2017-01-11  8:42   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170111083818.GA6744@lst.de \
    --to=hch@lst.de \
    --cc=amir73il@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.