From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936638AbdAKIs4 (ORCPT ); Wed, 11 Jan 2017 03:48:56 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34297 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936614AbdAKIsy (ORCPT ); Wed, 11 Jan 2017 03:48:54 -0500 Date: Wed, 11 Jan 2017 17:48:51 +0900 From: Stafford Horne To: Darren Hart Cc: Shuah Khan , linux-kernel@vger.kernel.org, dvhart@linux.intel.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests/futex: Fix makefile dependencies Message-ID: <20170111084851.GB25986@lianli.shorne-pla.net> References: <20170106041839.20363-1-shorne@gmail.com> <20170110221042.GD4371@f23x64.localdomain> <20170110221718.GE4371@f23x64.localdomain> <20170111043719.GA25986@lianli.shorne-pla.net> <20170111080755.GA36664@f23x64.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111080755.GA36664@f23x64.localdomain> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 12:07:55AM -0800, Darren Hart wrote: > On Wed, Jan 11, 2017 at 01:37:19PM +0900, Stafford Horne wrote: > > On Tue, Jan 10, 2017 at 02:17:18PM -0800, Darren Hart wrote: > > > On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote: > > > > On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote: > > > > > I am working on doing selftests for openrisc and found issues with the > > > > > futex test is not building after changes to the tests source. > > > > > > > > > > This issue is that the TARGETS variable used in the futex Makefile is > > > > > also used by the selftests Makefile, so when building from toplevel the > > > > > TARGETS variable is clobbered and nothing gets built. Changed the > > > > > variable name to get around that. > > > > > > > > > > Also, the futex makefile did not contain dependencies for all headers, > > > > > so if we make changes to logging.h rebuild will not happen. Add headers > > > > > to fix it up. > > > > > > > > > > Signed-off-by: Stafford Horne > > > > > > > > Thanks for catching this and the fix. > > > > > > > > +Shuah Khan > > > > > > > > Note: This appears also to be a problem for intel_pstate/Makefile > > > > > > Or, it would be if intel_pstate was listed in selftests/Makefile :-) > > > > Right, thanks for having a look. I actually have a small patch to also > > add to logging.h. If you have not already fixed the > > intel_pstate test I'll send them all together. > > Please do, thanks! Hello, Actually I just had a look at Shuah's linux-kselftest repo on kernel.org. It looks like Bamvor Jian has actually fixed a lot of these issues on the next branch. I will see what is missing if anything. -Stafford