From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbdAKShT (ORCPT ); Wed, 11 Jan 2017 13:37:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56800 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbdAKShR (ORCPT ); Wed, 11 Jan 2017 13:37:17 -0500 Date: Wed, 11 Jan 2017 19:37:14 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed Message-ID: <20170111183714.GB29004@krava> References: <20170110010225.24870-1-andi@firstfloor.org> <20170110010225.24870-2-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110010225.24870-2-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 11 Jan 2017 18:37:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 05:02:21PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add autoprobing for the xed disassembler library. > > Can be downloaded from https://github.com/intelxed/xed > > v2: Hide. Require XED=1 to enable. Add XED_DIR > Signed-off-by: Andi Kleen > --- > tools/build/Makefile.feature | 8 +++++--- > tools/build/feature/Makefile | 8 ++++++-- > tools/build/feature/test-all.c | 5 +++++ > tools/build/feature/test-xed.c | 9 +++++++++ > tools/perf/Makefile.config | 16 ++++++++++++++++ > tools/perf/Makefile.perf | 3 +++ > 6 files changed, 44 insertions(+), 5 deletions(-) > create mode 100644 tools/build/feature/test-xed.c > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > index e3fb5ecbdcb6..971a9ef87ca6 100644 > --- a/tools/build/Makefile.feature > +++ b/tools/build/Makefile.feature > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC := \ > lzma \ > get_cpuid \ > bpf \ > - sdt > + sdt \ looks like you forgot to add xed in here? why the '\' ? anyway, please add it in here so it's visible under make VF=1 jirka