From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbdALVeE (ORCPT ); Thu, 12 Jan 2017 16:34:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbdALVeC (ORCPT ); Thu, 12 Jan 2017 16:34:02 -0500 Date: Fri, 13 Jan 2017 05:33:54 +0800 From: Dave Young To: Ard Biesheuvel Cc: Matt Fleming , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Nicolai Stange , Ingo Molnar , Thomas Gleixner , "hpa@zytor.com" , Dan Williams , Mika =?iso-8859-1?Q?Penttil=E4?= , bhsharma@redhat.com Subject: Re: [PATCH 2/4] efi/x86: move efi bgrt init code to early init code Message-ID: <20170112213354.GC2709@dhcp-128-65.nay.redhat.com> References: <20170112094118.815108042@redhat.com> <20170112094214.909117564@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 12 Jan 2017 21:34:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/17 at 04:20pm, Ard Biesheuvel wrote: > On 12 January 2017 at 09:41, Dave Young wrote: > > Before invoking the arch specific handler, efi_mem_reserve() reserves > > the given memory region through memblock. > > > > efi_bgrt_init will call efi_mem_reserve after mm_init(), at that time > > memblock is dead and it should not be used any more. > > > > efi bgrt code depend on acpi intialization to get the bgrt acpi table, > > moving bgrt parsing to acpi early boot code can make sure efi_mem_reserve > > in efi bgrt code still use memblock safely. > > > > Signed-off-by: Dave Young > > I know this is probably out of scope for you, but since we're moving > things around, any chance we could do so in a manner that will enable > BGRT support for arm64/ACPI? Happy to test/collaborate on this. > I'm happy to do so, Bhupesh Sharma said he had some investigation on that already, I would like to ask him to help on that. Already cced him.. Thanks Dave From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH 2/4] efi/x86: move efi bgrt init code to early init code Date: Fri, 13 Jan 2017 05:33:54 +0800 Message-ID: <20170112213354.GC2709@dhcp-128-65.nay.redhat.com> References: <20170112094118.815108042@redhat.com> <20170112094214.909117564@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: Matt Fleming , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Nicolai Stange , Ingo Molnar , Thomas Gleixner , "hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org" , Dan Williams , Mika =?iso-8859-1?Q?Penttil=E4?= , bhsharma-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 01/12/17 at 04:20pm, Ard Biesheuvel wrote: > On 12 January 2017 at 09:41, Dave Young wrote: > > Before invoking the arch specific handler, efi_mem_reserve() reserves > > the given memory region through memblock. > > > > efi_bgrt_init will call efi_mem_reserve after mm_init(), at that time > > memblock is dead and it should not be used any more. > > > > efi bgrt code depend on acpi intialization to get the bgrt acpi table, > > moving bgrt parsing to acpi early boot code can make sure efi_mem_reserve > > in efi bgrt code still use memblock safely. > > > > Signed-off-by: Dave Young > > I know this is probably out of scope for you, but since we're moving > things around, any chance we could do so in a manner that will enable > BGRT support for arm64/ACPI? Happy to test/collaborate on this. > I'm happy to do so, Bhupesh Sharma said he had some investigation on that already, I would like to ask him to help on that. Already cced him.. Thanks Dave