All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Masahiko Iwamoto <iwamoto@allied-telesis.co.jp>,
	Jagan Teki <jagan@openedev.com>, Marek Vasut <marex@denx.de>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: linux-mtd@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] mtd: spi-nor: don't claim mr25h40 to be JEDEC compatible
Date: Fri, 13 Jan 2017 11:02:44 +0100	[thread overview]
Message-ID: <20170113100244.zgg6g4yuhngpumf4@pengutronix.de> (raw)
In-Reply-To: <20170113093509.25737-1-u.kleine-koenig@pengutronix.de>

On Fri, Jan 13, 2017 at 10:35:09AM +0100, Uwe Kleine-König wrote:
> Commit edd0c8f4932d ("mtd: spi-nor: Add support for mr25h40") made it
> possible to use a mr25h40 by writing
> 
> 	compatible = "mr25h40", "jedec,spi-nor";
> 
> in a device tree. This chip however isn't JEDEC compatible however, so
> change the chip string and add a compatible entry to bless
> 
> 	compatible = "mr25h40-nonjedec";
> 
> as the right way.
> 
> Fixes: edd0c8f4932d ("mtd: spi-nor: Add support for mr25h40")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---

I intended to write a note here, but sent out the mail before :w :-|

I wrote:

I wonder a bit about the "-nonjedec" suffix and only added it for
consistency. AFAICT all mr25h40 don't support JEDEC, so "-nonjedec"
doesn't really qualify as hardware description. Thoughts?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2017-01-13 10:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  9:35 [PATCH] mtd: spi-nor: don't claim mr25h40 to be JEDEC compatible Uwe Kleine-König
2017-01-13  9:51 ` Rafał Miłecki
2017-01-13  9:58   ` Uwe Kleine-König
2017-01-13 14:40     ` Rafał Miłecki
2017-01-13 10:02 ` Uwe Kleine-König [this message]
2017-01-13 14:30 ` Cyrille Pitchen
2017-01-13 14:49   ` Cyrille Pitchen
     [not found] ` <20170113093509.25737-1-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-01-13 18:42   ` Geert Uytterhoeven
2017-01-13 18:42     ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdXJi9hJrY0ZV37gejp2XC6fkuLF7i7BqX4CUYTB7j_q1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-13 19:42       ` Mark Rutland
2017-01-13 19:42         ` Mark Rutland
2017-01-16 10:40         ` Uwe Kleine-König
2017-01-16 10:40           ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170113100244.zgg6g4yuhngpumf4@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=cyrille.pitchen@atmel.com \
    --cc=iwamoto@allied-telesis.co.jp \
    --cc=jagan@openedev.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.