From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Stephan Müller" <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: aead AF_ALG - overhaul memory management
Date: Fri, 13 Jan 2017 19:03:35 +0800 [thread overview]
Message-ID: <20170113110335.GA23617@gondor.apana.org.au> (raw)
In-Reply-To: <1588177.ehMkkoOMrj@positron.chronox.de>
On Fri, Jan 13, 2017 at 11:49:05AM +0100, Stephan Müller wrote:
>
> According to the man page of lio_listio(3) the provided AIO operations are
> executed in an unspecified order. I would infer from that statement that even
> if an order of write / read / write / read is defined by the caller, this
> order may not be followed by the kernel. Thus we would need to consider the
> case that in the end, algif has to process the order of write / write / read /
> read or any other order.
Well if ordering is not guaranteed that I don't see how your code
can work either. Or am I missing something?
> Besides, the crashes I reported for the current AIO implementation in
> algif_aead and algif_skcipher are always triggered when invoking an aio_read
> with two or more IOCBs. The most important aspect I want to cover with the
> patch set is to stop crashing the kernel.
Please stop adding new features and just fix the existing crash.
Once we have that covered and backported to stable then we can
start addressing new features.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-01-13 11:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 17:13 [PATCH 0/2] crypto: AF_ALG memory management fix Stephan Müller
2016-12-25 17:15 ` [PATCH 1/2] crypto: aead AF_ALG - overhaul memory management Stephan Müller
2017-01-12 15:51 ` Herbert Xu
2017-01-12 15:56 ` Stephan Müller
2017-01-12 16:05 ` Stephan Müller
2017-01-12 16:07 ` Herbert Xu
2017-01-12 16:10 ` Stephan Müller
2017-01-12 16:17 ` Herbert Xu
2017-01-12 16:19 ` Stephan Müller
2017-01-13 10:21 ` Herbert Xu
2017-01-13 10:49 ` Stephan Müller
2017-01-13 11:03 ` Herbert Xu [this message]
2017-01-13 11:10 ` Stephan Müller
2017-01-13 11:12 ` Herbert Xu
2017-01-13 11:16 ` Stephan Müller
2017-01-13 11:25 ` Herbert Xu
2017-01-13 11:51 ` Stephan Müller
2017-01-16 13:41 ` Stephan Müller
2016-12-25 17:15 ` [PATCH 2/2] crypto: skcipher " Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113110335.GA23617@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.