From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbdAMXFx (ORCPT ); Fri, 13 Jan 2017 18:05:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41660 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdAMXFv (ORCPT ); Fri, 13 Jan 2017 18:05:51 -0500 Date: Fri, 13 Jan 2017 16:04:56 -0700 From: Alex Williamson To: Eric Auger Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com Subject: Re: [PATCH v8 16/18] vfio/type1: Allow transparent MSI IOVA allocation Message-ID: <20170113160456.61a744d8@t450s.home> In-Reply-To: <1484127714-3263-17-git-send-email-eric.auger@redhat.com> References: <1484127714-3263-1-git-send-email-eric.auger@redhat.com> <1484127714-3263-17-git-send-email-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 13 Jan 2017 23:05:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jan 2017 09:41:52 +0000 Eric Auger wrote: > When attaching a group to the container, check the group's > reserved regions and test whether the IOMMU translates MSI > transactions. If yes, we initialize an IOVA allocator through > the iommu_get_msi_cookie API. This will allow the MSI IOVAs > to be transparently allocated on MSI controller's compose(). > > Signed-off-by: Eric Auger Acked-by: Alex Williamson > --- > > v3 -> v4: > - test region's type: IOMMU_RESV_MSI > - restructure the code to prepare for safety assessment > - reword title > --- > drivers/vfio/vfio_iommu_type1.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 9266271..5651faf 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > > #define DRIVER_VERSION "0.2" > #define DRIVER_AUTHOR "Alex Williamson " > @@ -1181,6 +1182,28 @@ static struct vfio_group *find_iommu_group(struct vfio_domain *domain, > return NULL; > } > > +static bool vfio_iommu_has_resv_msi(struct iommu_group *group, > + phys_addr_t *base) > +{ > + struct list_head group_resv_regions; > + struct iommu_resv_region *region, *next; > + bool ret = false; > + > + INIT_LIST_HEAD(&group_resv_regions); > + iommu_get_group_resv_regions(group, &group_resv_regions); > + list_for_each_entry(region, &group_resv_regions, list) { > + if (region->type & IOMMU_RESV_MSI) { > + *base = region->start; > + ret = true; > + goto out; > + } > + } > +out: > + list_for_each_entry_safe(region, next, &group_resv_regions, list) > + kfree(region); > + return ret; > +} > + > static int vfio_iommu_type1_attach_group(void *iommu_data, > struct iommu_group *iommu_group) > { > @@ -1189,6 +1212,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > struct vfio_domain *domain, *d; > struct bus_type *bus = NULL, *mdev_bus; > int ret; > + bool resv_msi; > + phys_addr_t resv_msi_base; > > mutex_lock(&iommu->lock); > > @@ -1258,6 +1283,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > if (ret) > goto out_domain; > > + resv_msi = vfio_iommu_has_resv_msi(iommu_group, &resv_msi_base); > + > INIT_LIST_HEAD(&domain->group_list); > list_add(&group->next, &domain->group_list); > > @@ -1304,6 +1331,9 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > if (ret) > goto out_detach; > > + if (resv_msi && iommu_get_msi_cookie(domain->domain, resv_msi_base)) > + goto out_detach; > + > list_add(&domain->next, &iommu->domain_list); > > mutex_unlock(&iommu->lock); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v8 16/18] vfio/type1: Allow transparent MSI IOVA allocation Date: Fri, 13 Jan 2017 16:04:56 -0700 Message-ID: <20170113160456.61a744d8@t450s.home> References: <1484127714-3263-1-git-send-email-eric.auger@redhat.com> <1484127714-3263-17-git-send-email-eric.auger@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, punit.agrawal-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Eric Auger Return-path: In-Reply-To: <1484127714-3263-17-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: kvm.vger.kernel.org On Wed, 11 Jan 2017 09:41:52 +0000 Eric Auger wrote: > When attaching a group to the container, check the group's > reserved regions and test whether the IOMMU translates MSI > transactions. If yes, we initialize an IOVA allocator through > the iommu_get_msi_cookie API. This will allow the MSI IOVAs > to be transparently allocated on MSI controller's compose(). > > Signed-off-by: Eric Auger Acked-by: Alex Williamson > --- > > v3 -> v4: > - test region's type: IOMMU_RESV_MSI > - restructure the code to prepare for safety assessment > - reword title > --- > drivers/vfio/vfio_iommu_type1.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 9266271..5651faf 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > > #define DRIVER_VERSION "0.2" > #define DRIVER_AUTHOR "Alex Williamson " > @@ -1181,6 +1182,28 @@ static struct vfio_group *find_iommu_group(struct vfio_domain *domain, > return NULL; > } > > +static bool vfio_iommu_has_resv_msi(struct iommu_group *group, > + phys_addr_t *base) > +{ > + struct list_head group_resv_regions; > + struct iommu_resv_region *region, *next; > + bool ret = false; > + > + INIT_LIST_HEAD(&group_resv_regions); > + iommu_get_group_resv_regions(group, &group_resv_regions); > + list_for_each_entry(region, &group_resv_regions, list) { > + if (region->type & IOMMU_RESV_MSI) { > + *base = region->start; > + ret = true; > + goto out; > + } > + } > +out: > + list_for_each_entry_safe(region, next, &group_resv_regions, list) > + kfree(region); > + return ret; > +} > + > static int vfio_iommu_type1_attach_group(void *iommu_data, > struct iommu_group *iommu_group) > { > @@ -1189,6 +1212,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > struct vfio_domain *domain, *d; > struct bus_type *bus = NULL, *mdev_bus; > int ret; > + bool resv_msi; > + phys_addr_t resv_msi_base; > > mutex_lock(&iommu->lock); > > @@ -1258,6 +1283,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > if (ret) > goto out_domain; > > + resv_msi = vfio_iommu_has_resv_msi(iommu_group, &resv_msi_base); > + > INIT_LIST_HEAD(&domain->group_list); > list_add(&group->next, &domain->group_list); > > @@ -1304,6 +1331,9 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > if (ret) > goto out_detach; > > + if (resv_msi && iommu_get_msi_cookie(domain->domain, resv_msi_base)) > + goto out_detach; > + > list_add(&domain->next, &iommu->domain_list); > > mutex_unlock(&iommu->lock); From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.williamson@redhat.com (Alex Williamson) Date: Fri, 13 Jan 2017 16:04:56 -0700 Subject: [PATCH v8 16/18] vfio/type1: Allow transparent MSI IOVA allocation In-Reply-To: <1484127714-3263-17-git-send-email-eric.auger@redhat.com> References: <1484127714-3263-1-git-send-email-eric.auger@redhat.com> <1484127714-3263-17-git-send-email-eric.auger@redhat.com> Message-ID: <20170113160456.61a744d8@t450s.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 11 Jan 2017 09:41:52 +0000 Eric Auger wrote: > When attaching a group to the container, check the group's > reserved regions and test whether the IOMMU translates MSI > transactions. If yes, we initialize an IOVA allocator through > the iommu_get_msi_cookie API. This will allow the MSI IOVAs > to be transparently allocated on MSI controller's compose(). > > Signed-off-by: Eric Auger Acked-by: Alex Williamson > --- > > v3 -> v4: > - test region's type: IOMMU_RESV_MSI > - restructure the code to prepare for safety assessment > - reword title > --- > drivers/vfio/vfio_iommu_type1.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 9266271..5651faf 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > > #define DRIVER_VERSION "0.2" > #define DRIVER_AUTHOR "Alex Williamson " > @@ -1181,6 +1182,28 @@ static struct vfio_group *find_iommu_group(struct vfio_domain *domain, > return NULL; > } > > +static bool vfio_iommu_has_resv_msi(struct iommu_group *group, > + phys_addr_t *base) > +{ > + struct list_head group_resv_regions; > + struct iommu_resv_region *region, *next; > + bool ret = false; > + > + INIT_LIST_HEAD(&group_resv_regions); > + iommu_get_group_resv_regions(group, &group_resv_regions); > + list_for_each_entry(region, &group_resv_regions, list) { > + if (region->type & IOMMU_RESV_MSI) { > + *base = region->start; > + ret = true; > + goto out; > + } > + } > +out: > + list_for_each_entry_safe(region, next, &group_resv_regions, list) > + kfree(region); > + return ret; > +} > + > static int vfio_iommu_type1_attach_group(void *iommu_data, > struct iommu_group *iommu_group) > { > @@ -1189,6 +1212,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > struct vfio_domain *domain, *d; > struct bus_type *bus = NULL, *mdev_bus; > int ret; > + bool resv_msi; > + phys_addr_t resv_msi_base; > > mutex_lock(&iommu->lock); > > @@ -1258,6 +1283,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > if (ret) > goto out_domain; > > + resv_msi = vfio_iommu_has_resv_msi(iommu_group, &resv_msi_base); > + > INIT_LIST_HEAD(&domain->group_list); > list_add(&group->next, &domain->group_list); > > @@ -1304,6 +1331,9 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > if (ret) > goto out_detach; > > + if (resv_msi && iommu_get_msi_cookie(domain->domain, resv_msi_base)) > + goto out_detach; > + > list_add(&domain->next, &iommu->domain_list); > > mutex_unlock(&iommu->lock);