From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbdAMPVn (ORCPT ); Fri, 13 Jan 2017 10:21:43 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43478 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbdAMPVY (ORCPT ); Fri, 13 Jan 2017 10:21:24 -0500 Date: Fri, 13 Jan 2017 16:21:04 +0100 From: Boris Brezillon To: Matthias Brugger Cc: Guochun Mao , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Rob Herring , Mark Rutland , Russell King , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Message-ID: <20170113162104.4d2a624c@bbrezillon> In-Reply-To: References: <1484291609-20195-1-git-send-email-guochun.mao@mediatek.com> <1484291609-20195-3-git-send-email-guochun.mao@mediatek.com> <20170113151747.6bc85245@bbrezillon> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Jan 2017 16:12:20 +0100 Matthias Brugger wrote: > On 13/01/17 15:17, Boris Brezillon wrote: > > On Fri, 13 Jan 2017 15:13:29 +0800 > > Guochun Mao wrote: > > > >> Add Mediatek nor flash node. > >> > >> Signed-off-by: Guochun Mao > >> --- > >> arch/arm/boot/dts/mt2701-evb.dts | 25 +++++++++++++++++++++++++ > >> arch/arm/boot/dts/mt2701.dtsi | 12 ++++++++++++ > >> 2 files changed, 37 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > >> index 082ca88..85e5ae8 100644 > >> --- a/arch/arm/boot/dts/mt2701-evb.dts > >> +++ b/arch/arm/boot/dts/mt2701-evb.dts > >> @@ -24,6 +24,31 @@ > >> }; > >> }; > >> > >> +&nor_flash { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&nor_pins_default>; > >> + status = "okay"; > >> + flash@0 { > >> + compatible = "jedec,spi-nor"; > >> + reg = <0>; > >> + }; > >> +}; > >> + > >> +&pio { > >> + nor_pins_default: nor { > >> + pins1 { > >> + pinmux = , > >> + , > >> + , > >> + , > >> + , > >> + ; > >> + drive-strength = ; > >> + bias-pull-up; > >> + }; > >> + }; > >> +}; > >> + > >> &uart0 { > >> status = "okay"; > >> }; > >> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > >> index bdf8954..1eefce4 100644 > >> --- a/arch/arm/boot/dts/mt2701.dtsi > >> +++ b/arch/arm/boot/dts/mt2701.dtsi > >> @@ -227,6 +227,18 @@ > >> status = "disabled"; > >> }; > >> > >> + nor_flash: spi@11014000 { > >> + compatible = "mediatek,mt2701-nor", > >> + "mediatek,mt8173-nor"; > > > > Why define both here? Is "mediatek,mt8173-nor" really providing a > > subset of the features supported by "mediatek,mt2701-nor"? > > > > I think even if the ip block is the same, we should provide both > bindings, just in case in the future we find out that mt2701 has some > hidden bug, feature or bug-feature. This way even if we update the > driver, we stay compatible with older device tree blobs in the wild. I'm fine with this approach, but in this case, defining both is wrong. > > We can drop the mt2701-nor in the bindings definition if you want. Yes, please. > > Regards, > Matthias > > >> + reg = <0 0x11014000 0 0xe0>; > >> + clocks = <&pericfg CLK_PERI_FLASH>, > >> + <&topckgen CLK_TOP_FLASH_SEL>; > >> + clock-names = "spi", "sf"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + status = "disabled"; > >> + }; > >> + > >> mmsys: syscon@14000000 { > >> compatible = "mediatek,mt2701-mmsys", "syscon"; > >> reg = <0 0x14000000 0 0x1000>; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Fri, 13 Jan 2017 16:21:04 +0100 Subject: [PATCH v1 2/2] arm: dts: mt2701: add nor flash node In-Reply-To: References: <1484291609-20195-1-git-send-email-guochun.mao@mediatek.com> <1484291609-20195-3-git-send-email-guochun.mao@mediatek.com> <20170113151747.6bc85245@bbrezillon> Message-ID: <20170113162104.4d2a624c@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 13 Jan 2017 16:12:20 +0100 Matthias Brugger wrote: > On 13/01/17 15:17, Boris Brezillon wrote: > > On Fri, 13 Jan 2017 15:13:29 +0800 > > Guochun Mao wrote: > > > >> Add Mediatek nor flash node. > >> > >> Signed-off-by: Guochun Mao > >> --- > >> arch/arm/boot/dts/mt2701-evb.dts | 25 +++++++++++++++++++++++++ > >> arch/arm/boot/dts/mt2701.dtsi | 12 ++++++++++++ > >> 2 files changed, 37 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > >> index 082ca88..85e5ae8 100644 > >> --- a/arch/arm/boot/dts/mt2701-evb.dts > >> +++ b/arch/arm/boot/dts/mt2701-evb.dts > >> @@ -24,6 +24,31 @@ > >> }; > >> }; > >> > >> +&nor_flash { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&nor_pins_default>; > >> + status = "okay"; > >> + flash at 0 { > >> + compatible = "jedec,spi-nor"; > >> + reg = <0>; > >> + }; > >> +}; > >> + > >> +&pio { > >> + nor_pins_default: nor { > >> + pins1 { > >> + pinmux = , > >> + , > >> + , > >> + , > >> + , > >> + ; > >> + drive-strength = ; > >> + bias-pull-up; > >> + }; > >> + }; > >> +}; > >> + > >> &uart0 { > >> status = "okay"; > >> }; > >> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > >> index bdf8954..1eefce4 100644 > >> --- a/arch/arm/boot/dts/mt2701.dtsi > >> +++ b/arch/arm/boot/dts/mt2701.dtsi > >> @@ -227,6 +227,18 @@ > >> status = "disabled"; > >> }; > >> > >> + nor_flash: spi at 11014000 { > >> + compatible = "mediatek,mt2701-nor", > >> + "mediatek,mt8173-nor"; > > > > Why define both here? Is "mediatek,mt8173-nor" really providing a > > subset of the features supported by "mediatek,mt2701-nor"? > > > > I think even if the ip block is the same, we should provide both > bindings, just in case in the future we find out that mt2701 has some > hidden bug, feature or bug-feature. This way even if we update the > driver, we stay compatible with older device tree blobs in the wild. I'm fine with this approach, but in this case, defining both is wrong. > > We can drop the mt2701-nor in the bindings definition if you want. Yes, please. > > Regards, > Matthias > > >> + reg = <0 0x11014000 0 0xe0>; > >> + clocks = <&pericfg CLK_PERI_FLASH>, > >> + <&topckgen CLK_TOP_FLASH_SEL>; > >> + clock-names = "spi", "sf"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + status = "disabled"; > >> + }; > >> + > >> mmsys: syscon at 14000000 { > >> compatible = "mediatek,mt2701-mmsys", "syscon"; > >> reg = <0 0x14000000 0 0x1000>; > >