From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751124AbdAMQv2 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 11:51:28 -0500
Received: from pandora.armlinux.org.uk ([78.32.30.218]:48550 "EHLO
        pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750793AbdAMQv1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 11:51:27 -0500
Date: Fri, 13 Jan 2017 16:50:21 +0000
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Bhumika Goyal <bhumirks@gmail.com>, julia.lawall@lip6.fr,
        tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: dove: constify reset_control_ops structures
Message-ID: <20170113165020.GU14217@n2100.armlinux.org.uk>
References: <1483979690-7619-1-git-send-email-bhumirks@gmail.com>
 <87eg069asl.fsf@free-electrons.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87eg069asl.fsf@free-electrons.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
> Hi Sebastian,
>  
>  On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
> 
> > Declare reset_control_ops as const as they are only stored in the ops
> > field of a reset_controller_dev structure. This field is of type const
> > struct reset_control_ops *, so reset_control_ops structures having this
> > property can be declared as const.
> > Done using Coccinelle:
> >
> > @r1 disable optional_qualifier@
> > identifier i;
> > position p;
> > @@
> > static struct reset_control_ops i@p={...};
> >
> > @ok1@
> > identifier r1.i;
> > position p;
> > struct reset_controller_dev x;
> > @@
> > x.ops=&i@p;
> >
> > @bad@
> > position p!={r1.p,ok1.p};
> > identifier r1.i;
> > @@
> > i@p
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r1.i;
> > @@
> > +const
> > struct reset_control_ops i;
> >
> > File size before: drivers/soc/dove/pmu.o
> >    text	   data	    bss	    dec	    hex	filename
> >    2447	    112	     16	   2575	    a0f	drivers/soc/dove/pmu.o
> >
> > File size after: drivers/soc/dove/pmu.o
> >    text	   data	    bss	    dec	    hex	filename
> >    2479	     80	     16	   2575	    a0f	drivers/soc/dove/pmu.o
> >
> 
> If you agree with this patch I will apply it on mvebu/soc.

You really ought to be asking me...

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.