From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Gross <andy.gross@linaro.org>
Subject: Re: [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()
Date: Fri, 13 Jan 2017 11:12:41 -0600
Message-ID: <20170113171241.GH5710@hector.attlocal.net>
References: <1480361317-9937-1-git-send-email-jcrouse@codeaurora.org>
 <1480361317-9937-11-git-send-email-jcrouse@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-oi0-f43.google.com ([209.85.218.43]:35753 "EHLO
        mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751009AbdAMRMn (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Fri, 13 Jan 2017 12:12:43 -0500
Received: by mail-oi0-f43.google.com with SMTP id j15so63648290oih.2
        for <linux-arm-msm@vger.kernel.org>; Fri, 13 Jan 2017 09:12:43 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1480361317-9937-11-git-send-email-jcrouse@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org

On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote:
> Add an interface to trigger the remote processor to reinitialize the GPU
> zap shader on power-up.
> 
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---

<snip>

> +int __qcom_scm_gpu_zap_resume(struct device *dev)
> +{
> +	struct qcom_scm_desc desc = {0};
> +	struct arm_smccc_res res;
> +	int ret;
> +
> +	desc.args[0] = 0;
> +	desc.args[1] = 13;

Can I get a define here for these two?  Or maybe a comment on what these values
are?

> +	desc.arginfo = QCOM_SCM_ARGS(2);
> +
> +	ret = qcom_scm_call(dev, QCOM_SCM_SVC_BOOT, 0x0A, &desc, &res);

Same with the 0xA.  We usually throw a #define in for the command definitions.

Otherwise this all looks fine.  If you can get back to me with either the values
or a new patch I can include this in the next pull.

Thanks.

Andy