From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Date: Fri, 13 Jan 2017 09:15:37 -0800 Message-ID: <20170113171537.GZ2630@atomide.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1484216786-17292-37-git-send-email-kishon@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com List-Id: linux-arm-msm@vger.kernel.org * Kishon Vijay Abraham I [170112 02:35]: > The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > in RC mode. However in EP mode, the host system is not able to access the > MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. I guess ideally in the long run we would set this dynamically based on the selected mode, right? Regards, Tony > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c > index 6c67965..67ebff8 100644 > --- a/arch/arm/mach-omap2/clockdomains7xx_data.c > +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c > @@ -524,7 +524,7 @@ > .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, > .wkdep_srcs = pcie_wkup_sleep_deps, > .sleepdep_srcs = pcie_wkup_sleep_deps, > - .flags = CLKDM_CAN_HWSUP_SWSUP, > + .flags = CLKDM_CAN_SWSUP, > }; > > static struct clockdomain atl_7xx_clkdm = { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 13 Jan 2017 09:15:37 -0800 From: Tony Lindgren To: Kishon Vijay Abraham I Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Message-ID: <20170113171537.GZ2630@atomide.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> MIME-Version: 1.0 In-Reply-To: <1484216786-17292-37-git-send-email-kishon@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, Jingoo Han , linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: * Kishon Vijay Abraham I [170112 02:35]: > The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > in RC mode. However in EP mode, the host system is not able to access the > MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. I guess ideally in the long run we would set this dynamically based on the selected mode, right? Regards, Tony > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c > index 6c67965..67ebff8 100644 > --- a/arch/arm/mach-omap2/clockdomains7xx_data.c > +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c > @@ -524,7 +524,7 @@ > .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, > .wkdep_srcs = pcie_wkup_sleep_deps, > .sleepdep_srcs = pcie_wkup_sleep_deps, > - .flags = CLKDM_CAN_HWSUP_SWSUP, > + .flags = CLKDM_CAN_SWSUP, > }; > > static struct clockdomain atl_7xx_clkdm = { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 13 Jan 2017 09:15:37 -0800 Subject: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP In-Reply-To: <1484216786-17292-37-git-send-email-kishon@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> Message-ID: <20170113171537.GZ2630@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Kishon Vijay Abraham I [170112 02:35]: > The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > in RC mode. However in EP mode, the host system is not able to access the > MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. I guess ideally in the long run we would set this dynamically based on the selected mode, right? Regards, Tony > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c > index 6c67965..67ebff8 100644 > --- a/arch/arm/mach-omap2/clockdomains7xx_data.c > +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c > @@ -524,7 +524,7 @@ > .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, > .wkdep_srcs = pcie_wkup_sleep_deps, > .sleepdep_srcs = pcie_wkup_sleep_deps, > - .flags = CLKDM_CAN_HWSUP_SWSUP, > + .flags = CLKDM_CAN_SWSUP, > }; > > static struct clockdomain atl_7xx_clkdm = { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >