From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Date: Fri, 13 Jan 2017 19:06:02 +0100 Message-ID: <20170113180602.GA30346@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1484216786-17292-17-git-send-email-kishon@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kishon Vijay Abraham I Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, Jingoo Han , linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org Hi Kishon, a couple comments on the configfs layout based on my experiments with your previous drop to implement a NVMe device using it. I don't think most of these configfs files should be present here, as they are properties of the implemented PCIe devices. E.g. for my NVMe device they will be sort of hardcoded most of the time, as they would be for other devices that would always have a fixed vendor/device/ class ID, cacheline size, etc. In the end what we'll to be able to do here is to be able to create a directory for each function driver, which then can create it's own attributes inside it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751303AbdAMSHK (ORCPT ); Fri, 13 Jan 2017 13:07:10 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:34174 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdAMSHD (ORCPT ); Fri, 13 Jan 2017 13:07:03 -0500 Date: Fri, 13 Jan 2017 19:06:02 +0100 From: Christoph Hellwig To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Message-ID: <20170113180602.GA30346@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484216786-17292-17-git-send-email-kishon@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, a couple comments on the configfs layout based on my experiments with your previous drop to implement a NVMe device using it. I don't think most of these configfs files should be present here, as they are properties of the implemented PCIe devices. E.g. for my NVMe device they will be sort of hardcoded most of the time, as they would be for other devices that would always have a fixed vendor/device/ class ID, cacheline size, etc. In the end what we'll to be able to do here is to be able to create a directory for each function driver, which then can create it's own attributes inside it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 13 Jan 2017 19:06:02 +0100 From: Christoph Hellwig To: Kishon Vijay Abraham I Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Message-ID: <20170113180602.GA30346@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> MIME-Version: 1.0 In-Reply-To: <1484216786-17292-17-git-send-email-kishon@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, Jingoo Han , linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Kishon, a couple comments on the configfs layout based on my experiments with your previous drop to implement a NVMe device using it. I don't think most of these configfs files should be present here, as they are properties of the implemented PCIe devices. E.g. for my NVMe device they will be sort of hardcoded most of the time, as they would be for other devices that would always have a fixed vendor/device/ class ID, cacheline size, etc. In the end what we'll to be able to do here is to be able to create a directory for each function driver, which then can create it's own attributes inside it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Fri, 13 Jan 2017 19:06:02 +0100 Subject: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions In-Reply-To: <1484216786-17292-17-git-send-email-kishon@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> Message-ID: <20170113180602.GA30346@infradead.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kishon, a couple comments on the configfs layout based on my experiments with your previous drop to implement a NVMe device using it. I don't think most of these configfs files should be present here, as they are properties of the implemented PCIe devices. E.g. for my NVMe device they will be sort of hardcoded most of the time, as they would be for other devices that would always have a fixed vendor/device/ class ID, cacheline size, etc. In the end what we'll to be able to do here is to be able to create a directory for each function driver, which then can create it's own attributes inside it.