From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751256AbdAMTEA (ORCPT ); Fri, 13 Jan 2017 14:04:00 -0500 Received: from fieldses.org ([173.255.197.46]:33988 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbdAMTD7 (ORCPT ); Fri, 13 Jan 2017 14:03:59 -0500 Date: Fri, 13 Jan 2017 14:03:57 -0500 From: "J. Bruce Fields" To: Christoph Hellwig Cc: Fabian Frederick , Al Viro , Andrew Morton , linux-kernel@vger.kernel.org, Jan Kara , linux-fsdevel@vger.kernel.org, neilb@suse.com Subject: Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable Message-ID: <20170113190357.GI24709@fieldses.org> References: <1483479039-5255-1-git-send-email-fabf@skynet.be> <20170103222906.GC1555@ZenIV.linux.org.uk> <736635494.1055379.1483509211858.open-xchange@webmail.nmp.proximus.be> <20170113173912.GH24709@fieldses.org> <20170113185254.GA6092@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113185254.GA6092@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 10:52:54AM -0800, Christoph Hellwig wrote: > On Fri, Jan 13, 2017 at 12:39:12PM -0500, J. Bruce Fields wrote: > > If we're going to reject patches that don't implement get_parent (and I > > think we should), then we should replace "optional but strongly > > recommended" there by just "mandatory". Any objections? > > In theory yes - we'll just need an exception (or dummy implementation) > for in-memory file systems like tmpfs. Hm, so does get_parent just never get called for tmpfs because the parent's always there already? Should be easy enough to document that exception. --b.