From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbdAPTlA (ORCPT ); Mon, 16 Jan 2017 14:41:00 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47306 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbdAPTk7 (ORCPT ); Mon, 16 Jan 2017 14:40:59 -0500 Date: Mon, 16 Jan 2017 14:40:51 -0500 (EST) Message-Id: <20170116.144051.1777999685832100508.davem@davemloft.net> To: basil@pacabunga.com Cc: jreuter@yaina.de, ralf@linux-mips.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, mcdermj@xenotropic.com, f6bvp@free.fr Subject: Re: [PATCH 1/1] ax25: Fix segfault after sock connection timeout From: David Miller In-Reply-To: <20170114121855.62254455@brox.localnet> References: <20170114121855.62254455@brox.localnet> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Jan 2017 10:41:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Basil Gunn Date: Sat, 14 Jan 2017 12:18:55 -0800 > The ax.25 socket connection timed out & the sock struct has been > previously taken down ie. sock struct is now a NULL pointer. Checking > the sock_flag causes the segfault. Check if the socket struct pointer > is NULL before checking sock_flag. This segfault is seen in > timed out netrom connections. > > Please submit to -stable. > > Signed-off-by: Basil Gunn This is consistent with the ax25->sk NULL check later in this function. Applied and queued up for -stable, thanks.