From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750994AbdAPI2u (ORCPT ); Mon, 16 Jan 2017 03:28:50 -0500 Received: from mail.kernel.org ([198.145.29.136]:47778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbdAPI2s (ORCPT ); Mon, 16 Jan 2017 03:28:48 -0500 Date: Mon, 16 Jan 2017 10:28:48 +0200 From: Leon Romanovsky To: Michal Hocko Cc: Andrew Morton , Vlastimil Babka , David Rientjes , Mel Gorman , Johannes Weiner , Al Viro , linux-mm@kvack.org, LKML , Martin Schwidefsky , Heiko Carstens , Herbert Xu , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , "Rafael J. Wysocki" , Ben Skeggs , Kent Overstreet , Santosh Raspatur , Hariprasad S , Tariq Toukan , Yishai Hadas , Dan Williams , Oleg Drokin , Andreas Dilger , Boris Ostrovsky , David Sterba , "Yan, Zheng" , Ilya Dryomov , Alexei Starovoitov , Eric Dumazet , netdev@vger.kernel.org Subject: Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants Message-ID: <20170116082848.GA32481@mtr-leonro.local> References: <20170112153717.28943-1-mhocko@kernel.org> <20170112153717.28943-6-mhocko@kernel.org> <20170114105632.GV20392@mtr-leonro.local> <20170116073310.GA7981@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <20170116073310.GA7981@dhcp22.suse.cz> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 16, 2017 at 08:33:11AM +0100, Michal Hocko wrote: > On Sat 14-01-17 12:56:32, Leon Romanovsky wrote: > [...] > > Hi Michal, > > > > I don't see mlx5_vzalloc in the changed list. Any reason why did you skip it? > > > > 881 static inline void *mlx5_vzalloc(unsigned long size) > > 882 { > > 883 void *rtn; > > 884 > > 885 rtn = kzalloc(size, GFP_KERNEL | __GFP_NOWARN); > > 886 if (!rtn) > > 887 rtn = vzalloc(size); > > 888 return rtn; > > 889 } > > No reason to skip it, I just didn't see it. I will fold the following in > if you are OK with it Sure, no problem. Once, the patch set is accepted, we (Mellanox) will get rid of mlx5_vzalloc(). Thanks > --- > diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h > index cdd2bd62f86d..5e6063170e48 100644 > --- a/include/linux/mlx5/driver.h > +++ b/include/linux/mlx5/driver.h > @@ -874,12 +874,7 @@ static inline u16 cmdif_rev(struct mlx5_core_dev *dev) > > static inline void *mlx5_vzalloc(unsigned long size) > { > - void *rtn; > - > - rtn = kzalloc(size, GFP_KERNEL | __GFP_NOWARN); > - if (!rtn) > - rtn = vzalloc(size); > - return rtn; > + return kvzalloc(GFP_KERNEL, size); > } > > static inline u32 mlx5_base_mkey(const u32 key) > > -- > Michal Hocko > SUSE Labs > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlh8hEAACgkQ5GN7iDZy WKfBNxAAkj0ybtP+5KSc+/M9wFhub8PFtORtxzgDRBAHYRABNvI3EiVJHEKpgATk LyEloC5fDyPla83eJ5euvFeQmxDf6ZXlW9FiA9Cbo9pY35b0TV6dacdGzvuDtbbo a+eiBrr9SBwqyqYsdbyD/gVp66qyVcw9qAUTIspnAD4T3z/6X01RCAot+np0Dfij ufCYftxKYXrHOuSy07lrqrCVMiPwr9DGwNuwEA4wjkQnZMEkhlygbT4ZgyEvc6A8 aP3hV84+9m5NSt+ziM/JjPyszG9DVRFTAjhezSS7DzhIHkrP/BJTCeomB22m+Gbr a6N5F5vHNjzoUQRgAbqNxKbGlle3Ae37Jn4qmlSp2nbHm/9oyJlWhSYlNuIxYuOc e3f6FKex3niJB0Om6bcfyANzQHQYlKiqI0fAUgZgfXFMw0597BvMxTvs4jRsjntG Eey2iKvnaaN2GtuuLtQPaGb6IIIe34flsuY8o2JQtwyrIPIT6i8jmvjv5CkQZhqj HkXX/ZTyIYibQAPqrpiRVd+m2ZTgi+wmj+kZuZ8KTKKZGz+IpaGEZ1xyD7XvQVqA +gDDmqgdU+hqQkBD7h4iOcUV9EpVz6olWtb3EvrsHF/7p0zwL25mp6Tf4ZDhpT7E J6r0Zz9paK3eE708RiX2Pc8OhcEfZ8C9uNW/rxxDMEj28/mf4Tw= =Qluq -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants Date: Mon, 16 Jan 2017 10:28:48 +0200 Message-ID: <20170116082848.GA32481@mtr-leonro.local> References: <20170112153717.28943-1-mhocko@kernel.org> <20170112153717.28943-6-mhocko@kernel.org> <20170114105632.GV20392@mtr-leonro.local> <20170116073310.GA7981@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Cc: Andrew Morton , Vlastimil Babka , David Rientjes , Mel Gorman , Johannes Weiner , Al Viro , linux-mm@kvack.org, LKML , Martin Schwidefsky , Heiko Carstens , Herbert Xu , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , "Rafael J. Wysocki" , Ben Skeggs , Kent Overstreet , Santosh Raspatur , Hariprasad S , Ta To: Michal Hocko Return-path: Content-Disposition: inline In-Reply-To: <20170116073310.GA7981@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 16, 2017 at 08:33:11AM +0100, Michal Hocko wrote: > On Sat 14-01-17 12:56:32, Leon Romanovsky wrote: > [...] > > Hi Michal, > > > > I don't see mlx5_vzalloc in the changed list. Any reason why did you skip it? > > > > 881 static inline void *mlx5_vzalloc(unsigned long size) > > 882 { > > 883 void *rtn; > > 884 > > 885 rtn = kzalloc(size, GFP_KERNEL | __GFP_NOWARN); > > 886 if (!rtn) > > 887 rtn = vzalloc(size); > > 888 return rtn; > > 889 } > > No reason to skip it, I just didn't see it. I will fold the following in > if you are OK with it Sure, no problem. Once, the patch set is accepted, we (Mellanox) will get rid of mlx5_vzalloc(). Thanks > --- > diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h > index cdd2bd62f86d..5e6063170e48 100644 > --- a/include/linux/mlx5/driver.h > +++ b/include/linux/mlx5/driver.h > @@ -874,12 +874,7 @@ static inline u16 cmdif_rev(struct mlx5_core_dev *dev) > > static inline void *mlx5_vzalloc(unsigned long size) > { > - void *rtn; > - > - rtn = kzalloc(size, GFP_KERNEL | __GFP_NOWARN); > - if (!rtn) > - rtn = vzalloc(size); > - return rtn; > + return kvzalloc(GFP_KERNEL, size); > } > > static inline u32 mlx5_base_mkey(const u32 key) > > -- > Michal Hocko > SUSE Labs > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlh8hEAACgkQ5GN7iDZy WKfBNxAAkj0ybtP+5KSc+/M9wFhub8PFtORtxzgDRBAHYRABNvI3EiVJHEKpgATk LyEloC5fDyPla83eJ5euvFeQmxDf6ZXlW9FiA9Cbo9pY35b0TV6dacdGzvuDtbbo a+eiBrr9SBwqyqYsdbyD/gVp66qyVcw9qAUTIspnAD4T3z/6X01RCAot+np0Dfij ufCYftxKYXrHOuSy07lrqrCVMiPwr9DGwNuwEA4wjkQnZMEkhlygbT4ZgyEvc6A8 aP3hV84+9m5NSt+ziM/JjPyszG9DVRFTAjhezSS7DzhIHkrP/BJTCeomB22m+Gbr a6N5F5vHNjzoUQRgAbqNxKbGlle3Ae37Jn4qmlSp2nbHm/9oyJlWhSYlNuIxYuOc e3f6FKex3niJB0Om6bcfyANzQHQYlKiqI0fAUgZgfXFMw0597BvMxTvs4jRsjntG Eey2iKvnaaN2GtuuLtQPaGb6IIIe34flsuY8o2JQtwyrIPIT6i8jmvjv5CkQZhqj HkXX/ZTyIYibQAPqrpiRVd+m2ZTgi+wmj+kZuZ8KTKKZGz+IpaGEZ1xyD7XvQVqA +gDDmqgdU+hqQkBD7h4iOcUV9EpVz6olWtb3EvrsHF/7p0zwL25mp6Tf4ZDhpT7E J6r0Zz9paK3eE708RiX2Pc8OhcEfZ8C9uNW/rxxDMEj28/mf4Tw= =Qluq -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--